f281233d3e
Move the mid-layer's ->queuecommand() invocation from being locked with the host lock to being unlocked to facilitate speeding up the critical path for drivers who don't need this lock taken anyway. The patch below presents a simple SCSI host lock push-down as an equivalent transformation. No locking or other behavior should change with this patch. All existing bugs and locking orders are preserved. Additionally, add one parameter to queuecommand, struct Scsi_Host * and remove one parameter from queuecommand, void (*done)(struct scsi_cmnd *) Scsi_Host* is a convenient pointer that most host drivers need anyway, and 'done' is redundant to struct scsi_cmnd->scsi_done. Minimal code disturbance was attempted with this change. Most drivers needed only two one-line modifications for their host lock push-down. Signed-off-by: Jeff Garzik <jgarzik@redhat.com> Acked-by: James Bottomley <James.Bottomley@suse.de> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
34 lines
1.1 KiB
C
34 lines
1.1 KiB
C
/*
|
|
* sym53c416.h
|
|
*
|
|
* Copyright (C) 1998 Lieven Willems (lw_linux@hotmail.com)
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify it
|
|
* under the terms of the GNU General Public License as published by the
|
|
* Free Software Foundation; either version 2, or (at your option) any
|
|
* later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful, but
|
|
* WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
*/
|
|
|
|
#ifndef _SYM53C416_H
|
|
#define _SYM53C416_H
|
|
|
|
#include <linux/types.h>
|
|
|
|
#define SYM53C416_SCSI_ID 7
|
|
|
|
static int sym53c416_detect(struct scsi_host_template *);
|
|
static const char *sym53c416_info(struct Scsi_Host *);
|
|
static int sym53c416_release(struct Scsi_Host *);
|
|
static int sym53c416_queuecommand(struct Scsi_Host *, struct scsi_cmnd *);
|
|
static int sym53c416_host_reset(Scsi_Cmnd *);
|
|
static int sym53c416_bios_param(struct scsi_device *, struct block_device *,
|
|
sector_t, int *);
|
|
static void sym53c416_setup(char *str, int *ints);
|
|
#endif
|