Sergei Shtylyov 0e66392d98 PCI: OF: Fix I/O space page leak ... commit a5fb9fb023 upstream. When testing the R-Car PCIe driver on the Condor board, if the PCIe PHY driver was left disabled, the kernel crashed with this BUG: kernel BUG at lib/ioremap.c:72! Internal error: Oops - BUG: 0 [#1] PREEMPT SMP Modules linked in: CPU: 0 PID: 39 Comm: kworker/0:1 Not tainted 4.17.0-dirty #1092 Hardware name: Renesas Condor board based on r8a77980 (DT) Workqueue: events deferred_probe_work_func pstate: 80000005 (Nzcv daif -PAN -UAO) pc : ioremap_page_range+0x370/0x3c8 lr : ioremap_page_range+0x40/0x3c8 sp : ffff000008da39e0 x29: ffff000008da39e0 x28: 00e8000000000f07 x27: ffff7dfffee00000 x26: 0140000000000000 x25: ffff7dfffef00000 x24: 00000000000fe100 x23: ffff80007b906000 x22: ffff000008ab8000 x21: ffff000008bb1d58 x20: ffff7dfffef00000 x19: ffff800009c30fb8 x18: 0000000000000001 x17: 00000000000152d0 x16: 00000000014012d0 x15: 0000000000000000 x14: 0720072007200720 x13: 0720072007200720 x12: 0720072007200720 x11: 0720072007300730 x10: 00000000000000ae x9 : 0000000000000000 x8 : ffff7dffff000000 x7 : 0000000000000000 x6 : 0000000000000100 x5 : 0000000000000000 x4 : 000000007b906000 x3 : ffff80007c61a880 x2 : ffff7dfffeefffff x1 : 0000000040000000 x0 : 00e80000fe100f07 Process kworker/0:1 (pid: 39, stack limit = 0x (ptrval)) Call trace: ioremap_page_range+0x370/0x3c8 pci_remap_iospace+0x7c/0xac pci_parse_request_of_pci_ranges+0x13c/0x190 rcar_pcie_probe+0x4c/0xb04 platform_drv_probe+0x50/0xbc driver_probe_device+0x21c/0x308 __device_attach_driver+0x98/0xc8 bus_for_each_drv+0x54/0x94 __device_attach+0xc4/0x12c device_initial_probe+0x10/0x18 bus_probe_device+0x90/0x98 deferred_probe_work_func+0xb0/0x150 process_one_work+0x12c/0x29c worker_thread+0x200/0x3fc kthread+0x108/0x134 ret_from_fork+0x10/0x18 Code: f9004ba2 54000080 aa0003fb 17ffff48 (d4210000) It turned out that pci_remap_iospace() wasn't undone when the driver's probe failed, and since devm_phy_optional_get() returned -EPROBE_DEFER, the probe was retried, finally causing the BUG due to trying to remap already remapped pages. Introduce the devm_pci_remap_iospace() managed API and replace the pci_remap_iospace() call with it to fix the bug. Fixes: dbf9826d57 ("PCI: generic: Convert to DT resource parsing API") Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> [lorenzo.pieralisi@arm.com: split commit/updated the commit log] Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2018-08-24 13:09:19 +02:00
..
acpi	ACPI / EC: Fix regression related to PM ops support in ECDT device	2017-12-05 11:26:33 +01:00
asm-generic	ioremap: Update pgtable free interfaces with addr	2018-08-17 21:01:11 +02:00
clocksource	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
crypto	crypto: vmac - separate tfm and request context	2018-08-17 21:01:10 +02:00
drm	drm: Add DP PSR2 sink enable bit	2018-08-03 07:50:42 +02:00
dt-bindings	dt-bindings: clock: mediatek: add binding for fixed-factor clock axisel_d4	2018-04-24 09:36:34 +02:00
keys	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
kvm	arm/arm64: KVM: Add PSCI version selection API	2018-05-01 12:58:27 -07:00
linux	PCI: OF: Fix I/O space page leak	2018-08-24 13:09:19 +02:00
math-emu	…
media	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
memory	…
misc	…
net	tcp: remove DELAYED ACK events in DCTCP	2018-08-24 13:09:17 +02:00
pcmcia	…
ras	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
rdma	IB/hfi1: Optimize kthread pointer locking when queuing CQ entries	2018-07-03 11:24:54 +02:00
scsi	scsi: core: introduce force_blk_mq	2018-08-15 18:12:47 +02:00
soc	memory: tegra: Apply interrupts mask per SoC	2018-08-03 07:50:38 +02:00
sound	ALSA: control: Hardening for potential Spectre v1	2018-05-01 12:58:16 -07:00
target	target: Avoid early CMD_T_PRE_EXECUTE failures during ABORT_TASK	2017-11-30 08:40:51 +00:00
trace	sched/debug: Fix task state recording/printout	2018-08-17 21:01:11 +02:00
uapi	nbd: Add the nbd NBD_DISCONNECT_ON_CLOSE config flag.	2018-08-24 13:09:03 +02:00
video	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
xen	xen/balloon: Mark unallocated host memory as UNUSABLE	2018-03-03 10:24:28 +01:00