![Ilya Dryomov](/assets/img/avatar_default.png)
Starting the kernel client with cephx disabled and then enabling cephx and restarting userspace daemons can result in a crash: [262671.478162] BUG: unable to handle kernel paging request at ffffebe000000000 [262671.531460] IP: [<ffffffff811cd04a>] kfree+0x5a/0x130 [262671.584334] PGD 0 [262671.635847] Oops: 0000 [#1] SMP [262672.055841] CPU: 22 PID: 2961272 Comm: kworker/22:2 Not tainted 4.2.0-34-generic #39~14.04.1-Ubuntu [262672.162338] Hardware name: Dell Inc. PowerEdge R720/068CDY, BIOS 2.4.3 07/09/2014 [262672.268937] Workqueue: ceph-msgr con_work [libceph] [262672.322290] task: ffff88081c2d0dc0 ti: ffff880149ae8000 task.ti: ffff880149ae8000 [262672.428330] RIP: 0010:[<ffffffff811cd04a>] [<ffffffff811cd04a>] kfree+0x5a/0x130 [262672.535880] RSP: 0018:ffff880149aeba58 EFLAGS: 00010286 [262672.589486] RAX: 000001e000000000 RBX: 0000000000000012 RCX: ffff8807e7461018 [262672.695980] RDX: 000077ff80000000 RSI: ffff88081af2be04 RDI: 0000000000000012 [262672.803668] RBP: ffff880149aeba78 R08: 0000000000000000 R09: 0000000000000000 [262672.912299] R10: ffffebe000000000 R11: ffff880819a60e78 R12: ffff8800aec8df40 [262673.021769] R13: ffffffffc035f70f R14: ffff8807e5b138e0 R15: ffff880da9785840 [262673.131722] FS: 0000000000000000(0000) GS:ffff88081fac0000(0000) knlGS:0000000000000000 [262673.245377] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [262673.303281] CR2: ffffebe000000000 CR3: 0000000001c0d000 CR4: 00000000001406e0 [262673.417556] Stack: [262673.472943] ffff880149aeba88 ffff88081af2be04 ffff8800aec8df40 ffff88081af2be04 [262673.583767] ffff880149aeba98 ffffffffc035f70f ffff880149aebac8 ffff8800aec8df00 [262673.694546] ffff880149aebac8 ffffffffc035c89e ffff8807e5b138e0 ffff8805b047f800 [262673.805230] Call Trace: [262673.859116] [<ffffffffc035f70f>] ceph_x_destroy_authorizer+0x1f/0x50 [libceph] [262673.968705] [<ffffffffc035c89e>] ceph_auth_destroy_authorizer+0x3e/0x60 [libceph] [262674.078852] [<ffffffffc0352805>] put_osd+0x45/0x80 [libceph] [262674.134249] [<ffffffffc035290e>] remove_osd+0xae/0x140 [libceph] [262674.189124] [<ffffffffc0352aa3>] __reset_osd+0x103/0x150 [libceph] [262674.243749] [<ffffffffc0354703>] kick_requests+0x223/0x460 [libceph] [262674.297485] [<ffffffffc03559e2>] ceph_osdc_handle_map+0x282/0x5e0 [libceph] [262674.350813] [<ffffffffc035022e>] dispatch+0x4e/0x720 [libceph] [262674.403312] [<ffffffffc034bd91>] try_read+0x3d1/0x1090 [libceph] [262674.454712] [<ffffffff810ab7c2>] ? dequeue_entity+0x152/0x690 [262674.505096] [<ffffffffc034cb1b>] con_work+0xcb/0x1300 [libceph] [262674.555104] [<ffffffff8108fb3e>] process_one_work+0x14e/0x3d0 [262674.604072] [<ffffffff810901ea>] worker_thread+0x11a/0x470 [262674.652187] [<ffffffff810900d0>] ? rescuer_thread+0x310/0x310 [262674.699022] [<ffffffff810957a2>] kthread+0xd2/0xf0 [262674.744494] [<ffffffff810956d0>] ? kthread_create_on_node+0x1c0/0x1c0 [262674.789543] [<ffffffff817bd81f>] ret_from_fork+0x3f/0x70 [262674.834094] [<ffffffff810956d0>] ? kthread_create_on_node+0x1c0/0x1c0 What happens is the following: (1) new MON session is established (2) old "none" ac is destroyed (3) new "cephx" ac is constructed ... (4) old OSD session (w/ "none" authorizer) is put ceph_auth_destroy_authorizer(ac, osd->o_auth.authorizer) osd->o_auth.authorizer in the "none" case is just a bare pointer into ac, which contains a single static copy for all services. By the time we get to (4), "none" ac, freed in (2), is long gone. On top of that, a new vtable installed in (3) points us at ceph_x_destroy_authorizer(), so we end up trying to destroy a "none" authorizer with a "cephx" destructor operating on invalid memory! To fix this, decouple authorizer destruction from ac and do away with a single static "none" authorizer by making a copy for each OSD or MDS session. Authorizers themselves are independent of ac and so there is no reason for destroy_authorizer() to be an ac op. Make it an op on the authorizer itself by turning ceph_authorizer into a real struct. Fixes: http://tracker.ceph.com/issues/15447 Reported-by: Alan Zhang <alan.zhang@linux.com> Signed-off-by: Ilya Dryomov <idryomov@gmail.com> Reviewed-by: Sage Weil <sage@redhat.com>
819 lines
19 KiB
C
819 lines
19 KiB
C
|
|
#include <linux/ceph/ceph_debug.h>
|
|
|
|
#include <linux/err.h>
|
|
#include <linux/module.h>
|
|
#include <linux/random.h>
|
|
#include <linux/slab.h>
|
|
|
|
#include <linux/ceph/decode.h>
|
|
#include <linux/ceph/auth.h>
|
|
#include <linux/ceph/libceph.h>
|
|
#include <linux/ceph/messenger.h>
|
|
|
|
#include "crypto.h"
|
|
#include "auth_x.h"
|
|
#include "auth_x_protocol.h"
|
|
|
|
static void ceph_x_validate_tickets(struct ceph_auth_client *ac, int *pneed);
|
|
|
|
static int ceph_x_is_authenticated(struct ceph_auth_client *ac)
|
|
{
|
|
struct ceph_x_info *xi = ac->private;
|
|
int need;
|
|
|
|
ceph_x_validate_tickets(ac, &need);
|
|
dout("ceph_x_is_authenticated want=%d need=%d have=%d\n",
|
|
ac->want_keys, need, xi->have_keys);
|
|
return (ac->want_keys & xi->have_keys) == ac->want_keys;
|
|
}
|
|
|
|
static int ceph_x_should_authenticate(struct ceph_auth_client *ac)
|
|
{
|
|
struct ceph_x_info *xi = ac->private;
|
|
int need;
|
|
|
|
ceph_x_validate_tickets(ac, &need);
|
|
dout("ceph_x_should_authenticate want=%d need=%d have=%d\n",
|
|
ac->want_keys, need, xi->have_keys);
|
|
return need != 0;
|
|
}
|
|
|
|
static int ceph_x_encrypt_buflen(int ilen)
|
|
{
|
|
return sizeof(struct ceph_x_encrypt_header) + ilen + 16 +
|
|
sizeof(u32);
|
|
}
|
|
|
|
static int ceph_x_encrypt(struct ceph_crypto_key *secret,
|
|
void *ibuf, int ilen, void *obuf, size_t olen)
|
|
{
|
|
struct ceph_x_encrypt_header head = {
|
|
.struct_v = 1,
|
|
.magic = cpu_to_le64(CEPHX_ENC_MAGIC)
|
|
};
|
|
size_t len = olen - sizeof(u32);
|
|
int ret;
|
|
|
|
ret = ceph_encrypt2(secret, obuf + sizeof(u32), &len,
|
|
&head, sizeof(head), ibuf, ilen);
|
|
if (ret)
|
|
return ret;
|
|
ceph_encode_32(&obuf, len);
|
|
return len + sizeof(u32);
|
|
}
|
|
|
|
static int ceph_x_decrypt(struct ceph_crypto_key *secret,
|
|
void **p, void *end, void **obuf, size_t olen)
|
|
{
|
|
struct ceph_x_encrypt_header head;
|
|
size_t head_len = sizeof(head);
|
|
int len, ret;
|
|
|
|
len = ceph_decode_32(p);
|
|
if (*p + len > end)
|
|
return -EINVAL;
|
|
|
|
dout("ceph_x_decrypt len %d\n", len);
|
|
if (*obuf == NULL) {
|
|
*obuf = kmalloc(len, GFP_NOFS);
|
|
if (!*obuf)
|
|
return -ENOMEM;
|
|
olen = len;
|
|
}
|
|
|
|
ret = ceph_decrypt2(secret, &head, &head_len, *obuf, &olen, *p, len);
|
|
if (ret)
|
|
return ret;
|
|
if (head.struct_v != 1 || le64_to_cpu(head.magic) != CEPHX_ENC_MAGIC)
|
|
return -EPERM;
|
|
*p += len;
|
|
return olen;
|
|
}
|
|
|
|
/*
|
|
* get existing (or insert new) ticket handler
|
|
*/
|
|
static struct ceph_x_ticket_handler *
|
|
get_ticket_handler(struct ceph_auth_client *ac, int service)
|
|
{
|
|
struct ceph_x_ticket_handler *th;
|
|
struct ceph_x_info *xi = ac->private;
|
|
struct rb_node *parent = NULL, **p = &xi->ticket_handlers.rb_node;
|
|
|
|
while (*p) {
|
|
parent = *p;
|
|
th = rb_entry(parent, struct ceph_x_ticket_handler, node);
|
|
if (service < th->service)
|
|
p = &(*p)->rb_left;
|
|
else if (service > th->service)
|
|
p = &(*p)->rb_right;
|
|
else
|
|
return th;
|
|
}
|
|
|
|
/* add it */
|
|
th = kzalloc(sizeof(*th), GFP_NOFS);
|
|
if (!th)
|
|
return ERR_PTR(-ENOMEM);
|
|
th->service = service;
|
|
rb_link_node(&th->node, parent, p);
|
|
rb_insert_color(&th->node, &xi->ticket_handlers);
|
|
return th;
|
|
}
|
|
|
|
static void remove_ticket_handler(struct ceph_auth_client *ac,
|
|
struct ceph_x_ticket_handler *th)
|
|
{
|
|
struct ceph_x_info *xi = ac->private;
|
|
|
|
dout("remove_ticket_handler %p %d\n", th, th->service);
|
|
rb_erase(&th->node, &xi->ticket_handlers);
|
|
ceph_crypto_key_destroy(&th->session_key);
|
|
if (th->ticket_blob)
|
|
ceph_buffer_put(th->ticket_blob);
|
|
kfree(th);
|
|
}
|
|
|
|
static int process_one_ticket(struct ceph_auth_client *ac,
|
|
struct ceph_crypto_key *secret,
|
|
void **p, void *end)
|
|
{
|
|
struct ceph_x_info *xi = ac->private;
|
|
int type;
|
|
u8 tkt_struct_v, blob_struct_v;
|
|
struct ceph_x_ticket_handler *th;
|
|
void *dbuf = NULL;
|
|
void *dp, *dend;
|
|
int dlen;
|
|
char is_enc;
|
|
struct timespec validity;
|
|
struct ceph_crypto_key old_key;
|
|
void *ticket_buf = NULL;
|
|
void *tp, *tpend;
|
|
void **ptp;
|
|
struct ceph_crypto_key new_session_key;
|
|
struct ceph_buffer *new_ticket_blob;
|
|
unsigned long new_expires, new_renew_after;
|
|
u64 new_secret_id;
|
|
int ret;
|
|
|
|
ceph_decode_need(p, end, sizeof(u32) + 1, bad);
|
|
|
|
type = ceph_decode_32(p);
|
|
dout(" ticket type %d %s\n", type, ceph_entity_type_name(type));
|
|
|
|
tkt_struct_v = ceph_decode_8(p);
|
|
if (tkt_struct_v != 1)
|
|
goto bad;
|
|
|
|
th = get_ticket_handler(ac, type);
|
|
if (IS_ERR(th)) {
|
|
ret = PTR_ERR(th);
|
|
goto out;
|
|
}
|
|
|
|
/* blob for me */
|
|
dlen = ceph_x_decrypt(secret, p, end, &dbuf, 0);
|
|
if (dlen <= 0) {
|
|
ret = dlen;
|
|
goto out;
|
|
}
|
|
dout(" decrypted %d bytes\n", dlen);
|
|
dp = dbuf;
|
|
dend = dp + dlen;
|
|
|
|
tkt_struct_v = ceph_decode_8(&dp);
|
|
if (tkt_struct_v != 1)
|
|
goto bad;
|
|
|
|
memcpy(&old_key, &th->session_key, sizeof(old_key));
|
|
ret = ceph_crypto_key_decode(&new_session_key, &dp, dend);
|
|
if (ret)
|
|
goto out;
|
|
|
|
ceph_decode_timespec(&validity, dp);
|
|
dp += sizeof(struct ceph_timespec);
|
|
new_expires = get_seconds() + validity.tv_sec;
|
|
new_renew_after = new_expires - (validity.tv_sec / 4);
|
|
dout(" expires=%lu renew_after=%lu\n", new_expires,
|
|
new_renew_after);
|
|
|
|
/* ticket blob for service */
|
|
ceph_decode_8_safe(p, end, is_enc, bad);
|
|
if (is_enc) {
|
|
/* encrypted */
|
|
dout(" encrypted ticket\n");
|
|
dlen = ceph_x_decrypt(&old_key, p, end, &ticket_buf, 0);
|
|
if (dlen < 0) {
|
|
ret = dlen;
|
|
goto out;
|
|
}
|
|
tp = ticket_buf;
|
|
ptp = &tp;
|
|
tpend = *ptp + dlen;
|
|
} else {
|
|
/* unencrypted */
|
|
ptp = p;
|
|
tpend = end;
|
|
}
|
|
ceph_decode_32_safe(ptp, tpend, dlen, bad);
|
|
dout(" ticket blob is %d bytes\n", dlen);
|
|
ceph_decode_need(ptp, tpend, 1 + sizeof(u64), bad);
|
|
blob_struct_v = ceph_decode_8(ptp);
|
|
new_secret_id = ceph_decode_64(ptp);
|
|
ret = ceph_decode_buffer(&new_ticket_blob, ptp, tpend);
|
|
if (ret)
|
|
goto out;
|
|
|
|
/* all is well, update our ticket */
|
|
ceph_crypto_key_destroy(&th->session_key);
|
|
if (th->ticket_blob)
|
|
ceph_buffer_put(th->ticket_blob);
|
|
th->session_key = new_session_key;
|
|
th->ticket_blob = new_ticket_blob;
|
|
th->secret_id = new_secret_id;
|
|
th->expires = new_expires;
|
|
th->renew_after = new_renew_after;
|
|
th->have_key = true;
|
|
dout(" got ticket service %d (%s) secret_id %lld len %d\n",
|
|
type, ceph_entity_type_name(type), th->secret_id,
|
|
(int)th->ticket_blob->vec.iov_len);
|
|
xi->have_keys |= th->service;
|
|
|
|
out:
|
|
kfree(ticket_buf);
|
|
kfree(dbuf);
|
|
return ret;
|
|
|
|
bad:
|
|
ret = -EINVAL;
|
|
goto out;
|
|
}
|
|
|
|
static int ceph_x_proc_ticket_reply(struct ceph_auth_client *ac,
|
|
struct ceph_crypto_key *secret,
|
|
void *buf, void *end)
|
|
{
|
|
void *p = buf;
|
|
u8 reply_struct_v;
|
|
u32 num;
|
|
int ret;
|
|
|
|
ceph_decode_8_safe(&p, end, reply_struct_v, bad);
|
|
if (reply_struct_v != 1)
|
|
return -EINVAL;
|
|
|
|
ceph_decode_32_safe(&p, end, num, bad);
|
|
dout("%d tickets\n", num);
|
|
|
|
while (num--) {
|
|
ret = process_one_ticket(ac, secret, &p, end);
|
|
if (ret)
|
|
return ret;
|
|
}
|
|
|
|
return 0;
|
|
|
|
bad:
|
|
return -EINVAL;
|
|
}
|
|
|
|
static void ceph_x_authorizer_cleanup(struct ceph_x_authorizer *au)
|
|
{
|
|
ceph_crypto_key_destroy(&au->session_key);
|
|
if (au->buf) {
|
|
ceph_buffer_put(au->buf);
|
|
au->buf = NULL;
|
|
}
|
|
}
|
|
|
|
static int ceph_x_build_authorizer(struct ceph_auth_client *ac,
|
|
struct ceph_x_ticket_handler *th,
|
|
struct ceph_x_authorizer *au)
|
|
{
|
|
int maxlen;
|
|
struct ceph_x_authorize_a *msg_a;
|
|
struct ceph_x_authorize_b msg_b;
|
|
void *p, *end;
|
|
int ret;
|
|
int ticket_blob_len =
|
|
(th->ticket_blob ? th->ticket_blob->vec.iov_len : 0);
|
|
|
|
dout("build_authorizer for %s %p\n",
|
|
ceph_entity_type_name(th->service), au);
|
|
|
|
ceph_crypto_key_destroy(&au->session_key);
|
|
ret = ceph_crypto_key_clone(&au->session_key, &th->session_key);
|
|
if (ret)
|
|
goto out_au;
|
|
|
|
maxlen = sizeof(*msg_a) + sizeof(msg_b) +
|
|
ceph_x_encrypt_buflen(ticket_blob_len);
|
|
dout(" need len %d\n", maxlen);
|
|
if (au->buf && au->buf->alloc_len < maxlen) {
|
|
ceph_buffer_put(au->buf);
|
|
au->buf = NULL;
|
|
}
|
|
if (!au->buf) {
|
|
au->buf = ceph_buffer_new(maxlen, GFP_NOFS);
|
|
if (!au->buf) {
|
|
ret = -ENOMEM;
|
|
goto out_au;
|
|
}
|
|
}
|
|
au->service = th->service;
|
|
au->secret_id = th->secret_id;
|
|
|
|
msg_a = au->buf->vec.iov_base;
|
|
msg_a->struct_v = 1;
|
|
msg_a->global_id = cpu_to_le64(ac->global_id);
|
|
msg_a->service_id = cpu_to_le32(th->service);
|
|
msg_a->ticket_blob.struct_v = 1;
|
|
msg_a->ticket_blob.secret_id = cpu_to_le64(th->secret_id);
|
|
msg_a->ticket_blob.blob_len = cpu_to_le32(ticket_blob_len);
|
|
if (ticket_blob_len) {
|
|
memcpy(msg_a->ticket_blob.blob, th->ticket_blob->vec.iov_base,
|
|
th->ticket_blob->vec.iov_len);
|
|
}
|
|
dout(" th %p secret_id %lld %lld\n", th, th->secret_id,
|
|
le64_to_cpu(msg_a->ticket_blob.secret_id));
|
|
|
|
p = msg_a + 1;
|
|
p += ticket_blob_len;
|
|
end = au->buf->vec.iov_base + au->buf->vec.iov_len;
|
|
|
|
get_random_bytes(&au->nonce, sizeof(au->nonce));
|
|
msg_b.struct_v = 1;
|
|
msg_b.nonce = cpu_to_le64(au->nonce);
|
|
ret = ceph_x_encrypt(&au->session_key, &msg_b, sizeof(msg_b),
|
|
p, end - p);
|
|
if (ret < 0)
|
|
goto out_au;
|
|
p += ret;
|
|
au->buf->vec.iov_len = p - au->buf->vec.iov_base;
|
|
dout(" built authorizer nonce %llx len %d\n", au->nonce,
|
|
(int)au->buf->vec.iov_len);
|
|
BUG_ON(au->buf->vec.iov_len > maxlen);
|
|
return 0;
|
|
|
|
out_au:
|
|
ceph_x_authorizer_cleanup(au);
|
|
return ret;
|
|
}
|
|
|
|
static int ceph_x_encode_ticket(struct ceph_x_ticket_handler *th,
|
|
void **p, void *end)
|
|
{
|
|
ceph_decode_need(p, end, 1 + sizeof(u64), bad);
|
|
ceph_encode_8(p, 1);
|
|
ceph_encode_64(p, th->secret_id);
|
|
if (th->ticket_blob) {
|
|
const char *buf = th->ticket_blob->vec.iov_base;
|
|
u32 len = th->ticket_blob->vec.iov_len;
|
|
|
|
ceph_encode_32_safe(p, end, len, bad);
|
|
ceph_encode_copy_safe(p, end, buf, len, bad);
|
|
} else {
|
|
ceph_encode_32_safe(p, end, 0, bad);
|
|
}
|
|
|
|
return 0;
|
|
bad:
|
|
return -ERANGE;
|
|
}
|
|
|
|
static bool need_key(struct ceph_x_ticket_handler *th)
|
|
{
|
|
if (!th->have_key)
|
|
return true;
|
|
|
|
return get_seconds() >= th->renew_after;
|
|
}
|
|
|
|
static bool have_key(struct ceph_x_ticket_handler *th)
|
|
{
|
|
if (th->have_key) {
|
|
if (get_seconds() >= th->expires)
|
|
th->have_key = false;
|
|
}
|
|
|
|
return th->have_key;
|
|
}
|
|
|
|
static void ceph_x_validate_tickets(struct ceph_auth_client *ac, int *pneed)
|
|
{
|
|
int want = ac->want_keys;
|
|
struct ceph_x_info *xi = ac->private;
|
|
int service;
|
|
|
|
*pneed = ac->want_keys & ~(xi->have_keys);
|
|
|
|
for (service = 1; service <= want; service <<= 1) {
|
|
struct ceph_x_ticket_handler *th;
|
|
|
|
if (!(ac->want_keys & service))
|
|
continue;
|
|
|
|
if (*pneed & service)
|
|
continue;
|
|
|
|
th = get_ticket_handler(ac, service);
|
|
if (IS_ERR(th)) {
|
|
*pneed |= service;
|
|
continue;
|
|
}
|
|
|
|
if (need_key(th))
|
|
*pneed |= service;
|
|
if (!have_key(th))
|
|
xi->have_keys &= ~service;
|
|
}
|
|
}
|
|
|
|
static int ceph_x_build_request(struct ceph_auth_client *ac,
|
|
void *buf, void *end)
|
|
{
|
|
struct ceph_x_info *xi = ac->private;
|
|
int need;
|
|
struct ceph_x_request_header *head = buf;
|
|
int ret;
|
|
struct ceph_x_ticket_handler *th =
|
|
get_ticket_handler(ac, CEPH_ENTITY_TYPE_AUTH);
|
|
|
|
if (IS_ERR(th))
|
|
return PTR_ERR(th);
|
|
|
|
ceph_x_validate_tickets(ac, &need);
|
|
|
|
dout("build_request want %x have %x need %x\n",
|
|
ac->want_keys, xi->have_keys, need);
|
|
|
|
if (need & CEPH_ENTITY_TYPE_AUTH) {
|
|
struct ceph_x_authenticate *auth = (void *)(head + 1);
|
|
void *p = auth + 1;
|
|
struct ceph_x_challenge_blob tmp;
|
|
char tmp_enc[40];
|
|
u64 *u;
|
|
|
|
if (p > end)
|
|
return -ERANGE;
|
|
|
|
dout(" get_auth_session_key\n");
|
|
head->op = cpu_to_le16(CEPHX_GET_AUTH_SESSION_KEY);
|
|
|
|
/* encrypt and hash */
|
|
get_random_bytes(&auth->client_challenge, sizeof(u64));
|
|
tmp.client_challenge = auth->client_challenge;
|
|
tmp.server_challenge = cpu_to_le64(xi->server_challenge);
|
|
ret = ceph_x_encrypt(&xi->secret, &tmp, sizeof(tmp),
|
|
tmp_enc, sizeof(tmp_enc));
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
auth->struct_v = 1;
|
|
auth->key = 0;
|
|
for (u = (u64 *)tmp_enc; u + 1 <= (u64 *)(tmp_enc + ret); u++)
|
|
auth->key ^= *(__le64 *)u;
|
|
dout(" server_challenge %llx client_challenge %llx key %llx\n",
|
|
xi->server_challenge, le64_to_cpu(auth->client_challenge),
|
|
le64_to_cpu(auth->key));
|
|
|
|
/* now encode the old ticket if exists */
|
|
ret = ceph_x_encode_ticket(th, &p, end);
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
return p - buf;
|
|
}
|
|
|
|
if (need) {
|
|
void *p = head + 1;
|
|
struct ceph_x_service_ticket_request *req;
|
|
|
|
if (p > end)
|
|
return -ERANGE;
|
|
head->op = cpu_to_le16(CEPHX_GET_PRINCIPAL_SESSION_KEY);
|
|
|
|
ret = ceph_x_build_authorizer(ac, th, &xi->auth_authorizer);
|
|
if (ret)
|
|
return ret;
|
|
ceph_encode_copy(&p, xi->auth_authorizer.buf->vec.iov_base,
|
|
xi->auth_authorizer.buf->vec.iov_len);
|
|
|
|
req = p;
|
|
req->keys = cpu_to_le32(need);
|
|
p += sizeof(*req);
|
|
return p - buf;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int ceph_x_handle_reply(struct ceph_auth_client *ac, int result,
|
|
void *buf, void *end)
|
|
{
|
|
struct ceph_x_info *xi = ac->private;
|
|
struct ceph_x_reply_header *head = buf;
|
|
struct ceph_x_ticket_handler *th;
|
|
int len = end - buf;
|
|
int op;
|
|
int ret;
|
|
|
|
if (result)
|
|
return result; /* XXX hmm? */
|
|
|
|
if (xi->starting) {
|
|
/* it's a hello */
|
|
struct ceph_x_server_challenge *sc = buf;
|
|
|
|
if (len != sizeof(*sc))
|
|
return -EINVAL;
|
|
xi->server_challenge = le64_to_cpu(sc->server_challenge);
|
|
dout("handle_reply got server challenge %llx\n",
|
|
xi->server_challenge);
|
|
xi->starting = false;
|
|
xi->have_keys &= ~CEPH_ENTITY_TYPE_AUTH;
|
|
return -EAGAIN;
|
|
}
|
|
|
|
op = le16_to_cpu(head->op);
|
|
result = le32_to_cpu(head->result);
|
|
dout("handle_reply op %d result %d\n", op, result);
|
|
switch (op) {
|
|
case CEPHX_GET_AUTH_SESSION_KEY:
|
|
/* verify auth key */
|
|
ret = ceph_x_proc_ticket_reply(ac, &xi->secret,
|
|
buf + sizeof(*head), end);
|
|
break;
|
|
|
|
case CEPHX_GET_PRINCIPAL_SESSION_KEY:
|
|
th = get_ticket_handler(ac, CEPH_ENTITY_TYPE_AUTH);
|
|
if (IS_ERR(th))
|
|
return PTR_ERR(th);
|
|
ret = ceph_x_proc_ticket_reply(ac, &th->session_key,
|
|
buf + sizeof(*head), end);
|
|
break;
|
|
|
|
default:
|
|
return -EINVAL;
|
|
}
|
|
if (ret)
|
|
return ret;
|
|
if (ac->want_keys == xi->have_keys)
|
|
return 0;
|
|
return -EAGAIN;
|
|
}
|
|
|
|
static void ceph_x_destroy_authorizer(struct ceph_authorizer *a)
|
|
{
|
|
struct ceph_x_authorizer *au = (void *)a;
|
|
|
|
ceph_x_authorizer_cleanup(au);
|
|
kfree(au);
|
|
}
|
|
|
|
static int ceph_x_create_authorizer(
|
|
struct ceph_auth_client *ac, int peer_type,
|
|
struct ceph_auth_handshake *auth)
|
|
{
|
|
struct ceph_x_authorizer *au;
|
|
struct ceph_x_ticket_handler *th;
|
|
int ret;
|
|
|
|
th = get_ticket_handler(ac, peer_type);
|
|
if (IS_ERR(th))
|
|
return PTR_ERR(th);
|
|
|
|
au = kzalloc(sizeof(*au), GFP_NOFS);
|
|
if (!au)
|
|
return -ENOMEM;
|
|
|
|
au->base.destroy = ceph_x_destroy_authorizer;
|
|
|
|
ret = ceph_x_build_authorizer(ac, th, au);
|
|
if (ret) {
|
|
kfree(au);
|
|
return ret;
|
|
}
|
|
|
|
auth->authorizer = (struct ceph_authorizer *) au;
|
|
auth->authorizer_buf = au->buf->vec.iov_base;
|
|
auth->authorizer_buf_len = au->buf->vec.iov_len;
|
|
auth->authorizer_reply_buf = au->reply_buf;
|
|
auth->authorizer_reply_buf_len = sizeof (au->reply_buf);
|
|
auth->sign_message = ac->ops->sign_message;
|
|
auth->check_message_signature = ac->ops->check_message_signature;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int ceph_x_update_authorizer(
|
|
struct ceph_auth_client *ac, int peer_type,
|
|
struct ceph_auth_handshake *auth)
|
|
{
|
|
struct ceph_x_authorizer *au;
|
|
struct ceph_x_ticket_handler *th;
|
|
|
|
th = get_ticket_handler(ac, peer_type);
|
|
if (IS_ERR(th))
|
|
return PTR_ERR(th);
|
|
|
|
au = (struct ceph_x_authorizer *)auth->authorizer;
|
|
if (au->secret_id < th->secret_id) {
|
|
dout("ceph_x_update_authorizer service %u secret %llu < %llu\n",
|
|
au->service, au->secret_id, th->secret_id);
|
|
return ceph_x_build_authorizer(ac, th, au);
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
static int ceph_x_verify_authorizer_reply(struct ceph_auth_client *ac,
|
|
struct ceph_authorizer *a, size_t len)
|
|
{
|
|
struct ceph_x_authorizer *au = (void *)a;
|
|
int ret = 0;
|
|
struct ceph_x_authorize_reply reply;
|
|
void *preply = &reply;
|
|
void *p = au->reply_buf;
|
|
void *end = p + sizeof(au->reply_buf);
|
|
|
|
ret = ceph_x_decrypt(&au->session_key, &p, end, &preply, sizeof(reply));
|
|
if (ret < 0)
|
|
return ret;
|
|
if (ret != sizeof(reply))
|
|
return -EPERM;
|
|
|
|
if (au->nonce + 1 != le64_to_cpu(reply.nonce_plus_one))
|
|
ret = -EPERM;
|
|
else
|
|
ret = 0;
|
|
dout("verify_authorizer_reply nonce %llx got %llx ret %d\n",
|
|
au->nonce, le64_to_cpu(reply.nonce_plus_one), ret);
|
|
return ret;
|
|
}
|
|
|
|
static void ceph_x_reset(struct ceph_auth_client *ac)
|
|
{
|
|
struct ceph_x_info *xi = ac->private;
|
|
|
|
dout("reset\n");
|
|
xi->starting = true;
|
|
xi->server_challenge = 0;
|
|
}
|
|
|
|
static void ceph_x_destroy(struct ceph_auth_client *ac)
|
|
{
|
|
struct ceph_x_info *xi = ac->private;
|
|
struct rb_node *p;
|
|
|
|
dout("ceph_x_destroy %p\n", ac);
|
|
ceph_crypto_key_destroy(&xi->secret);
|
|
|
|
while ((p = rb_first(&xi->ticket_handlers)) != NULL) {
|
|
struct ceph_x_ticket_handler *th =
|
|
rb_entry(p, struct ceph_x_ticket_handler, node);
|
|
remove_ticket_handler(ac, th);
|
|
}
|
|
|
|
ceph_x_authorizer_cleanup(&xi->auth_authorizer);
|
|
|
|
kfree(ac->private);
|
|
ac->private = NULL;
|
|
}
|
|
|
|
static void invalidate_ticket(struct ceph_auth_client *ac, int peer_type)
|
|
{
|
|
struct ceph_x_ticket_handler *th;
|
|
|
|
th = get_ticket_handler(ac, peer_type);
|
|
if (!IS_ERR(th))
|
|
th->have_key = false;
|
|
}
|
|
|
|
static void ceph_x_invalidate_authorizer(struct ceph_auth_client *ac,
|
|
int peer_type)
|
|
{
|
|
/*
|
|
* We are to invalidate a service ticket in the hopes of
|
|
* getting a new, hopefully more valid, one. But, we won't get
|
|
* it unless our AUTH ticket is good, so invalidate AUTH ticket
|
|
* as well, just in case.
|
|
*/
|
|
invalidate_ticket(ac, peer_type);
|
|
invalidate_ticket(ac, CEPH_ENTITY_TYPE_AUTH);
|
|
}
|
|
|
|
static int calcu_signature(struct ceph_x_authorizer *au,
|
|
struct ceph_msg *msg, __le64 *sig)
|
|
{
|
|
int ret;
|
|
char tmp_enc[40];
|
|
__le32 tmp[5] = {
|
|
cpu_to_le32(16), msg->hdr.crc, msg->footer.front_crc,
|
|
msg->footer.middle_crc, msg->footer.data_crc,
|
|
};
|
|
ret = ceph_x_encrypt(&au->session_key, &tmp, sizeof(tmp),
|
|
tmp_enc, sizeof(tmp_enc));
|
|
if (ret < 0)
|
|
return ret;
|
|
*sig = *(__le64*)(tmp_enc + 4);
|
|
return 0;
|
|
}
|
|
|
|
static int ceph_x_sign_message(struct ceph_auth_handshake *auth,
|
|
struct ceph_msg *msg)
|
|
{
|
|
int ret;
|
|
|
|
if (ceph_test_opt(from_msgr(msg->con->msgr), NOMSGSIGN))
|
|
return 0;
|
|
|
|
ret = calcu_signature((struct ceph_x_authorizer *)auth->authorizer,
|
|
msg, &msg->footer.sig);
|
|
if (ret < 0)
|
|
return ret;
|
|
msg->footer.flags |= CEPH_MSG_FOOTER_SIGNED;
|
|
return 0;
|
|
}
|
|
|
|
static int ceph_x_check_message_signature(struct ceph_auth_handshake *auth,
|
|
struct ceph_msg *msg)
|
|
{
|
|
__le64 sig_check;
|
|
int ret;
|
|
|
|
if (ceph_test_opt(from_msgr(msg->con->msgr), NOMSGSIGN))
|
|
return 0;
|
|
|
|
ret = calcu_signature((struct ceph_x_authorizer *)auth->authorizer,
|
|
msg, &sig_check);
|
|
if (ret < 0)
|
|
return ret;
|
|
if (sig_check == msg->footer.sig)
|
|
return 0;
|
|
if (msg->footer.flags & CEPH_MSG_FOOTER_SIGNED)
|
|
dout("ceph_x_check_message_signature %p has signature %llx "
|
|
"expect %llx\n", msg, msg->footer.sig, sig_check);
|
|
else
|
|
dout("ceph_x_check_message_signature %p sender did not set "
|
|
"CEPH_MSG_FOOTER_SIGNED\n", msg);
|
|
return -EBADMSG;
|
|
}
|
|
|
|
static const struct ceph_auth_client_ops ceph_x_ops = {
|
|
.name = "x",
|
|
.is_authenticated = ceph_x_is_authenticated,
|
|
.should_authenticate = ceph_x_should_authenticate,
|
|
.build_request = ceph_x_build_request,
|
|
.handle_reply = ceph_x_handle_reply,
|
|
.create_authorizer = ceph_x_create_authorizer,
|
|
.update_authorizer = ceph_x_update_authorizer,
|
|
.verify_authorizer_reply = ceph_x_verify_authorizer_reply,
|
|
.invalidate_authorizer = ceph_x_invalidate_authorizer,
|
|
.reset = ceph_x_reset,
|
|
.destroy = ceph_x_destroy,
|
|
.sign_message = ceph_x_sign_message,
|
|
.check_message_signature = ceph_x_check_message_signature,
|
|
};
|
|
|
|
|
|
int ceph_x_init(struct ceph_auth_client *ac)
|
|
{
|
|
struct ceph_x_info *xi;
|
|
int ret;
|
|
|
|
dout("ceph_x_init %p\n", ac);
|
|
ret = -ENOMEM;
|
|
xi = kzalloc(sizeof(*xi), GFP_NOFS);
|
|
if (!xi)
|
|
goto out;
|
|
|
|
ret = -EINVAL;
|
|
if (!ac->key) {
|
|
pr_err("no secret set (for auth_x protocol)\n");
|
|
goto out_nomem;
|
|
}
|
|
|
|
ret = ceph_crypto_key_clone(&xi->secret, ac->key);
|
|
if (ret < 0) {
|
|
pr_err("cannot clone key: %d\n", ret);
|
|
goto out_nomem;
|
|
}
|
|
|
|
xi->starting = true;
|
|
xi->ticket_handlers = RB_ROOT;
|
|
|
|
ac->protocol = CEPH_AUTH_CEPHX;
|
|
ac->private = xi;
|
|
ac->ops = &ceph_x_ops;
|
|
return 0;
|
|
|
|
out_nomem:
|
|
kfree(xi);
|
|
out:
|
|
return ret;
|
|
}
|
|
|
|
|