1
0
Fork 0
remarkable-linux/drivers/pinctrl/samsung
Thomas Gleixner 3fa53ec2ed pinctrl: samsung: Remove bogus irq_[un]mask from resource management
The irq chip callbacks irq_request/release_resources() have absolutely no
business with masking and unmasking the irq.

The core code unmasks the interrupt after complete setup and masks it
before invoking irq_release_resources().

The unmask is actually harmful as it happens before the interrupt is
completely initialized in __setup_irq().

Remove it.

Fixes: f6a8249f9e ("pinctrl: exynos: Lock GPIOs as interrupts when used as EINTs")
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Kukjin Kim <kgene@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org
Cc: linux-gpio@vger.kernel.org
Acked-by: Tomasz Figa <tomasz.figa@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
2017-06-30 15:51:42 +02:00
..
Kconfig pinctrl: samsung: Split Exynos drivers per ARMv7 and ARMv8 2017-06-07 20:40:47 +02:00
Makefile pinctrl: samsung: Split Exynos drivers per ARMv7 and ARMv8 2017-06-07 20:40:47 +02:00
pinctrl-exynos-arm.c pinctrl: samsung: Explicitly cast pointer returned by of_iomap() to iomem 2017-06-07 20:40:48 +02:00
pinctrl-exynos-arm64.c pinctrl: samsung: Split Exynos drivers per ARMv7 and ARMv8 2017-06-07 20:40:47 +02:00
pinctrl-exynos.c pinctrl: samsung: Remove bogus irq_[un]mask from resource management 2017-06-30 15:51:42 +02:00
pinctrl-exynos.h pinctrl: samsung: Split Exynos drivers per ARMv7 and ARMv8 2017-06-07 20:40:47 +02:00
pinctrl-exynos5440.c pinctrl: samsung: Clean up modular vs. non-modular distinctions 2017-05-23 16:49:17 +02:00
pinctrl-s3c24xx.c pinctrl: samsung: Clean up modular vs. non-modular distinctions 2017-05-23 16:49:17 +02:00
pinctrl-s3c64xx.c pinctrl: samsung: Clean up modular vs. non-modular distinctions 2017-05-23 16:49:17 +02:00
pinctrl-samsung.c pinctrl: samsung: Split Exynos drivers per ARMv7 and ARMv8 2017-06-07 20:40:47 +02:00
pinctrl-samsung.h pinctrl: samsung: Add infrastructure for pin-bank retention control 2017-01-26 16:35:50 +01:00