32f638fc11
acpi_pci_get_bridge_handle() returns the ACPI handle for the bridge device
(either a host bridge or a PCI-to-PCI bridge) leading to a PCI bus. But
SR-IOV virtual functions can be on a virtual bus with no bridge leading to
it. Return a NULL acpi_handle in this case instead of trying to
dereference the NULL pointer to the bridge.
This fixes a NULL pointer dereference oops in pci_get_hp_params() when
adding SR-IOV VF devices on virtual buses.
[bhelgaas: changelog, add comment in code]
Fixes: 6cd33649fa ("PCI: Add pci_configure_device() during enumeration")
Link: https://bugzilla.kernel.org/show_bug.cgi?id=87591
Reported-by: Chao Zhou <chao.zhou@intel.com>
Reported-by: Joerg Roedel <joro@8bytes.org>
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
92 lines
2.5 KiB
C
92 lines
2.5 KiB
C
/*
|
|
* File pci-acpi.h
|
|
*
|
|
* Copyright (C) 2004 Intel
|
|
* Copyright (C) Tom Long Nguyen (tom.l.nguyen@intel.com)
|
|
*/
|
|
|
|
#ifndef _PCI_ACPI_H_
|
|
#define _PCI_ACPI_H_
|
|
|
|
#include <linux/acpi.h>
|
|
|
|
#ifdef CONFIG_ACPI
|
|
extern acpi_status pci_acpi_add_bus_pm_notifier(struct acpi_device *dev);
|
|
static inline acpi_status pci_acpi_remove_bus_pm_notifier(struct acpi_device *dev)
|
|
{
|
|
return acpi_remove_pm_notifier(dev);
|
|
}
|
|
extern acpi_status pci_acpi_add_pm_notifier(struct acpi_device *dev,
|
|
struct pci_dev *pci_dev);
|
|
static inline acpi_status pci_acpi_remove_pm_notifier(struct acpi_device *dev)
|
|
{
|
|
return acpi_remove_pm_notifier(dev);
|
|
}
|
|
extern phys_addr_t acpi_pci_root_get_mcfg_addr(acpi_handle handle);
|
|
|
|
static inline acpi_handle acpi_find_root_bridge_handle(struct pci_dev *pdev)
|
|
{
|
|
struct pci_bus *pbus = pdev->bus;
|
|
|
|
/* Find a PCI root bus */
|
|
while (!pci_is_root_bus(pbus))
|
|
pbus = pbus->parent;
|
|
|
|
return ACPI_HANDLE(pbus->bridge);
|
|
}
|
|
|
|
static inline acpi_handle acpi_pci_get_bridge_handle(struct pci_bus *pbus)
|
|
{
|
|
struct device *dev;
|
|
|
|
if (pci_is_root_bus(pbus))
|
|
dev = pbus->bridge;
|
|
else {
|
|
/* If pbus is a virtual bus, there is no bridge to it */
|
|
if (!pbus->self)
|
|
return NULL;
|
|
|
|
dev = &pbus->self->dev;
|
|
}
|
|
|
|
return ACPI_HANDLE(dev);
|
|
}
|
|
|
|
void acpi_pci_add_bus(struct pci_bus *bus);
|
|
void acpi_pci_remove_bus(struct pci_bus *bus);
|
|
|
|
#ifdef CONFIG_ACPI_PCI_SLOT
|
|
void acpi_pci_slot_init(void);
|
|
void acpi_pci_slot_enumerate(struct pci_bus *bus);
|
|
void acpi_pci_slot_remove(struct pci_bus *bus);
|
|
#else
|
|
static inline void acpi_pci_slot_init(void) { }
|
|
static inline void acpi_pci_slot_enumerate(struct pci_bus *bus) { }
|
|
static inline void acpi_pci_slot_remove(struct pci_bus *bus) { }
|
|
#endif
|
|
|
|
#ifdef CONFIG_HOTPLUG_PCI_ACPI
|
|
void acpiphp_init(void);
|
|
void acpiphp_enumerate_slots(struct pci_bus *bus);
|
|
void acpiphp_remove_slots(struct pci_bus *bus);
|
|
void acpiphp_check_host_bridge(struct acpi_device *adev);
|
|
#else
|
|
static inline void acpiphp_init(void) { }
|
|
static inline void acpiphp_enumerate_slots(struct pci_bus *bus) { }
|
|
static inline void acpiphp_remove_slots(struct pci_bus *bus) { }
|
|
static inline void acpiphp_check_host_bridge(struct acpi_device *adev) { }
|
|
#endif
|
|
|
|
#else /* CONFIG_ACPI */
|
|
static inline void acpi_pci_add_bus(struct pci_bus *bus) { }
|
|
static inline void acpi_pci_remove_bus(struct pci_bus *bus) { }
|
|
#endif /* CONFIG_ACPI */
|
|
|
|
#ifdef CONFIG_ACPI_APEI
|
|
extern bool aer_acpi_firmware_first(void);
|
|
#else
|
|
static inline bool aer_acpi_firmware_first(void) { return false; }
|
|
#endif
|
|
|
|
#endif /* _PCI_ACPI_H_ */
|