197b958c1e
The OSS sequencer client tries to drain the pending events at releasing. Unfortunately, as spotted by syzkaller fuzzer, this may lead to an unkillable process state when the event has been queued at the far future. Since the process being released can't be signaled any longer, it remains and waits for the echo-back event in that far future. Back to history, the draining feature was implemented at the time we misinterpreted POSIX definition for blocking file operation. Actually, such a behavior is superfluous at release, and we should just release the device as is instead of keeping it up forever. This patch just removes the draining call that may block the release for too long time unexpectedly. BugLink: http://lkml.kernel.org/r/CACT4Y+Y4kD-aBGj37rf-xBw9bH3GMU6P+MYg4W1e-s-paVD2pg@mail.gmail.com Reported-by: Dmitry Vyukov <dvyukov@google.com> Cc: <stable@vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai@suse.de>
176 lines
4.5 KiB
C
176 lines
4.5 KiB
C
/*
|
|
* OSS compatible sequencer driver
|
|
*
|
|
* Copyright (C) 1998,99 Takashi Iwai <tiwai@suse.de>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
*/
|
|
|
|
#ifndef __SEQ_OSS_DEVICE_H
|
|
#define __SEQ_OSS_DEVICE_H
|
|
|
|
#include <linux/time.h>
|
|
#include <linux/wait.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/sched.h>
|
|
#include <sound/core.h>
|
|
#include <sound/seq_oss.h>
|
|
#include <sound/rawmidi.h>
|
|
#include <sound/seq_kernel.h>
|
|
#include <sound/info.h>
|
|
|
|
/* max. applications */
|
|
#define SNDRV_SEQ_OSS_MAX_CLIENTS 16
|
|
#define SNDRV_SEQ_OSS_MAX_SYNTH_DEVS 16
|
|
#define SNDRV_SEQ_OSS_MAX_MIDI_DEVS 32
|
|
|
|
/* version */
|
|
#define SNDRV_SEQ_OSS_MAJOR_VERSION 0
|
|
#define SNDRV_SEQ_OSS_MINOR_VERSION 1
|
|
#define SNDRV_SEQ_OSS_TINY_VERSION 8
|
|
#define SNDRV_SEQ_OSS_VERSION_STR "0.1.8"
|
|
|
|
/* device and proc interface name */
|
|
#define SNDRV_SEQ_OSS_PROCNAME "oss"
|
|
|
|
|
|
/*
|
|
* type definitions
|
|
*/
|
|
|
|
typedef unsigned int reltime_t;
|
|
typedef unsigned int abstime_t;
|
|
|
|
|
|
/*
|
|
* synthesizer channel information
|
|
*/
|
|
struct seq_oss_chinfo {
|
|
int note, vel;
|
|
};
|
|
|
|
/*
|
|
* synthesizer information
|
|
*/
|
|
struct seq_oss_synthinfo {
|
|
struct snd_seq_oss_arg arg;
|
|
struct seq_oss_chinfo *ch;
|
|
struct seq_oss_synth_sysex *sysex;
|
|
int nr_voices;
|
|
int opened;
|
|
int is_midi;
|
|
int midi_mapped;
|
|
};
|
|
|
|
|
|
/*
|
|
* sequencer client information
|
|
*/
|
|
|
|
struct seq_oss_devinfo {
|
|
|
|
int index; /* application index */
|
|
int cseq; /* sequencer client number */
|
|
int port; /* sequencer port number */
|
|
int queue; /* sequencer queue number */
|
|
|
|
struct snd_seq_addr addr; /* address of this device */
|
|
|
|
int seq_mode; /* sequencer mode */
|
|
int file_mode; /* file access */
|
|
|
|
/* midi device table */
|
|
int max_mididev;
|
|
|
|
/* synth device table */
|
|
int max_synthdev;
|
|
struct seq_oss_synthinfo synths[SNDRV_SEQ_OSS_MAX_SYNTH_DEVS];
|
|
int synth_opened;
|
|
|
|
/* output queue */
|
|
struct seq_oss_writeq *writeq;
|
|
|
|
/* midi input queue */
|
|
struct seq_oss_readq *readq;
|
|
|
|
/* timer */
|
|
struct seq_oss_timer *timer;
|
|
};
|
|
|
|
|
|
/*
|
|
* function prototypes
|
|
*/
|
|
|
|
/* create/delete OSS sequencer client */
|
|
int snd_seq_oss_create_client(void);
|
|
int snd_seq_oss_delete_client(void);
|
|
|
|
/* device file interface */
|
|
int snd_seq_oss_open(struct file *file, int level);
|
|
void snd_seq_oss_release(struct seq_oss_devinfo *dp);
|
|
int snd_seq_oss_ioctl(struct seq_oss_devinfo *dp, unsigned int cmd, unsigned long arg);
|
|
int snd_seq_oss_read(struct seq_oss_devinfo *dev, char __user *buf, int count);
|
|
int snd_seq_oss_write(struct seq_oss_devinfo *dp, const char __user *buf, int count, struct file *opt);
|
|
unsigned int snd_seq_oss_poll(struct seq_oss_devinfo *dp, struct file *file, poll_table * wait);
|
|
|
|
void snd_seq_oss_reset(struct seq_oss_devinfo *dp);
|
|
|
|
/* */
|
|
void snd_seq_oss_process_queue(struct seq_oss_devinfo *dp, abstime_t time);
|
|
|
|
|
|
/* proc interface */
|
|
void snd_seq_oss_system_info_read(struct snd_info_buffer *buf);
|
|
void snd_seq_oss_midi_info_read(struct snd_info_buffer *buf);
|
|
void snd_seq_oss_synth_info_read(struct snd_info_buffer *buf);
|
|
void snd_seq_oss_readq_info_read(struct seq_oss_readq *q, struct snd_info_buffer *buf);
|
|
|
|
/* file mode macros */
|
|
#define is_read_mode(mode) ((mode) & SNDRV_SEQ_OSS_FILE_READ)
|
|
#define is_write_mode(mode) ((mode) & SNDRV_SEQ_OSS_FILE_WRITE)
|
|
#define is_nonblock_mode(mode) ((mode) & SNDRV_SEQ_OSS_FILE_NONBLOCK)
|
|
|
|
/* dispatch event */
|
|
static inline int
|
|
snd_seq_oss_dispatch(struct seq_oss_devinfo *dp, struct snd_seq_event *ev, int atomic, int hop)
|
|
{
|
|
return snd_seq_kernel_client_dispatch(dp->cseq, ev, atomic, hop);
|
|
}
|
|
|
|
/* ioctl */
|
|
static inline int
|
|
snd_seq_oss_control(struct seq_oss_devinfo *dp, unsigned int type, void *arg)
|
|
{
|
|
return snd_seq_kernel_client_ctl(dp->cseq, type, arg);
|
|
}
|
|
|
|
/* fill the addresses in header */
|
|
static inline void
|
|
snd_seq_oss_fill_addr(struct seq_oss_devinfo *dp, struct snd_seq_event *ev,
|
|
int dest_client, int dest_port)
|
|
{
|
|
ev->queue = dp->queue;
|
|
ev->source = dp->addr;
|
|
ev->dest.client = dest_client;
|
|
ev->dest.port = dest_port;
|
|
}
|
|
|
|
|
|
/* misc. functions for proc interface */
|
|
char *enabled_str(int bool);
|
|
|
|
#endif /* __SEQ_OSS_DEVICE_H */
|