Scott Mayhew 268b2cc325 nfs: don't wait on commit in nfs_commit_inode() if there were no commit requests ... commit dc4fd9ab01 upstream. If there were no commit requests, then nfs_commit_inode() should not wait on the commit or mark the inode dirty, otherwise the following BUG_ON can be triggered: [ 1917.130762] kernel BUG at fs/inode.c:578! [ 1917.130766] Oops: Exception in kernel mode, sig: 5 [#1] [ 1917.130768] SMP NR_CPUS=2048 NUMA pSeries [ 1917.130772] Modules linked in: iscsi_tcp libiscsi_tcp libiscsi scsi_transport_iscsi blocklayoutdriver rpcsec_gss_krb5 auth_rpcgss nfsv4 dns_resolver nfs lockd grace fscache sunrpc sg nx_crypto pseries_rng ip_tables xfs libcrc32c sd_mod crc_t10dif crct10dif_generic crct10dif_common ibmvscsi scsi_transport_srp ibmveth scsi_tgt dm_mirror dm_region_hash dm_log dm_mod [ 1917.130805] CPU: 2 PID: 14923 Comm: umount.nfs4 Tainted: G ------------ T 3.10.0-768.el7.ppc64 #1 [ 1917.130810] task: c0000005ecd88040 ti: c00000004cea0000 task.ti: c00000004cea0000 [ 1917.130813] NIP: c000000000354178 LR: c000000000354160 CTR: c00000000012db80 [ 1917.130816] REGS: c00000004cea3720 TRAP: 0700 Tainted: G ------------ T (3.10.0-768.el7.ppc64) [ 1917.130820] MSR: 8000000100029032 <SF,EE,ME,IR,DR,RI> CR: 22002822 XER: 20000000 [ 1917.130828] CFAR: c00000000011f594 SOFTE: 1 GPR00: c000000000354160 c00000004cea39a0 c0000000014c4700 c0000000018cc750 GPR04: 000000000000c750 80c0000000000000 0600000000000000 04eeb76bea749a03 GPR08: 0000000000000034 c0000000018cc758 0000000000000001 d000000005e619e8 GPR12: c00000000012db80 c000000007b31200 0000000000000000 0000000000000000 GPR16: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 GPR20: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 GPR24: 0000000000000000 c000000000dfc3ec 0000000000000000 c0000005eefc02c0 GPR28: d0000000079dbd50 c0000005b94a02c0 c0000005b94a0250 c0000005b94a01c8 [ 1917.130867] NIP [c000000000354178] .evict+0x1c8/0x350 [ 1917.130871] LR [c000000000354160] .evict+0x1b0/0x350 [ 1917.130873] Call Trace: [ 1917.130876] [c00000004cea39a0] [c000000000354160] .evict+0x1b0/0x350 (unreliable) [ 1917.130880] [c00000004cea3a30] [c0000000003558cc] .evict_inodes+0x13c/0x270 [ 1917.130884] [c00000004cea3af0] [c000000000327d20] .kill_anon_super+0x70/0x1e0 [ 1917.130896] [c00000004cea3b80] [d000000005e43e30] .nfs_kill_super+0x20/0x60 [nfs] [ 1917.130900] [c00000004cea3c00] [c000000000328a20] .deactivate_locked_super+0xa0/0x1b0 [ 1917.130903] [c00000004cea3c80] [c00000000035ba54] .cleanup_mnt+0xd4/0x180 [ 1917.130907] [c00000004cea3d10] [c000000000119034] .task_work_run+0x114/0x150 [ 1917.130912] [c00000004cea3db0] [c00000000001ba6c] .do_notify_resume+0xcc/0x100 [ 1917.130916] [c00000004cea3e30] [c00000000000a7b0] .ret_from_except_lite+0x5c/0x60 [ 1917.130919] Instruction dump: [ 1917.130921] 7fc3f378 486734b5 60000000 387f00a0 38800003 4bdcb365 60000000 e95f00a0 [ 1917.130927] 694a0060 7d4a0074 794ad182 694a0001 <0b0a0000> 892d02a4 2f890000 40de0134 Signed-off-by: Scott Mayhew <smayhew@redhat.com> Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2017-12-20 10:10:20 +01:00
..
blocklayout	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
filelayout	nfs/filelayout: fix oops when freeing filelayout segment	2017-10-01 18:51:30 -04:00
flexfilelayout	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
Kconfig	pnfs/blocklayout: require 64-bit sector_t	2017-08-11 14:10:13 -04:00
Makefile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
cache_lib.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
cache_lib.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
callback.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
callback.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
callback_proc.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
callback_xdr.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
client.c	NFS: Fix uninitialized rpc_wait_queue	2017-10-01 18:51:30 -04:00
delegation.c	NFS: Use an atomic_long_t to count the number of requests	2017-08-15 11:54:47 -04:00
delegation.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
dir.c	NFS: Fix a typo in nfs_rename()	2017-12-14 09:53:08 +01:00
direct.c	NFSv4: Use a mutex to protect the per-inode commit lists	2017-08-15 11:54:47 -04:00
dns_resolve.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
dns_resolve.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
export.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
file.c	NFS: Revert "NFS: Move the flock open mode check into nfs_flock()"	2017-11-30 08:40:46 +00:00
fscache-index.c	fscache: remove unused ->now_uncached callback	2017-09-06 17:27:26 -07:00
fscache.c	nfs: define nfs_inc_fscache_stats and using it as possible	2014-11-24 20:08:47 -05:00
fscache.h	NFS: Use i_writecount to control whether to get an fscache cookie in nfs_open()	2013-09-27 18:40:25 +01:00
getroot.c	Replace <asm/uaccess.h> with <linux/uaccess.h> globally	2016-12-24 11:46:01 -08:00
inode.c	NFS: Use an atomic_long_t to count the number of commits	2017-08-15 11:54:48 -04:00
internal.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
io.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
iostat.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
mount_clnt.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
namespace.c	NFS: Use ERR_CAST() to avoid cross-structure cast	2017-05-28 10:11:47 -07:00
netns.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
nfs.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
nfs2super.c	NFS: Convert v2 into a module	2012-07-30 19:06:41 -04:00
nfs2xdr.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
nfs3_fs.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
nfs3acl.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
nfs3client.c	NFS: Remove unused authflavour parameter from nfs_get_client()	2016-12-01 17:46:32 -05:00
nfs3proc.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
nfs3super.c	nfsv3: introduce nfs3_set_ds_client	2015-02-03 11:06:34 -08:00
nfs3xdr.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
nfs4_fs.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
nfs4client.c	NFSv4: Fix double frees in nfs4_test_session_trunk()	2017-08-02 09:45:55 -04:00
nfs4file.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
nfs4getroot.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
nfs4idmap.c	NFS: Cleanup error handling in nfs_idmap_request_key()	2017-10-01 18:51:30 -04:00
nfs4idmap.h	NFS: Move nfs_idmap.h into fs/nfs/	2015-04-23 15:16:14 -04:00
nfs4namespace.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
nfs4proc.c	nfs: Fix ugly referral attributes	2017-11-30 08:40:46 +00:00
nfs4renewd.c	NFSv4: Set the connection timeout to match the lease period	2017-02-09 14:15:16 -05:00
nfs4session.c	NFSv4.1: Fix regression in callback retry handling	2016-12-01 17:21:38 -05:00
nfs4session.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
nfs4state.c	NFS client updates for Linux 4.13	2017-07-13 14:35:37 -07:00
nfs4super.c	NFS: Move nfs_idmap.h into fs/nfs/	2015-04-23 15:16:14 -04:00
nfs4sysctl.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
nfs4trace.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
nfs4trace.h	NFS: Avoid RCU usage in tracepoints	2017-11-30 08:40:46 +00:00
nfs4xdr.c	nfs: RPC_MAX_AUTH_SIZE is in bytes	2017-10-01 18:51:30 -04:00
nfs42.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
nfs42proc.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
nfs42xdr.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
nfsroot.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
nfstrace.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
nfstrace.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
pagelist.c	NFS: various changes relating to reporting IO errors.	2017-09-11 22:28:56 -04:00
pnfs.c	pNFS: Use the standard I/O stateid when calling LAYOUTGET	2017-09-11 22:19:00 -04:00
pnfs.h	NFSv4/pnfs: Replace pnfs_put_lseg_locked() with pnfs_put_lseg()	2017-08-15 11:54:48 -04:00
pnfs_dev.c	NFSv4.1: Don't cache deviceids that have no notifications	2015-03-27 12:32:24 -04:00
pnfs_nfs.c	NFS: Remove pnfs_generic_transfer_commit_list()	2017-09-09 12:51:40 -04:00
proc.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
read.c	NFS: Add static NFS I/O tracepoints	2017-09-11 22:20:38 -04:00
super.c	NFS: Fix typo in nomigration mount option	2017-11-30 08:40:45 +00:00
symlink.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
sysctl.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
unlink.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
write.c	nfs: don't wait on commit in nfs_commit_inode() if there were no commit requests	2017-12-20 10:10:20 +01:00