Takashi Iwai b171162cbd ALSA: seq: Fix UBSAN warning at SNDRV_SEQ_IOCTL_QUERY_NEXT_CLIENT ioctl ... [ Upstream commit c9a4c63888 ] The kernel may spew a WARNING with UBSAN undefined behavior at handling ALSA sequencer ioctl SNDRV_SEQ_IOCTL_QUERY_NEXT_CLIENT: UBSAN: Undefined behaviour in sound/core/seq/seq_clientmgr.c:2007:14 signed integer overflow: 2147483647 + 1 cannot be represented in type 'int' Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x122/0x1c8 lib/dump_stack.c:113 ubsan_epilogue+0x12/0x86 lib/ubsan.c:159 handle_overflow+0x1c2/0x21f lib/ubsan.c:190 __ubsan_handle_add_overflow+0x2a/0x31 lib/ubsan.c:198 snd_seq_ioctl_query_next_client+0x1ac/0x1d0 sound/core/seq/seq_clientmgr.c:2007 snd_seq_ioctl+0x264/0x3d0 sound/core/seq/seq_clientmgr.c:2144 .... It happens only when INT_MAX is passed there, as we're incrementing it unconditionally. So the fix is trivial, check the value with INT_MAX. Although the bug itself is fairly harmless, it's better to fix it so that fuzzers won't hit this again later. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=200211 Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2018-08-24 13:09:05 +02:00
..
oss	ALSA: seq: oss: Hardening for potential Spectre v1	2018-05-01 12:58:17 -07:00
Kconfig
Makefile
seq.c
seq_clientmgr.c	ALSA: seq: Fix UBSAN warning at SNDRV_SEQ_IOCTL_QUERY_NEXT_CLIENT ioctl	2018-08-24 13:09:05 +02:00
seq_clientmgr.h
seq_compat.c
seq_dummy.c
seq_fifo.c	ALSA: seq: More protection for concurrent write and ioctl races	2018-03-15 10:54:34 +01:00
seq_fifo.h
seq_info.c
seq_info.h
seq_lock.c
seq_lock.h
seq_memory.c	ALSA: seq: More protection for concurrent write and ioctl races	2018-03-15 10:54:34 +01:00
seq_memory.h	ALSA: seq: More protection for concurrent write and ioctl races	2018-03-15 10:54:34 +01:00
seq_midi.c
seq_midi_emul.c
seq_midi_event.c
seq_ports.c
seq_ports.h
seq_prioq.c	ALSA: seq: Fix possible UAF in snd_seq_check_queue()	2018-03-21 12:06:42 +01:00
seq_prioq.h	ALSA: seq: Fix possible UAF in snd_seq_check_queue()	2018-03-21 12:06:42 +01:00
seq_queue.c	ALSA: seq: Fix possible UAF in snd_seq_check_queue()	2018-03-21 12:06:42 +01:00
seq_queue.h
seq_system.c
seq_system.h
seq_timer.c
seq_timer.h
seq_virmidi.c	ALSA: virmidi: Fix too long output trigger loop	2018-08-22 07:46:09 +02:00