remarkable-linux/drivers/bcma
Hauke Mehrtens 9dbf5f55f8 bcma: add missing iounmap on error path
This should fix the problem reported by Fengguang:

The coccinelle static checker emits these warnings:

drivers/bcma/scan.c:466:3-9: ERROR: missing iounmap; ioremap on line 451 and execution via conditional on line 465
drivers/bcma/scan.c:540:3-9: ERROR: missing iounmap; ioremap on line 515 and execution via conditional on line 539

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2012-07-26 15:37:57 -04:00
..
bcma_private.h bcma: add place for flash memory support 2012-07-17 15:11:40 -04:00
core.c bcma: use custom printing functions 2012-07-09 16:36:36 -04:00
driver_chipcommon.c bcma: fix CC driver compilation on MIPS 2012-07-11 15:40:21 -04:00
driver_chipcommon_nflash.c bcma: add place for flash memory support 2012-07-17 15:11:40 -04:00
driver_chipcommon_pmu.c bcma: add PMU clock support for BCM4706 2012-07-11 15:40:22 -04:00
driver_chipcommon_sflash.c bcma: add place for flash memory support 2012-07-17 15:11:40 -04:00
driver_gmac_cmn.c bcma: add trivial GBIT MAC COMMON driver 2012-07-12 15:27:18 -04:00
driver_mips.c bcma: fix regression in interrupt assignment on mips 2012-07-26 15:37:57 -04:00
driver_pci.c bcma: fix null pointer in bcma_core_pci_irq_ctl 2012-06-08 13:47:07 -04:00
driver_pci_host.c bcma: use custom printing functions 2012-07-09 16:36:36 -04:00
host_pci.c bcma: use custom printing functions 2012-07-09 16:36:36 -04:00
host_soc.c bcma: add SOC bus 2011-08-08 14:29:25 -04:00
Kconfig bcma: add place for flash memory support 2012-07-17 15:11:40 -04:00
main.c bcma: add trivial GBIT MAC COMMON driver 2012-07-12 15:27:18 -04:00
Makefile bcma: add place for flash memory support 2012-07-17 15:11:40 -04:00
README
scan.c bcma: add missing iounmap on error path 2012-07-26 15:37:57 -04:00
scan.h bcma: fix typo - reading number of slave wrappers 2012-07-12 15:27:17 -04:00
sprom.c bcma: use custom printing functions 2012-07-09 16:36:36 -04:00
TODO

Broadcom introduced new bus as replacement for older SSB. It is based on AMBA,
however from programming point of view there is nothing AMBA specific we use.

Standard AMBA drivers are platform specific, have hardcoded addresses and use
AMBA standard fields like CID and PID.

In case of Broadcom's cards every device consists of:
1) Broadcom specific AMBA device. It is put on AMBA bus, but can not be treated
   as standard AMBA device. Reading it's CID or PID can cause machine lockup.
2) AMBA standard devices called ports or wrappers. They have CIDs (AMBA_CID)
   and PIDs (0x103BB369), but we do not use that info for anything. One of that
   devices is used for managing Broadcom specific core.

Addresses of AMBA devices are not hardcoded in driver and have to be read from
EPROM.

In this situation we decided to introduce separated bus. It can contain up to
16 devices identified by Broadcom specific fields: manufacturer, id, revision
and class.