remarkable-linux/drivers/usb/misc
Clemens Ladisch ac06c06770 USB: emi62: fix crash when trying to load EMI 6|2 firmware
While converting emi62 to use request_firmware(), the driver was also
changed to use the ihex helper functions.  However, this broke the loading
of the FPGA firmware because the code tries to access the addr field of
the EOF record which works with a plain array that has an empty last
record but not with the ihex helper functions where the end of the data is
signaled with a NULL record pointer, resulting in:

BUG: unable to handle kernel NULL pointer dereference at (null)
IP: [<f80d248c>] emi62_load_firmware+0x33c/0x740 [emi62]

This can be fixed by changing the loop condition to test the return value
of ihex_next_binrec() directly (like in emi26.c).

Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
Reported-and-tested-by: Der Mickster <retroeffective@gmail.com>
Acked-by: David Woodhouse <David.Woodhouse@intel.com>
Cc: stable <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-12-23 11:34:11 -08:00
..
sisusbvga headers: kref.h redux 2009-09-26 10:17:19 -07:00
adutux.c
appledisplay.c
berry_charge.c
cypress_cy7c63.c
cytherm.c
emi26.c
emi62.c USB: emi62: fix crash when trying to load EMI 6|2 firmware 2009-12-23 11:34:11 -08:00
ftdi-elan.c
idmouse.c USB: full power management support for the idmouse driver 2009-09-23 06:46:28 -07:00
iowarrior.c Driver-Core: extend devnode callbacks to provide permissions 2009-09-19 12:50:38 -07:00
isight_firmware.c
Kconfig
ldusb.c USB: ldusb should signal an error in poll if the device is disconnected 2009-09-23 06:46:28 -07:00
legousbtower.c USB: legousbtower: make poll notice disconnect 2009-09-23 06:46:28 -07:00
Makefile
rio500.c const: constify remaining file_operations 2009-10-01 16:11:11 -07:00
rio500_usb.h
trancevibrator.c
usb_u132.h
usblcd.c USB: usblcd, fix memory leak 2009-10-09 13:52:06 -07:00
usbled.c
usbsevseg.c USB: full autosuspend and power management support for usbsevseg 2009-09-23 06:46:28 -07:00
usbtest.c usbtest: make module param pattern writeable 2009-12-11 11:55:22 -08:00
uss720.c
vstusb.c