![Tejun Heo](/assets/img/avatar_default.png)
alpha percpu access requires custom SHIFT_PERCPU_PTR() definition for modules to work around addressing range limitation. This is done via generating inline assembly using C preprocessing which forces the assembler to generate external reference. This happens behind the compiler's back and makes the compiler think that static percpu variables in modules are unused. This used to be worked around by using __unused attribute for percpu variables which prevent the compiler from omitting the variable; however, recent declare/definition attribute unification change broke this as __used can't be used for declaration. Also, in the process, PER_CPU_ATTRIBUTES definition in alpha percpu.h got broken. This patch adds PER_CPU_DEF_ATTRIBUTES which is only used for definitions and make alpha use it to add __used for percpu variables in modules. This also fixes the PER_CPU_ATTRIBUTES double definition bug. Signed-off-by: Tejun Heo <tj@kernel.org> Tested-by: maximilian attems <max@stro.at> Acked-by: Ivan Kokshaysky <ink@jurassic.park.msu.ru> Cc: Richard Henderson <rth@twiddle.net> Cc: <stable@kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
86 lines
2.9 KiB
C
86 lines
2.9 KiB
C
#ifndef _LINUX_PERCPU_DEFS_H
|
|
#define _LINUX_PERCPU_DEFS_H
|
|
|
|
/*
|
|
* Determine the real variable name from the name visible in the
|
|
* kernel sources.
|
|
*/
|
|
#define per_cpu_var(var) per_cpu__##var
|
|
|
|
/*
|
|
* Base implementations of per-CPU variable declarations and definitions, where
|
|
* the section in which the variable is to be placed is provided by the
|
|
* 'section' argument. This may be used to affect the parameters governing the
|
|
* variable's storage.
|
|
*
|
|
* NOTE! The sections for the DECLARE and for the DEFINE must match, lest
|
|
* linkage errors occur due the compiler generating the wrong code to access
|
|
* that section.
|
|
*/
|
|
#define DECLARE_PER_CPU_SECTION(type, name, section) \
|
|
extern \
|
|
__attribute__((__section__(PER_CPU_BASE_SECTION section))) \
|
|
PER_CPU_ATTRIBUTES __typeof__(type) per_cpu__##name
|
|
|
|
#define DEFINE_PER_CPU_SECTION(type, name, section) \
|
|
__attribute__((__section__(PER_CPU_BASE_SECTION section))) \
|
|
PER_CPU_ATTRIBUTES PER_CPU_DEF_ATTRIBUTES \
|
|
__typeof__(type) per_cpu__##name
|
|
|
|
/*
|
|
* Variant on the per-CPU variable declaration/definition theme used for
|
|
* ordinary per-CPU variables.
|
|
*/
|
|
#define DECLARE_PER_CPU(type, name) \
|
|
DECLARE_PER_CPU_SECTION(type, name, "")
|
|
|
|
#define DEFINE_PER_CPU(type, name) \
|
|
DEFINE_PER_CPU_SECTION(type, name, "")
|
|
|
|
/*
|
|
* Declaration/definition used for per-CPU variables that must come first in
|
|
* the set of variables.
|
|
*/
|
|
#define DECLARE_PER_CPU_FIRST(type, name) \
|
|
DECLARE_PER_CPU_SECTION(type, name, PER_CPU_FIRST_SECTION)
|
|
|
|
#define DEFINE_PER_CPU_FIRST(type, name) \
|
|
DEFINE_PER_CPU_SECTION(type, name, PER_CPU_FIRST_SECTION)
|
|
|
|
/*
|
|
* Declaration/definition used for per-CPU variables that must be cacheline
|
|
* aligned under SMP conditions so that, whilst a particular instance of the
|
|
* data corresponds to a particular CPU, inefficiencies due to direct access by
|
|
* other CPUs are reduced by preventing the data from unnecessarily spanning
|
|
* cachelines.
|
|
*
|
|
* An example of this would be statistical data, where each CPU's set of data
|
|
* is updated by that CPU alone, but the data from across all CPUs is collated
|
|
* by a CPU processing a read from a proc file.
|
|
*/
|
|
#define DECLARE_PER_CPU_SHARED_ALIGNED(type, name) \
|
|
DECLARE_PER_CPU_SECTION(type, name, PER_CPU_SHARED_ALIGNED_SECTION) \
|
|
____cacheline_aligned_in_smp
|
|
|
|
#define DEFINE_PER_CPU_SHARED_ALIGNED(type, name) \
|
|
DEFINE_PER_CPU_SECTION(type, name, PER_CPU_SHARED_ALIGNED_SECTION) \
|
|
____cacheline_aligned_in_smp
|
|
|
|
/*
|
|
* Declaration/definition used for per-CPU variables that must be page aligned.
|
|
*/
|
|
#define DECLARE_PER_CPU_PAGE_ALIGNED(type, name) \
|
|
DECLARE_PER_CPU_SECTION(type, name, ".page_aligned")
|
|
|
|
#define DEFINE_PER_CPU_PAGE_ALIGNED(type, name) \
|
|
DEFINE_PER_CPU_SECTION(type, name, ".page_aligned")
|
|
|
|
/*
|
|
* Intermodule exports for per-CPU variables.
|
|
*/
|
|
#define EXPORT_PER_CPU_SYMBOL(var) EXPORT_SYMBOL(per_cpu__##var)
|
|
#define EXPORT_PER_CPU_SYMBOL_GPL(var) EXPORT_SYMBOL_GPL(per_cpu__##var)
|
|
|
|
|
|
#endif /* _LINUX_PERCPU_DEFS_H */
|