3b0fde0fac
Addresses http://bugzilla.kernel.org/show_bug.cgi?id=13484 Peer reported: | The bug is introduced from kernel 2.6.27, if E820 table reserve the memory | above 4G in 32bit OS(BIOS-e820: 00000000fff80000 - 0000000120000000 | (reserved)), system will report Int 6 error and hang up. The bug is caused by | the following code in drivers/firmware/memmap.c, the resource_size_t is 32bit | variable in 32bit OS, the BUG_ON() will be invoked to result in the Int 6 | error. I try the latest 32bit Ubuntu and Fedora distributions, all hit this | bug. |====== |static int firmware_map_add_entry(resource_size_t start, resource_size_t end, | const char *type, | struct firmware_map_entry *entry) and it only happen with CONFIG_PHYS_ADDR_T_64BIT is not set. it turns out we need to pass u64 instead of resource_size_t for that. [akpm@linux-foundation.org: add comment] Reported-and-tested-by: Peer Chen <pchen@nvidia.com> Signed-off-by: Yinghai Lu <yinghai@kernel.org> Cc: Ingo Molnar <mingo@elte.hu> Acked-by: H. Peter Anvin <hpa@zytor.com> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: <stable@kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
45 lines
1.2 KiB
C
45 lines
1.2 KiB
C
/*
|
|
* include/linux/firmware-map.h:
|
|
* Copyright (C) 2008 SUSE LINUX Products GmbH
|
|
* by Bernhard Walle <bernhard.walle@gmx.de>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License v2.0 as published by
|
|
* the Free Software Foundation
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
*/
|
|
#ifndef _LINUX_FIRMWARE_MAP_H
|
|
#define _LINUX_FIRMWARE_MAP_H
|
|
|
|
#include <linux/list.h>
|
|
#include <linux/kobject.h>
|
|
|
|
/*
|
|
* provide a dummy interface if CONFIG_FIRMWARE_MEMMAP is disabled
|
|
*/
|
|
#ifdef CONFIG_FIRMWARE_MEMMAP
|
|
|
|
int firmware_map_add(u64 start, u64 end, const char *type);
|
|
int firmware_map_add_early(u64 start, u64 end, const char *type);
|
|
|
|
#else /* CONFIG_FIRMWARE_MEMMAP */
|
|
|
|
static inline int firmware_map_add(u64 start, u64 end, const char *type)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline int firmware_map_add_early(u64 start, u64 end, const char *type)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
#endif /* CONFIG_FIRMWARE_MEMMAP */
|
|
|
|
#endif /* _LINUX_FIRMWARE_MAP_H */
|