9c0729dc80
The various stack tracing routines take a 'bp' argument in which the caller is supposed to provide the base pointer to use, or 0 if doesn't have one. Since bp is garbage whenever CONFIG_FRAME_POINTER is not defined, this means all callers in principle should either always pass 0, or be conditional on CONFIG_FRAME_POINTER. However, there are only really three use cases for stack tracing: (a) Trace the current task, including IRQ stack if any (b) Trace the current task, but skip IRQ stack (c) Trace some other task In all cases, if CONFIG_FRAME_POINTER is not defined, bp should just be 0. If it _is_ defined, then - in case (a) bp should be gotten directly from the CPU's register, so the caller should pass NULL for regs, - in case (b) the caller should should pass the IRQ registers to dump_trace(), - in case (c) bp should be gotten from the top of the task's stack, so the caller should pass NULL for regs. Hence, the bp argument is not necessary because the combination of task and regs is sufficient to determine an appropriate value for bp. This patch introduces a new inline function stack_frame(task, regs) that computes the desired bp. This function is then called from the two versions of dump_stack(). Signed-off-by: Soren Sandmann <ssp@redhat.com> Acked-by: Steven Rostedt <rostedt@goodmis.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Ingo Molnar <mingo@redhat.com> Cc: H. Peter Anvin <hpa@zytor.com> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Arjan van de Ven <arjan@infradead.org>, Cc: Frederic Weisbecker <fweisbec@gmail.com>, Cc: Arnaldo Carvalho de Melo <acme@redhat.com>, LKML-Reference: <m3oc9rop28.fsf@dhcp-100-3-82.bos.redhat.com>> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
38 lines
1 KiB
C
38 lines
1 KiB
C
#ifndef __LINUX_STACKTRACE_H
|
|
#define __LINUX_STACKTRACE_H
|
|
|
|
struct task_struct;
|
|
struct pt_regs;
|
|
|
|
#ifdef CONFIG_STACKTRACE
|
|
struct task_struct;
|
|
|
|
struct stack_trace {
|
|
unsigned int nr_entries, max_entries;
|
|
unsigned long *entries;
|
|
int skip; /* input argument: How many entries to skip */
|
|
};
|
|
|
|
extern void save_stack_trace(struct stack_trace *trace);
|
|
extern void save_stack_trace_regs(struct stack_trace *trace,
|
|
struct pt_regs *regs);
|
|
extern void save_stack_trace_tsk(struct task_struct *tsk,
|
|
struct stack_trace *trace);
|
|
|
|
extern void print_stack_trace(struct stack_trace *trace, int spaces);
|
|
|
|
#ifdef CONFIG_USER_STACKTRACE_SUPPORT
|
|
extern void save_stack_trace_user(struct stack_trace *trace);
|
|
#else
|
|
# define save_stack_trace_user(trace) do { } while (0)
|
|
#endif
|
|
|
|
#else
|
|
# define save_stack_trace(trace) do { } while (0)
|
|
# define save_stack_trace_tsk(tsk, trace) do { } while (0)
|
|
# define save_stack_trace_user(trace) do { } while (0)
|
|
# define print_stack_trace(trace, spaces) do { } while (0)
|
|
#endif
|
|
|
|
#endif
|