![Tejun Heo](/assets/img/avatar_default.png)
percpu.h is included by sched.h and module.h and thus ends up being included when building most .c files. percpu.h includes slab.h which in turn includes gfp.h making everything defined by the two files universally available and complicating inclusion dependencies. percpu.h -> slab.h dependency is about to be removed. Prepare for this change by updating users of gfp and slab facilities include those headers directly instead of assuming availability. As this conversion needs to touch large number of source files, the following script is used as the basis of conversion. http://userweb.kernel.org/~tj/misc/slabh-sweep.py The script does the followings. * Scan files for gfp and slab usages and update includes such that only the necessary includes are there. ie. if only gfp is used, gfp.h, if slab is used, slab.h. * When the script inserts a new include, it looks at the include blocks and try to put the new include such that its order conforms to its surrounding. It's put in the include block which contains core kernel includes, in the same order that the rest are ordered - alphabetical, Christmas tree, rev-Xmas-tree or at the end if there doesn't seem to be any matching order. * If the script can't find a place to put a new include (mostly because the file doesn't have fitting include block), it prints out an error message indicating which .h file needs to be added to the file. The conversion was done in the following steps. 1. The initial automatic conversion of all .c files updated slightly over 4000 files, deleting around 700 includes and adding ~480 gfp.h and ~3000 slab.h inclusions. The script emitted errors for ~400 files. 2. Each error was manually checked. Some didn't need the inclusion, some needed manual addition while adding it to implementation .h or embedding .c file was more appropriate for others. This step added inclusions to around 150 files. 3. The script was run again and the output was compared to the edits from #2 to make sure no file was left behind. 4. Several build tests were done and a couple of problems were fixed. e.g. lib/decompress_*.c used malloc/free() wrappers around slab APIs requiring slab.h to be added manually. 5. The script was run on all .h files but without automatically editing them as sprinkling gfp.h and slab.h inclusions around .h files could easily lead to inclusion dependency hell. Most gfp.h inclusion directives were ignored as stuff from gfp.h was usually wildly available and often used in preprocessor macros. Each slab.h inclusion directive was examined and added manually as necessary. 6. percpu.h was updated not to include slab.h. 7. Build test were done on the following configurations and failures were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my distributed build env didn't work with gcov compiles) and a few more options had to be turned off depending on archs to make things build (like ipr on powerpc/64 which failed due to missing writeq). * x86 and x86_64 UP and SMP allmodconfig and a custom test config. * powerpc and powerpc64 SMP allmodconfig * sparc and sparc64 SMP allmodconfig * ia64 SMP allmodconfig * s390 SMP allmodconfig * alpha SMP allmodconfig * um on x86_64 SMP allmodconfig 8. percpu.h modifications were reverted so that it could be applied as a separate patch and serve as bisection point. Given the fact that I had only a couple of failures from tests on step 6, I'm fairly confident about the coverage of this conversion patch. If there is a breakage, it's likely to be something in one of the arch headers which should be easily discoverable easily on most builds of the specific arch. Signed-off-by: Tejun Heo <tj@kernel.org> Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org> Cc: Ingo Molnar <mingo@redhat.com> Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
429 lines
9.3 KiB
C
429 lines
9.3 KiB
C
/*
|
|
* Real Time Clock driver for Freescale MC13783 PMIC
|
|
*
|
|
* (C) 2009 Sascha Hauer, Pengutronix
|
|
* (C) 2009 Uwe Kleine-Koenig, Pengutronix
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 2 as
|
|
* published by the Free Software Foundation.
|
|
*/
|
|
|
|
#include <linux/mfd/mc13783.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/rtc.h>
|
|
|
|
#define DRIVER_NAME "mc13783-rtc"
|
|
|
|
#define MC13783_RTCTOD 20
|
|
#define MC13783_RTCTODA 21
|
|
#define MC13783_RTCDAY 22
|
|
#define MC13783_RTCDAYA 23
|
|
|
|
struct mc13783_rtc {
|
|
struct rtc_device *rtc;
|
|
struct mc13783 *mc13783;
|
|
int valid;
|
|
};
|
|
|
|
static int mc13783_rtc_irq_enable_unlocked(struct device *dev,
|
|
unsigned int enabled, int irq)
|
|
{
|
|
struct mc13783_rtc *priv = dev_get_drvdata(dev);
|
|
int (*func)(struct mc13783 *mc13783, int irq);
|
|
|
|
if (!priv->valid)
|
|
return -ENODATA;
|
|
|
|
func = enabled ? mc13783_irq_unmask : mc13783_irq_mask;
|
|
return func(priv->mc13783, irq);
|
|
}
|
|
|
|
static int mc13783_rtc_irq_enable(struct device *dev,
|
|
unsigned int enabled, int irq)
|
|
{
|
|
struct mc13783_rtc *priv = dev_get_drvdata(dev);
|
|
int ret;
|
|
|
|
mc13783_lock(priv->mc13783);
|
|
|
|
ret = mc13783_rtc_irq_enable_unlocked(dev, enabled, irq);
|
|
|
|
mc13783_unlock(priv->mc13783);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int mc13783_rtc_read_time(struct device *dev, struct rtc_time *tm)
|
|
{
|
|
struct mc13783_rtc *priv = dev_get_drvdata(dev);
|
|
unsigned int seconds, days1, days2;
|
|
unsigned long s1970;
|
|
int ret;
|
|
|
|
mc13783_lock(priv->mc13783);
|
|
|
|
if (!priv->valid) {
|
|
ret = -ENODATA;
|
|
goto out;
|
|
}
|
|
|
|
ret = mc13783_reg_read(priv->mc13783, MC13783_RTCDAY, &days1);
|
|
if (unlikely(ret))
|
|
goto out;
|
|
|
|
ret = mc13783_reg_read(priv->mc13783, MC13783_RTCTOD, &seconds);
|
|
if (unlikely(ret))
|
|
goto out;
|
|
|
|
ret = mc13783_reg_read(priv->mc13783, MC13783_RTCDAY, &days2);
|
|
out:
|
|
mc13783_unlock(priv->mc13783);
|
|
|
|
if (ret)
|
|
return ret;
|
|
|
|
if (days2 == days1 + 1) {
|
|
if (seconds >= 86400 / 2)
|
|
days2 = days1;
|
|
else
|
|
days1 = days2;
|
|
}
|
|
|
|
if (days1 != days2)
|
|
return -EIO;
|
|
|
|
s1970 = days1 * 86400 + seconds;
|
|
|
|
rtc_time_to_tm(s1970, tm);
|
|
|
|
return rtc_valid_tm(tm);
|
|
}
|
|
|
|
static int mc13783_rtc_set_mmss(struct device *dev, unsigned long secs)
|
|
{
|
|
struct mc13783_rtc *priv = dev_get_drvdata(dev);
|
|
unsigned int seconds, days;
|
|
unsigned int alarmseconds;
|
|
int ret;
|
|
|
|
seconds = secs % 86400;
|
|
days = secs / 86400;
|
|
|
|
mc13783_lock(priv->mc13783);
|
|
|
|
/*
|
|
* temporarily invalidate alarm to prevent triggering it when the day is
|
|
* already updated while the time isn't yet.
|
|
*/
|
|
ret = mc13783_reg_read(priv->mc13783, MC13783_RTCTODA, &alarmseconds);
|
|
if (unlikely(ret))
|
|
goto out;
|
|
|
|
if (alarmseconds < 86400) {
|
|
ret = mc13783_reg_write(priv->mc13783,
|
|
MC13783_RTCTODA, 0x1ffff);
|
|
if (unlikely(ret))
|
|
goto out;
|
|
}
|
|
|
|
/*
|
|
* write seconds=0 to prevent a day switch between writing days
|
|
* and seconds below
|
|
*/
|
|
ret = mc13783_reg_write(priv->mc13783, MC13783_RTCTOD, 0);
|
|
if (unlikely(ret))
|
|
goto out;
|
|
|
|
ret = mc13783_reg_write(priv->mc13783, MC13783_RTCDAY, days);
|
|
if (unlikely(ret))
|
|
goto out;
|
|
|
|
ret = mc13783_reg_write(priv->mc13783, MC13783_RTCTOD, seconds);
|
|
if (unlikely(ret))
|
|
goto out;
|
|
|
|
/* restore alarm */
|
|
if (alarmseconds < 86400) {
|
|
ret = mc13783_reg_write(priv->mc13783,
|
|
MC13783_RTCTODA, alarmseconds);
|
|
if (unlikely(ret))
|
|
goto out;
|
|
}
|
|
|
|
ret = mc13783_irq_ack(priv->mc13783, MC13783_IRQ_RTCRST);
|
|
if (unlikely(ret))
|
|
goto out;
|
|
|
|
ret = mc13783_irq_unmask(priv->mc13783, MC13783_IRQ_RTCRST);
|
|
out:
|
|
priv->valid = !ret;
|
|
|
|
mc13783_unlock(priv->mc13783);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int mc13783_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alarm)
|
|
{
|
|
struct mc13783_rtc *priv = dev_get_drvdata(dev);
|
|
unsigned seconds, days;
|
|
unsigned long s1970;
|
|
int enabled, pending;
|
|
int ret;
|
|
|
|
mc13783_lock(priv->mc13783);
|
|
|
|
ret = mc13783_reg_read(priv->mc13783, MC13783_RTCTODA, &seconds);
|
|
if (unlikely(ret))
|
|
goto out;
|
|
if (seconds >= 86400) {
|
|
ret = -ENODATA;
|
|
goto out;
|
|
}
|
|
|
|
ret = mc13783_reg_read(priv->mc13783, MC13783_RTCDAY, &days);
|
|
if (unlikely(ret))
|
|
goto out;
|
|
|
|
ret = mc13783_irq_status(priv->mc13783, MC13783_IRQ_TODA,
|
|
&enabled, &pending);
|
|
|
|
out:
|
|
mc13783_unlock(priv->mc13783);
|
|
|
|
if (ret)
|
|
return ret;
|
|
|
|
alarm->enabled = enabled;
|
|
alarm->pending = pending;
|
|
|
|
s1970 = days * 86400 + seconds;
|
|
|
|
rtc_time_to_tm(s1970, &alarm->time);
|
|
dev_dbg(dev, "%s: %lu\n", __func__, s1970);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int mc13783_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alarm)
|
|
{
|
|
struct mc13783_rtc *priv = dev_get_drvdata(dev);
|
|
unsigned long s1970;
|
|
unsigned seconds, days;
|
|
int ret;
|
|
|
|
mc13783_lock(priv->mc13783);
|
|
|
|
/* disable alarm to prevent false triggering */
|
|
ret = mc13783_reg_write(priv->mc13783, MC13783_RTCTODA, 0x1ffff);
|
|
if (unlikely(ret))
|
|
goto out;
|
|
|
|
ret = mc13783_irq_ack(priv->mc13783, MC13783_IRQ_TODA);
|
|
if (unlikely(ret))
|
|
goto out;
|
|
|
|
ret = rtc_tm_to_time(&alarm->time, &s1970);
|
|
if (unlikely(ret))
|
|
goto out;
|
|
|
|
dev_dbg(dev, "%s: o%2.s %lu\n", __func__, alarm->enabled ? "n" : "ff",
|
|
s1970);
|
|
|
|
ret = mc13783_rtc_irq_enable_unlocked(dev, alarm->enabled,
|
|
MC13783_IRQ_TODA);
|
|
if (unlikely(ret))
|
|
goto out;
|
|
|
|
seconds = s1970 % 86400;
|
|
days = s1970 / 86400;
|
|
|
|
ret = mc13783_reg_write(priv->mc13783, MC13783_RTCDAYA, days);
|
|
if (unlikely(ret))
|
|
goto out;
|
|
|
|
ret = mc13783_reg_write(priv->mc13783, MC13783_RTCTODA, seconds);
|
|
|
|
out:
|
|
mc13783_unlock(priv->mc13783);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static irqreturn_t mc13783_rtc_alarm_handler(int irq, void *dev)
|
|
{
|
|
struct mc13783_rtc *priv = dev;
|
|
struct mc13783 *mc13783 = priv->mc13783;
|
|
|
|
dev_dbg(&priv->rtc->dev, "Alarm\n");
|
|
|
|
rtc_update_irq(priv->rtc, 1, RTC_IRQF | RTC_AF);
|
|
|
|
mc13783_irq_ack(mc13783, irq);
|
|
|
|
return IRQ_HANDLED;
|
|
}
|
|
|
|
static irqreturn_t mc13783_rtc_update_handler(int irq, void *dev)
|
|
{
|
|
struct mc13783_rtc *priv = dev;
|
|
struct mc13783 *mc13783 = priv->mc13783;
|
|
|
|
dev_dbg(&priv->rtc->dev, "1HZ\n");
|
|
|
|
rtc_update_irq(priv->rtc, 1, RTC_IRQF | RTC_UF);
|
|
|
|
mc13783_irq_ack(mc13783, irq);
|
|
|
|
return IRQ_HANDLED;
|
|
}
|
|
|
|
static int mc13783_rtc_update_irq_enable(struct device *dev,
|
|
unsigned int enabled)
|
|
{
|
|
return mc13783_rtc_irq_enable(dev, enabled, MC13783_IRQ_1HZ);
|
|
}
|
|
|
|
static int mc13783_rtc_alarm_irq_enable(struct device *dev,
|
|
unsigned int enabled)
|
|
{
|
|
return mc13783_rtc_irq_enable(dev, enabled, MC13783_IRQ_TODA);
|
|
}
|
|
|
|
static const struct rtc_class_ops mc13783_rtc_ops = {
|
|
.read_time = mc13783_rtc_read_time,
|
|
.set_mmss = mc13783_rtc_set_mmss,
|
|
.read_alarm = mc13783_rtc_read_alarm,
|
|
.set_alarm = mc13783_rtc_set_alarm,
|
|
.alarm_irq_enable = mc13783_rtc_alarm_irq_enable,
|
|
.update_irq_enable = mc13783_rtc_update_irq_enable,
|
|
};
|
|
|
|
static irqreturn_t mc13783_rtc_reset_handler(int irq, void *dev)
|
|
{
|
|
struct mc13783_rtc *priv = dev;
|
|
struct mc13783 *mc13783 = priv->mc13783;
|
|
|
|
dev_dbg(&priv->rtc->dev, "RTCRST\n");
|
|
priv->valid = 0;
|
|
|
|
mc13783_irq_mask(mc13783, irq);
|
|
|
|
return IRQ_HANDLED;
|
|
}
|
|
|
|
static int __devinit mc13783_rtc_probe(struct platform_device *pdev)
|
|
{
|
|
int ret;
|
|
struct mc13783_rtc *priv;
|
|
struct mc13783 *mc13783;
|
|
int rtcrst_pending;
|
|
|
|
priv = kzalloc(sizeof(*priv), GFP_KERNEL);
|
|
if (!priv)
|
|
return -ENOMEM;
|
|
|
|
mc13783 = dev_get_drvdata(pdev->dev.parent);
|
|
priv->mc13783 = mc13783;
|
|
|
|
platform_set_drvdata(pdev, priv);
|
|
|
|
mc13783_lock(mc13783);
|
|
|
|
ret = mc13783_irq_request(mc13783, MC13783_IRQ_RTCRST,
|
|
mc13783_rtc_reset_handler, DRIVER_NAME, priv);
|
|
if (ret)
|
|
goto err_reset_irq_request;
|
|
|
|
ret = mc13783_irq_status(mc13783, MC13783_IRQ_RTCRST,
|
|
NULL, &rtcrst_pending);
|
|
if (ret)
|
|
goto err_reset_irq_status;
|
|
|
|
priv->valid = !rtcrst_pending;
|
|
|
|
ret = mc13783_irq_request_nounmask(mc13783, MC13783_IRQ_1HZ,
|
|
mc13783_rtc_update_handler, DRIVER_NAME, priv);
|
|
if (ret)
|
|
goto err_update_irq_request;
|
|
|
|
ret = mc13783_irq_request_nounmask(mc13783, MC13783_IRQ_TODA,
|
|
mc13783_rtc_alarm_handler, DRIVER_NAME, priv);
|
|
if (ret)
|
|
goto err_alarm_irq_request;
|
|
|
|
priv->rtc = rtc_device_register(pdev->name,
|
|
&pdev->dev, &mc13783_rtc_ops, THIS_MODULE);
|
|
if (IS_ERR(priv->rtc)) {
|
|
ret = PTR_ERR(priv->rtc);
|
|
|
|
mc13783_irq_free(mc13783, MC13783_IRQ_TODA, priv);
|
|
err_alarm_irq_request:
|
|
|
|
mc13783_irq_free(mc13783, MC13783_IRQ_1HZ, priv);
|
|
err_update_irq_request:
|
|
|
|
err_reset_irq_status:
|
|
|
|
mc13783_irq_free(mc13783, MC13783_IRQ_RTCRST, priv);
|
|
err_reset_irq_request:
|
|
|
|
platform_set_drvdata(pdev, NULL);
|
|
kfree(priv);
|
|
}
|
|
|
|
mc13783_unlock(mc13783);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int __devexit mc13783_rtc_remove(struct platform_device *pdev)
|
|
{
|
|
struct mc13783_rtc *priv = platform_get_drvdata(pdev);
|
|
|
|
mc13783_lock(priv->mc13783);
|
|
|
|
rtc_device_unregister(priv->rtc);
|
|
|
|
mc13783_irq_free(priv->mc13783, MC13783_IRQ_TODA, priv);
|
|
mc13783_irq_free(priv->mc13783, MC13783_IRQ_1HZ, priv);
|
|
mc13783_irq_free(priv->mc13783, MC13783_IRQ_RTCRST, priv);
|
|
|
|
mc13783_unlock(priv->mc13783);
|
|
|
|
platform_set_drvdata(pdev, NULL);
|
|
|
|
kfree(priv);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static struct platform_driver mc13783_rtc_driver = {
|
|
.remove = __devexit_p(mc13783_rtc_remove),
|
|
.driver = {
|
|
.name = DRIVER_NAME,
|
|
.owner = THIS_MODULE,
|
|
},
|
|
};
|
|
|
|
static int __init mc13783_rtc_init(void)
|
|
{
|
|
return platform_driver_probe(&mc13783_rtc_driver, &mc13783_rtc_probe);
|
|
}
|
|
module_init(mc13783_rtc_init);
|
|
|
|
static void __exit mc13783_rtc_exit(void)
|
|
{
|
|
platform_driver_unregister(&mc13783_rtc_driver);
|
|
}
|
|
module_exit(mc13783_rtc_exit);
|
|
|
|
MODULE_AUTHOR("Sascha Hauer <s.hauer@pengutronix.de>");
|
|
MODULE_DESCRIPTION("RTC driver for Freescale MC13783 PMIC");
|
|
MODULE_LICENSE("GPL v2");
|
|
MODULE_ALIAS("platform:" DRIVER_NAME);
|