![Martin Kelly](/assets/img/avatar_default.png)
Currently a number of Makefiles break when used with toolchains that pass extra flags in CC and other cross-compile related variables (such as --sysroot). Thus we get this error when we use a toolchain that puts --sysroot in the CC var: ~/src/linux/tools$ make iio [snip] iio_event_monitor.c:18:10: fatal error: unistd.h: No such file or directory #include <unistd.h> ^~~~~~~~~~ This occurs because we clobber several env vars related to cross-compiling with lines like this: CC = $(CROSS_COMPILE)gcc Although this will point to a valid cross-compiler, we lose any extra flags that might exist in the CC variable, which can break toolchains that rely on them (for example, those that use --sysroot). This easily shows up using a Yocto SDK: $ . [snip]/sdk/environment-setup-cortexa8hf-neon-poky-linux-gnueabi $ echo $CC arm-poky-linux-gnueabi-gcc -march=armv7-a -mfpu=neon -mfloat-abi=hard -mcpu=cortex-a8 --sysroot=[snip]/sdk/sysroots/cortexa8hf-neon-poky-linux-gnueabi $ echo $CROSS_COMPILE arm-poky-linux-gnueabi- $ echo ${CROSS_COMPILE}gcc krm-poky-linux-gnueabi-gcc Although arm-poky-linux-gnueabi-gcc is a cross-compiler, we've lost the --sysroot and other flags that enable us to find the right libraries to link against, so we can't find unistd.h and other libraries and headers. Normally with the --sysroot flag we would find unistd.h in the sdk directory in the sysroot: $ find [snip]/sdk/sysroots -path '*/usr/include/unistd.h' [snip]/sdk/sysroots/cortexa8hf-neon-poky-linux-gnueabi/usr/include/unistd.h The perf Makefile adds CC = $(CROSS_COMPILE)gcc if and only if CC is not already set, and it compiles correctly with the above toolchain. So, generalize the logic that perf uses in the common Makefile and remove the manual CC = $(CROSS_COMPILE)gcc lines from each Makefile. Note that this patch does not fix cross-compile for all the tools (some have other bugs), but it does fix it for all except usb and acpi, which still have other unrelated issues. I tested both with and without the patch on native and cross-build and there appear to be no regressions. Link: http://lkml.kernel.org/r/20180107214028.23771-1-martin@martingkelly.com Signed-off-by: Martin Kelly <martin@martingkelly.com> Acked-by: Mark Brown <broonie@kernel.org> Cc: Tejun Heo <tj@kernel.org> Cc: Li Zefan <lizefan@huawei.com> Cc: Johannes Weiner <hannes@cmpxchg.org> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: "K. Y. Srinivasan" <kys@microsoft.com> Cc: Haiyang Zhang <haiyangz@microsoft.com> Cc: Stephen Hemminger <sthemmin@microsoft.com> Cc: Jonathan Cameron <jic23@kernel.org> Cc: Pali Rohar <pali.rohar@gmail.com> Cc: Richard Purdie <rpurdie@rpsys.net> Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com> Cc: Pavel Machek <pavel@ucw.cz> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Ingo Molnar <mingo@redhat.com> Cc: Arnaldo Carvalho de Melo <acme@kernel.org> Cc: Robert Moore <robert.moore@intel.com> Cc: Lv Zheng <lv.zheng@intel.com> Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Valentina Manea <valentina.manea.m@gmail.com> Cc: Shuah Khan <shuah@kernel.org> Cc: Mario Limonciello <mario.limonciello@dell.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
75 lines
1.8 KiB
Makefile
75 lines
1.8 KiB
Makefile
# SPDX-License-Identifier: GPL-2.0
|
|
include ../scripts/Makefile.include
|
|
|
|
bindir ?= /usr/bin
|
|
|
|
ifeq ($(srctree),)
|
|
srctree := $(patsubst %/,%,$(dir $(CURDIR)))
|
|
srctree := $(patsubst %/,%,$(dir $(srctree)))
|
|
endif
|
|
|
|
# Do not use make's built-in rules
|
|
# (this improves performance and avoids hard-to-debug behaviour);
|
|
MAKEFLAGS += -r
|
|
|
|
CFLAGS += -O2 -Wall -g -D_GNU_SOURCE -I$(OUTPUT)include
|
|
|
|
ALL_TARGETS := lsgpio gpio-hammer gpio-event-mon
|
|
ALL_PROGRAMS := $(patsubst %,$(OUTPUT)%,$(ALL_TARGETS))
|
|
|
|
all: $(ALL_PROGRAMS)
|
|
|
|
export srctree OUTPUT CC LD CFLAGS
|
|
include $(srctree)/tools/build/Makefile.include
|
|
|
|
#
|
|
# We need the following to be outside of kernel tree
|
|
#
|
|
$(OUTPUT)include/linux/gpio.h: ../../include/uapi/linux/gpio.h
|
|
mkdir -p $(OUTPUT)include/linux 2>&1 || true
|
|
ln -sf $(CURDIR)/../../include/uapi/linux/gpio.h $@
|
|
|
|
prepare: $(OUTPUT)include/linux/gpio.h
|
|
|
|
#
|
|
# lsgpio
|
|
#
|
|
LSGPIO_IN := $(OUTPUT)lsgpio-in.o
|
|
$(LSGPIO_IN): prepare FORCE
|
|
$(Q)$(MAKE) $(build)=lsgpio
|
|
$(OUTPUT)lsgpio: $(LSGPIO_IN)
|
|
$(QUIET_LINK)$(CC) $(CFLAGS) $(LDFLAGS) $< -o $@
|
|
|
|
#
|
|
# gpio-hammer
|
|
#
|
|
GPIO_HAMMER_IN := $(OUTPUT)gpio-hammer-in.o
|
|
$(GPIO_HAMMER_IN): prepare FORCE
|
|
$(Q)$(MAKE) $(build)=gpio-hammer
|
|
$(OUTPUT)gpio-hammer: $(GPIO_HAMMER_IN)
|
|
$(QUIET_LINK)$(CC) $(CFLAGS) $(LDFLAGS) $< -o $@
|
|
|
|
#
|
|
# gpio-event-mon
|
|
#
|
|
GPIO_EVENT_MON_IN := $(OUTPUT)gpio-event-mon-in.o
|
|
$(GPIO_EVENT_MON_IN): prepare FORCE
|
|
$(Q)$(MAKE) $(build)=gpio-event-mon
|
|
$(OUTPUT)gpio-event-mon: $(GPIO_EVENT_MON_IN)
|
|
$(QUIET_LINK)$(CC) $(CFLAGS) $(LDFLAGS) $< -o $@
|
|
|
|
clean:
|
|
rm -f $(ALL_PROGRAMS)
|
|
rm -f $(OUTPUT)include/linux/gpio.h
|
|
find $(if $(OUTPUT),$(OUTPUT),.) -name '*.o' -delete -o -name '\.*.d' -delete
|
|
|
|
install: $(ALL_PROGRAMS)
|
|
install -d -m 755 $(DESTDIR)$(bindir); \
|
|
for program in $(ALL_PROGRAMS); do \
|
|
install $$program $(DESTDIR)$(bindir); \
|
|
done
|
|
|
|
FORCE:
|
|
|
|
.PHONY: all install clean FORCE prepare
|