redonkable
/
remarkable-uboot
1
0
Fork 0
Code Releases Activity

ubifs: Fix bad free() sequence in ubifs_finddir() 

Free private_data member element before freeing file structure.
This was causing malloc to crash. Also remove unnecessary variable
assigments as file structure gets free'd as well.

Signed-off-by: Rod Boyce <uboot@teamboyce.co.uk>
Signed-off-by: Wolfgang Denk <wd@denx.de>
Cc: Stefan Roese <sr@denx.de>
Signed-off-by: Stefan Roese <sr@denx.de>
utp
Wolfgang Denk 2011-07-28 15:27:22 +02:00 committed by Stefan Roese
parent fa82f871c8
commit 3267bc1b2b
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
fs/ubifs/ubifs.c
View File

@ -360,6 +360,8 @@ out:
return err;
}
if (file->private_data)
kfree(file->private_data);
if (file)
free(file);
if (dentry)
@ -367,10 +369,6 @@ out:
if (dir)
free(dir);
if (file->private_data)
kfree(file->private_data);
file->private_data = NULL;
file->f_pos = 2;
return 0;
}