mkimage: Don't close the file if it wasn't opened
The error path for fit_import_data() is incorrect if the second open() call fails. Reported-by: Coverity (CID: 138489) Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-by: Tom Rini <trini@konsulko.com>utp
parent
3bd3a54ac5
commit
5b15a2596f
|
@ -537,8 +537,8 @@ static int fit_import_data(struct image_tool_params *params, const char *fname)
|
||||||
if (fd < 0) {
|
if (fd < 0) {
|
||||||
fprintf(stderr, "%s: Can't open %s: %s\n",
|
fprintf(stderr, "%s: Can't open %s: %s\n",
|
||||||
params->cmdname, fname, strerror(errno));
|
params->cmdname, fname, strerror(errno));
|
||||||
ret = -EIO;
|
free(fdt);
|
||||||
goto err;
|
return -EIO;
|
||||||
}
|
}
|
||||||
if (write(fd, fdt, new_size) != new_size) {
|
if (write(fd, fdt, new_size) != new_size) {
|
||||||
debug("%s: Failed to write external data to file %s\n",
|
debug("%s: Failed to write external data to file %s\n",
|
||||||
|
|
Loading…
Reference in New Issue