redonkable
/
remarkable-uboot
1
0
Fork 0
Code Releases Activity

libfdt: fix error code of fdt_count_strings() 

Currently, this function returns a positive value on error,
so we never know whether this function has succeeded or failed.

For example, if the given property is not found, fdt_getprop()
returns -FDT_ERR_NOTFOUND, and then this function inverts it,
i.e., returns FDT_ERR_NOTFOUND (=1).

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Fixes: bc4147ab2d ("fdt: Add a function to count strings")
Acked-by: Simon Glass <sjg@chromium.org>
utp
Masahiro Yamada 2015-07-15 01:08:44 +09:00 committed by Simon Glass
parent 31f334abc5
commit 73e1e7952a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/libfdt/fdt_ro.c
View File

@ -517,7 +517,7 @@ int fdt_count_strings(const void *fdt, int node, const char *property)
list = fdt_getprop(fdt, node, property, &length);
if (!list)
return -length;
return length;
for (i = 0; i < length; i++) {
int len = strlen(list);