redonkable
/
remarkable-uboot
1
0
Fork 0
Code Releases Activity

env_ubi.c: Correct pointer error in env load 

The variable "buf" in this function is a char array, and the
function ubi_volume_read is expecting a char *.  In the call, the
address of the pointer is being taken, incorrectly passing a
char **.  The compiler warning was being silenced by the cast.
Remove the address operator and the cast.

Signed-off-by: Kevin Smith <kevin.smith@elecsyscorp.com>
Cc: Joe Hershberger <joe.hershberger@ni.com>
Cc: Tom Rini <trini@konsulko.com>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Reviewed-by: Heiko Schocher <hs@denx.de>
utp
Kevin Smith 2015-10-23 17:51:47 +00:00 committed by Heiko Schocher
parent 736d1746fb
commit a7c06cd3a6
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
common/env_ubi.c
View File

@ -181,8 +181,7 @@ void env_relocate_spec(void)
return;
}
if (ubi_volume_read(CONFIG_ENV_UBI_VOLUME, (void *)&buf,
CONFIG_ENV_SIZE)) {
if (ubi_volume_read(CONFIG_ENV_UBI_VOLUME, buf, CONFIG_ENV_SIZE)) {
printf("\n** Unable to read env from %s:%s **\n",
CONFIG_ENV_UBI_PART, CONFIG_ENV_UBI_VOLUME);
set_default_env(NULL);