redonkable
/
remarkable-uboot
1
0
Fork 0
Code Releases Activity

drivers/gpio/pm8916_gpio.c: Make pid be uint32_t 

If get_dev_addr fails it will return FDT_ADDR_T_NONE and:
>>>     "priv->pid == 4294967295U" is always false regardless of the values of its operands. This occurs as the logical operand of if.

Cc: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Reported-by: Coverity (CID: 143913)
Signed-off-by: Tom Rini <trini@konsulko.com>
utp
Tom Rini 2016-04-12 15:11:23 -04:00
parent 55ac54c4a0
commit aa997d1d77
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/gpio/pm8916_gpio.c
View File

@ -50,7 +50,7 @@ DECLARE_GLOBAL_DATA_PTR;
#define REG_EN_CTL_ENABLE (1 << 7)
struct pm8916_gpio_bank {
uint16_t pid; /* Peripheral ID on SPMI bus */
uint32_t pid; /* Peripheral ID on SPMI bus */
};
static int pm8916_gpio_set_direction(struct udevice *dev, unsigned offset,