redonkable
/
remarkable-uboot
1
0
Fork 0
Code Releases Activity

usb: ci_udc: fix ci_flush_{qh,qtd} calls in ci_udc_probe() 

ci_udc_probe() initializes a pair of QHs and QTDs for each EP. After
each pair has been initialized, the pair is cache-flushed. The
conversion from QH/QTD index [0..2*NUM_END_POINTS) to EP index
[0..NUM_ENDPOINTS] is incorrect; it simply subtracts 1 (which yields
the QH/QTD index of the first entry in the pair) rather than dividing
by two (which scales the range). Fix this.

On my system, this avoids cache debug prints due to requests to flush
unaligned ranges. This is caused because the flush calls happen before
the items[] array entries are initialized for all but EP0.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
utp
Stephen Warren 2014-07-01 11:41:13 -06:00 committed by Marek Vasut
parent afb8e71cae
commit d7beeb9358
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/usb/gadget/ci_udc.c
View File

@ -834,8 +834,8 @@ static int ci_udc_probe(void)
controller.items[i] = (struct ept_queue_item *)imem;
if (i & 1) {
ci_flush_qh(i - 1);
ci_flush_qtd(i - 1);
ci_flush_qh(i / 2);
ci_flush_qtd(i / 2);
}
}