redonkable
/
remarkable-uboot
1
0
Fork 0
Code Releases Activity

led: Return -ENODEV if the LED device cannot be found 

We normally use -ENODEV for a missing device, rather than -ENOENT. The
latter is reserved for when we have a device but cannot find something
within it.

Also avoid looking at the root LED device since it is only a container.

Signed-off-by: Simon Glass <sjg@chromium.org>
utp
Simon Glass 2015-07-06 12:54:33 -06:00
parent 8e6cc46178
commit fb8a5ffc77
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/led/led-uclass.c
View File

@ -24,11 +24,12 @@ int led_get_by_label(const char *label, struct udevice **devp)
uclass_foreach_dev(dev, uc) {
struct led_uclass_plat *uc_plat = dev_get_uclass_platdata(dev);
if (!strcmp(label, uc_plat->label))
/* Ignore the top-level LED node */
if (uc_plat->label && !strcmp(label, uc_plat->label))
return uclass_get_device_tail(dev, 0, devp);
}
return -ENOENT;
return -ENODEV;
}
int led_set_on(struct udevice *dev, int on)

2
include/led.h
View File

@ -35,7 +35,7 @@ struct led_ops {
*
* @label: LED label to look up
* @devp: Returns the associated device, if found
* @return 0 if found, -ve on error
* @return 0 if found, -ENODEV if not found, other -ve on error
*/
int led_get_by_label(const char *label, struct udevice **devp);