1
0
Fork 0
remarkable-uboot/arch/arm/cpu/armv8
Stephen Warren 116611937f ARM: fix ifdefs in ARMv8 lowlevel_init()
Commit 724219a65f "ARM: always perform per-CPU GIC init" removed some
ifdefs to unify the MULTIENTRY-vs-non-MULTIENTRY paths. However, the
wrong endif was removed. This patch adds back that missing endif, and
adds a new ifdef to match the endif the now-correctly-terminated block
used to match against. Use "git show -U25 724219a65f55" to see enough
context to make the original issue clear.

In practical terms, this makes no difference to runtime behaviour. The
code that was incorrectly compiled into the binary when ifndef MULTIENTRY
is a no-op for other cases, since branch_if_master evaluates to a hard-
coded jump. The only issues were:

- A few extra instructions were added to the binary.
- The comment on the endif at the very end of the function, indicating
which ifdef it matched, were wrong.

An alternative might be to simply fix the comment on that trailing ifdef,
but that only addresses the second point above, not the first.

Fixes: 724219a65f ("ARM: always perform per-CPU GIC init")
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Stephen Warren <swarren@nvidia.com>
Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>
2016-05-06 10:10:05 -04:00
..
fsl-layerscape Fix various typos, scattered over the code. 2016-05-05 21:39:26 -04:00
hisilicon hisilicon: hi6220: Add a hi6220 pinmux driver. 2015-08-12 20:48:00 -04:00
zynqmp ARM64: zynqmp: Select SYS_CONFIG_NAME via Kconfig 2016-04-04 20:28:38 +02:00
Kconfig Use correct spelling of "U-Boot" 2016-02-06 12:00:59 +01:00
Makefile armv8: Add Secure Monitor/Hypervisor Call (SMC/HVC) infrastructure 2016-01-19 22:25:36 +00:00
cache.S arm64: Make full va map code more dynamic 2016-03-15 15:13:01 -04:00
cache_v8.c arm64: Fix layerscape mmu setup 2016-03-21 12:42:10 -07:00
config.mk ARM: move -march=* and -mtune= options to arch/arm/Makefile 2015-03-27 16:55:22 +01:00
cpu.c arm64: core support 2014-01-09 16:08:44 +01:00
exceptions.S arm64: Allow exceptions to return 2016-03-15 21:30:10 -04:00
fwcall.c armv8: Add Secure Monitor/Hypervisor Call (SMC/HVC) infrastructure 2016-01-19 22:25:36 +00:00
generic_timer.c armv8: define usec2ticks function 2015-12-15 08:57:34 +08:00
start.S ARM: fix ifdefs in ARMv8 lowlevel_init() 2016-05-06 10:10:05 -04:00
tlb.S remove unnecessary version.h includes 2015-03-24 10:50:50 -04:00
transition.S remove unnecessary version.h includes 2015-03-24 10:50:50 -04:00
u-boot-spl.lds arm64: define _image_binary_end to fix SPL_OF_CONTROL 2016-03-14 19:18:52 -04:00
u-boot.lds efi_loader: Add runtime services 2016-03-15 18:03:10 -04:00