retropilot
/
cabana
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

cabana: patch up some undefined edge cases

main
Andy Haden 2017-10-16 20:10:38 -07:00
parent f33a1504f1
commit 02eb3c4bc6
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/components/CanLog.js
View File

@ -131,6 +131,10 @@ export default class CanLog extends Component {
{ Object.entries(msgEntry.signals).map(
([name, value]) => {
const signal = message.frame.signals[name];
if (signal === undefined) {
// Signal removed?
return null;
}
const unit = signal.unit.length > 0 ? signal.unit : 'units';
const isPlotted = this.isSignalPlotted(message.id, signal.uid);
const plottedButtonClass = isPlotted ? null : 'button--alpha';

6
src/models/can/dbc.js
View File

@ -291,7 +291,11 @@ export default class DBC {
receiver};
const signal = new Signal(signalProperties);
messages.get(id).signals[name] = signal;
if (messages.get(id) !== undefined) {
messages.get(id).signals[name] = signal;
} else {
CloudLog.warn('importDbcString: could not add signal: ' + name + ' due to missing message: ' + id);
}
} else if(line.indexOf("VAL_ ") === 0) {
let matches = line.match(VAL_RE);