From 228308b719a5e1fb24ce912eeaa13eaf2db0a22e Mon Sep 17 00:00:00 2001
From: Dean Lee <deanlee3@gmail.com>
Date: Sun, 2 May 2021 00:50:32 +0800
Subject: [PATCH] Replay: make response a const reference in parseResponse
 (#20787)

---
 selfdrive/ui/replay/replay.cc  | 7 +++----
 selfdrive/ui/replay/replay.hpp | 2 +-
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/selfdrive/ui/replay/replay.cc b/selfdrive/ui/replay/replay.cc
index 5320ce6c..427d96e0 100644
--- a/selfdrive/ui/replay/replay.cc
+++ b/selfdrive/ui/replay/replay.cc
@@ -10,12 +10,11 @@ Replay::Replay(QString route_, int seek) : route(route_) {
 #endif
 
   http = new HttpRequest(this, "https://api.commadotai.com/v1/route/" + route + "/files", "", create_jwt);
-  QObject::connect(http, SIGNAL(receivedResponse(QString)), this, SLOT(parseResponse(QString)));
+  QObject::connect(http, &HttpRequest::receivedResponse, this, &Replay::parseResponse);
 }
 
-void Replay::parseResponse(QString response){
-  response = response.trimmed();
-  QJsonDocument doc = QJsonDocument::fromJson(response.toUtf8());
+void Replay::parseResponse(const QString &response){
+  QJsonDocument doc = QJsonDocument::fromJson(response.trimmed().toUtf8());
 
   if (doc.isNull()) {
     qDebug() << "JSON Parse failed";
diff --git a/selfdrive/ui/replay/replay.hpp b/selfdrive/ui/replay/replay.hpp
index 6ca04261..46e7c01c 100644
--- a/selfdrive/ui/replay/replay.hpp
+++ b/selfdrive/ui/replay/replay.hpp
@@ -29,7 +29,7 @@ public:
   QQueue<int> event_sizes;
 
 public slots:
-  void parseResponse(QString response);
+  void parseResponse(const QString &response);
 
 protected:
   Unlogger *unlogger;