From f71fd7b91bca5b8f2d40b56933c9b539bebd9f67 Mon Sep 17 00:00:00 2001 From: Dean Lee Date: Wed, 27 Jan 2021 19:01:23 +0800 Subject: [PATCH] get value by reference in ranged based loop (#624) --- drivers/windows/pandaJ2534DLL/PandaJ2534Device.cpp | 2 +- drivers/windows/panda_shared/panda.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/windows/pandaJ2534DLL/PandaJ2534Device.cpp b/drivers/windows/pandaJ2534DLL/PandaJ2534Device.cpp index 69a0326..b1a854a 100644 --- a/drivers/windows/pandaJ2534DLL/PandaJ2534Device.cpp +++ b/drivers/windows/pandaJ2534DLL/PandaJ2534Device.cpp @@ -150,7 +150,7 @@ DWORD PandaJ2534Device::kline_recv_thread() { continue; } - for (auto msg : msg_recv) { + for (auto &msg : msg_recv) { for (auto& conn : this->connections) { if (conn != nullptr && !conn->isProtoCan()) { J2534Frame msg_out(conn->getProtocol(), msg); diff --git a/drivers/windows/panda_shared/panda.cpp b/drivers/windows/panda_shared/panda.cpp index 2c13687..de79403 100644 --- a/drivers/windows/panda_shared/panda.cpp +++ b/drivers/windows/panda_shared/panda.cpp @@ -323,7 +323,7 @@ bool Panda::can_send_many(const std::vector& can_msgs) { std::vector formatted_msgs; formatted_msgs.reserve(can_msgs.size()); - for (auto msg : can_msgs) { + for (auto &msg : can_msgs) { if (msg.bus == PANDA_CAN_UNK) continue; if (msg.len > 8) continue; PANDA_CAN_MSG_INTERNAL tmpmsg = {};