From e038d0a1a24eb2c3e0dd0274695cf79832ab00d3 Mon Sep 17 00:00:00 2001 From: gabrielburnworth Date: Fri, 26 Apr 2019 09:34:36 -0700 Subject: [PATCH] remove unused prop --- .../devices/components/fbos_settings/camera_selection.tsx | 2 -- frontend/farmware/weed_detector/config.tsx | 7 ++----- frontend/regimens/bulk_scheduler/index.tsx | 3 +-- frontend/sequences/sequence_select_box.tsx | 3 +-- frontend/sequences/step_tiles/tile_if/then_else.tsx | 2 -- frontend/ui/new_fb_select.tsx | 2 -- 6 files changed, 4 insertions(+), 15 deletions(-) diff --git a/frontend/devices/components/fbos_settings/camera_selection.tsx b/frontend/devices/components/fbos_settings/camera_selection.tsx index 47d89bfb4..c91276f5d 100644 --- a/frontend/devices/components/fbos_settings/camera_selection.tsx +++ b/frontend/devices/components/fbos_settings/camera_selection.tsx @@ -1,6 +1,5 @@ import * as React from "react"; import { DropDownItem, Row, Col, FBSelect } from "../../../ui/index"; - import { CameraSelectionProps, CameraSelectionState } from "./interfaces"; @@ -69,7 +68,6 @@ export class CameraSelection allowEmpty={false} list={CAMERA_CHOICES()} selectedItem={this.selectedCamera()} - placeholder="Select a camera..." onChange={this.sendOffConfig} extraClass={this.props.botOnline ? "" : "disabled"} /> diff --git a/frontend/farmware/weed_detector/config.tsx b/frontend/farmware/weed_detector/config.tsx index 7e0cbc6b6..9626c3ca3 100644 --- a/frontend/farmware/weed_detector/config.tsx +++ b/frontend/farmware/weed_detector/config.tsx @@ -1,5 +1,4 @@ import * as React from "react"; - import { BlurableInput, Row, Col, @@ -69,8 +68,7 @@ export class WeedDetectorConfig extends React.Component { + list={CALIBRATION_DROPDOWNS} /> { + selectedItem={this.find("CAMERA_CALIBRATION_image_bot_origin_location")} /> { + list={this.all()} /> diff --git a/frontend/sequences/sequence_select_box.tsx b/frontend/sequences/sequence_select_box.tsx index 74ce3678a..64347ace2 100644 --- a/frontend/sequences/sequence_select_box.tsx +++ b/frontend/sequences/sequence_select_box.tsx @@ -40,6 +40,5 @@ export function SequenceSelectBox(props: SequenceSelectBoxProps) { return ; + list={sequenceDropDownList()} />; } diff --git a/frontend/sequences/step_tiles/tile_if/then_else.tsx b/frontend/sequences/step_tiles/tile_if/then_else.tsx index 3f24b6820..0682d6dd6 100644 --- a/frontend/sequences/step_tiles/tile_if/then_else.tsx +++ b/frontend/sequences/step_tiles/tile_if/then_else.tsx @@ -1,6 +1,5 @@ import * as React from "react"; import { ThenElseParams, seqDropDown, IfBlockDropDownHandler } from "./index"; - import { Row, Col, FBSelect } from "../../../ui"; import { LocalsList } from "../../locals_list/locals_list"; import { AllowedVariableNodes } from "../../locals_list/locals_list_support"; @@ -21,7 +20,6 @@ export function ThenElse(props: ThenElseParams) { key={JSON.stringify(props.currentSequence)} allowEmpty={true} list={seqDropDown(props.resources)} - placeholder="Sequence..." onChange={onChange} selectedItem={selectedItem()} /> {!!calledSequenceVariableData && diff --git a/frontend/ui/new_fb_select.tsx b/frontend/ui/new_fb_select.tsx index 6ae14e24d..776e5ede1 100644 --- a/frontend/ui/new_fb_select.tsx +++ b/frontend/ui/new_fb_select.tsx @@ -12,8 +12,6 @@ export interface FBSelectProps { list: DropDownItem[]; /** Allow user to select no value. */ allowEmpty?: boolean; - /** Text shown before user selection. */ - placeholder?: string | undefined; /** Extra class names to add. */ extraClass?: string; /** Custom label for NULL_CHOICE instead of "None". */