From 4faab5fe6ac73a50e9d229b8f4a0982c7ef6d481 Mon Sep 17 00:00:00 2001
From: Rick Carlino <rick.carlino@gmail.com>
Date: Thu, 6 Feb 2020 09:32:38 -0600
Subject: [PATCH] Corpus and formatting updates

---
 ...CeleryScript.SysCalls.Stubs-5524.coverdata | Bin 0 -> 5203 bytes
 farmbot_celery_script/coveralls.json          |   1 +
 farmbot_celery_script/fixture/corpus.json     |  15 -----------
 .../corpus/node_test.exs                      |   7 +++--
 farmbot_os/config/config.exs                  |  24 ++++++++++++------
 farmbot_os/coveralls.json                     |   2 +-
 .../lib/farmbot_os/configurator/router.ex     |   4 ++-
 7 files changed, 26 insertions(+), 27 deletions(-)
 create mode 100644 farmbot_celery_script/Elixir.FarmbotCeleryScript.SysCalls.Stubs-5524.coverdata

diff --git a/farmbot_celery_script/Elixir.FarmbotCeleryScript.SysCalls.Stubs-5524.coverdata b/farmbot_celery_script/Elixir.FarmbotCeleryScript.SysCalls.Stubs-5524.coverdata
new file mode 100644
index 0000000000000000000000000000000000000000..0a04ab59761ff9a003fbaf85a0052a4b83ceca0a
GIT binary patch
literal 5203
zcmb_gYg80v7#?m*fasDJ(!(kzBtS*LR8TH)Rc<OsDkwO9JNxbK;O>0u%q*~gnQ|~t
zKvNJ2jiZKQr=w|+iW-E1sCb3+7;0uEVWmgBMV>f)Gpp$Do&7m~p7VU~`@GNdzEe_^
zLJ&lE-j4E$ROi+}d8}Rj*fobg@y%cB;i=l{pVbuPeSCC5_4vgNf7IQ%-V*pQsB8bx
z#~smaSqEAdJQ&=T-=?;6dg}k%#f<}B_ic{tc3hUKIdZCdQdDnP3{$+KFs80--kwHp
z=kWONVMJx>2%p%@4Ci<DuMHebck5RSesu5Cg{y5kd{VUXBCV~8aG1!^`A|s^wq63U
z;X!#j>bFI)J%PjGemp(@?zPgcxSW%b!ONf7);zO~AlC2oEOm-&AYjI<)d|O#&+2zw
zIoE&3$ulD2N@i8t^Sav#1zIzfc|NM{ir1#l^9MHe-15EDUU1`qve}&+)wW4(N{G+6
zX>&Bi?c;&Ux>>(0dE9!iw>aQlaX@eJ&z&yKC&LP1d2Yc>H{;HNZ_Ax#*t*(ejJy83
zEVCk`NA~yRCs{S``%N#ow5=q`eOhGIDZB4FX2?R<`Mmh@{M|>2tB&F7($3SSF`fPW
zvxm1AxkXh}wA!b7w7cmixT*dn9giI>D?jZO=sag<%i<~*@9Eu>9Gdof94P|H34fLD
zJ}_ZKRq)l8n))P|McJ?1(w!7?zyF^JK^Nzq=#xJmxm(jNZ>%a@;hQwjl5*|v*|Lhv
zce|5U2k&WI*ZgAoK%y}W#!l?N>lYmt_TS}0W4cZ>sGrrkyxq0&D`SEW6;hE>)7-Q~
z@u+d%QrgpBA@5w?;S+GK`kU6sb@bNm(0zPsPvoIhyB3cdnCO42dWpidBXUuFWlnaw
zY5dd7W+u4S_x`UhrWN}nv@Pf1&CZ|)yev9=S=hrdO;2M3v!eYsY+qWMH~Y9<dUoih
zzU&LsuI#hd*GzHG?B-@}IeE#!VDDd*cxJmVeIrEv#iGlT{r*hu8z~F);7f|jewb8!
zCf=Bs^?`To))TjPF6`|oTJ=*ny~2HgL&K9}c`<vt_K}0c+6#~L@mMojnToJi8ubPh
z;TNZ)^JsSJ9Kh<8h>w9f$ePk9mNxKH(@b0p(CN6TX}nR%VWB~mMJ%udHsEtWEVLYG
z1PeK2WGP4*4JyDxV22?K0kObx$YC1DlN?-SgbW2Snhi(<M5^U@!__*#X-PHB>T>~W
zMw}syA*F@X%2zKYFvD?xm}@yh`+UeE@uk($n!(}98EA&25vfNiDE4<fAm&(3%}$3j
zB8;;%X1MMuk^;DJDuJQ+SOka^%bB^V0mUQML}CR(UId&1h$PDa-x4_r<b<)%Ny8#Z
zno%Q?#7K^SkfvX#hpYw<gNf83Y9&Uq0iM$ID@@qSW|&00ScwdCfQ|$l2U(s*=K9rI
zt$s40ep34SMlT!$tYphI;$%R%kR_2?EtZY88Zmo;m=p`i1+;kxHcJ~+!9s8!a}Ws_
zjm~T#MOIT=zF4-ofJn2v2Xab_sX-FuGLYr8v_Z@qcR*Mt4{;w7Ehp#5AYMx|8u6W^
z)#PC-$U}-*>QN3Pfs#WyBMxbMY$55=bRt-Y0nrRkYFK16U_cvyhvGxaOXv0~^Rac(
zJoY+`2<j?Le1e{hSkNS7azta_AQg{Mk$T8+Kx1BZK9+{}h85?DqKN_oX?YPnXolnQ
zrYEdB9PSWcc@wF|8=<)R2+^?!5c4d@cjl1>+rm(Wv(_5B-O@babw(PQp_KHp+WgrF
z^C!h$#8DCTM@a*Ey|~u_BHi*vjuwQ+Bc$VWh$q#E6+gs@n=j27UM<>qF;gPMi=v(e
zi20UtbrCl+tZUxLiEu_~PaiTG3h50x$ipGCky}kMc7kFOEPu1?jp|`zkaGXPJV;^J
zCpqyJ6h-)+v@J+YV-wUOz4@35kQPm%0~%Qt;w&*+V2Ct!6wuL1Ryan5P#P%>i~;(W
zCyQ_uWJ)tn3L#d74~&<0vO?O*CpJJ}m1?~Pm>0ANX~Z}agIx|2E0<RLT$aYN6)rO2
buR^8uUTHphLZ$hf`G?2ra23Sn2Z;Xx=KM%z

literal 0
HcmV?d00001

diff --git a/farmbot_celery_script/coveralls.json b/farmbot_celery_script/coveralls.json
index 2b87e2de..7b91515c 100644
--- a/farmbot_celery_script/coveralls.json
+++ b/farmbot_celery_script/coveralls.json
@@ -2,5 +2,6 @@
   "skip_files": [
     "lib/farmbot_celery_script/compiler/tools.ex"
   ],
+  "minimum_coverage": 53,
   "treat_no_relevant_lines_as_covered": true
 }
diff --git a/farmbot_celery_script/fixture/corpus.json b/farmbot_celery_script/fixture/corpus.json
index e2843d58..b5ddba86 100644
--- a/farmbot_celery_script/fixture/corpus.json
+++ b/farmbot_celery_script/fixture/corpus.json
@@ -92,7 +92,6 @@
         "calibrate",
         "change_ownership",
         "check_updates",
-        "dump_info",
         "emergency_lock",
         "emergency_unlock",
         "execute",
@@ -832,18 +831,6 @@
       ],
       "docs": ""
     },
-    {
-      "allowed_args": [],
-      "allowed_body_types": [],
-      "name": "dump_info",
-      "tags": [
-        "function",
-        "network_user",
-        "disk_user",
-        "api_writer"
-      ],
-      "docs": "Sends an info dump to server administrators for troubleshooting."
-    },
     {
       "allowed_args": [],
       "allowed_body_types": [],
@@ -1170,7 +1157,6 @@
         "calibrate",
         "change_ownership",
         "check_updates",
-        "dump_info",
         "emergency_lock",
         "emergency_unlock",
         "execute",
@@ -1242,7 +1228,6 @@
         "calibrate",
         "change_ownership",
         "check_updates",
-        "dump_info",
         "emergency_lock",
         "emergency_unlock",
         "execute",
diff --git a/farmbot_celery_script/test/farmbot_celery_script/corpus/node_test.exs b/farmbot_celery_script/test/farmbot_celery_script/corpus/node_test.exs
index 5709cd3b..e34e2aec 100644
--- a/farmbot_celery_script/test/farmbot_celery_script/corpus/node_test.exs
+++ b/farmbot_celery_script/test/farmbot_celery_script/corpus/node_test.exs
@@ -3,7 +3,10 @@ defmodule FarmbotCeleryScript.Corpus.NodeTest do
   alias FarmbotCeleryScript.Corpus
 
   test "inspect" do
-    assert "Sequence(version, locals) [calibrate, change_ownership, check_updates, emergency_lock, emergency_unlock, execute, execute_script, factory_reset, find_home, flash_firmware, home, install_farmware, install_first_party_farmware, _if, move_absolute, move_relative, power_off, read_pin, read_status, reboot, remove_farmware, resource_update, send_message, set_servo_angle, set_user_env, sync, take_photo, toggle_pin, update_farmware, wait, write_pin, zero]" =
-             inspect(Corpus.sequence())
+    a =
+      "Sequence(version, locals) [calibrate, change_ownership, check_updates, emergency_lock, emergency_unlock, execute, execute_script, factory_reset, find_home, flash_firmware, home, install_farmware, install_first_party_farmware, _if, move_absolute, move_relative, power_off, read_pin, read_status, reboot, remove_farmware, resource_update, send_message, set_servo_angle, set_user_env, sync, take_photo, toggle_pin, update_farmware, wait, write_pin, zero]"
+
+    b = inspect(Corpus.sequence())
+    assert a == b
   end
 end
diff --git a/farmbot_os/config/config.exs b/farmbot_os/config/config.exs
index 533cd15d..24d5e951 100644
--- a/farmbot_os/config/config.exs
+++ b/farmbot_os/config/config.exs
@@ -1,6 +1,7 @@
 use Mix.Config
 
-config :farmbot_core, FarmbotCore.AssetWorker.FarmbotCore.Asset.FarmEvent, checkup_time_ms: 10_000
+config :farmbot_core, FarmbotCore.AssetWorker.FarmbotCore.Asset.FarmEvent,
+  checkup_time_ms: 10_000
 
 config :farmbot_core, FarmbotCore.AssetWorker.FarmbotCore.Asset.RegimenInstance,
   checkup_time_ms: 10_000
@@ -18,9 +19,11 @@ config :farmbot_core, FarmbotCore.AssetWorker.FarmbotCore.Asset.PinBinding,
   gpio_handler: FarmbotCore.PinBindingWorker.StubGPIOHandler,
   error_retry_time_ms: 30_000
 
-config :farmbot_core, FarmbotCore.Leds, gpio_handler: FarmbotCore.Leds.StubHandler
+config :farmbot_core, FarmbotCore.Leds,
+  gpio_handler: FarmbotCore.Leds.StubHandler
 
-config :farmbot_core, FarmbotCore.JSON, json_parser: FarmbotCore.JSON.JasonParser
+config :farmbot_core, FarmbotCore.JSON,
+  json_parser: FarmbotCore.JSON.JasonParser
 
 # Customize non-Elixir parts of the firmware.  See
 # https://hexdocs.pm/nerves/advanced-configuration.html for details.
@@ -43,13 +46,15 @@ config :farmbot_core, FarmbotCore.EctoMigrator,
       "beta"
     )
 
-config :farmbot_celery_script, FarmbotCeleryScript.SysCalls, sys_calls: FarmbotOS.SysCalls
+config :farmbot_celery_script, FarmbotCeleryScript.SysCalls,
+  sys_calls: FarmbotOS.SysCalls
 
 config :farmbot_core, FarmbotCore.BotState.FileSystem,
   root_dir: "/tmp/farmbot_state",
   sleep_time: 200
 
-config :farmbot_core, FarmbotCore.FarmwareRuntime, runtime_dir: "/tmp/farmware_runtime"
+config :farmbot_core, FarmbotCore.FarmwareRuntime,
+  runtime_dir: "/tmp/farmware_runtime"
 
 config :ecto, json_library: FarmbotCore.JSON
 
@@ -60,13 +65,16 @@ config :farmbot_core,
     FarmbotCore.Asset.Repo
   ]
 
-config :farmbot_ext, FarmbotExt.API.Preloader, preloader_impl: FarmbotExt.API.Preloader.HTTP
+config :farmbot_ext, FarmbotExt.API.Preloader,
+  preloader_impl: FarmbotExt.API.Preloader.HTTP
 
 config :farmbot, FarmbotOS.FileSystem, data_path: "/tmp/farmbot"
 
-config :farmbot, FarmbotOS.System, system_tasks: FarmbotOS.Platform.Host.SystemTasks
+config :farmbot, FarmbotOS.System,
+  system_tasks: FarmbotOS.Platform.Host.SystemTasks
 
-config :farmbot, FarmbotOS.Configurator, network_layer: FarmbotOS.Configurator.FakeNetworkLayer
+config :farmbot, FarmbotOS.Configurator,
+  network_layer: FarmbotOS.Configurator.FakeNetworkLayer
 
 config :farmbot, FarmbotOS.Platform.Supervisor,
   platform_children: [
diff --git a/farmbot_os/coveralls.json b/farmbot_os/coveralls.json
index 2b2285d8..287eb974 100644
--- a/farmbot_os/coveralls.json
+++ b/farmbot_os/coveralls.json
@@ -1,6 +1,6 @@
 {
   "coverage_options": {
     "treat_no_relevant_lines_as_covered": true,
-    "minimum_coverage": 22
+    "minimum_coverage": 25
   }
 }
diff --git a/farmbot_os/lib/farmbot_os/configurator/router.ex b/farmbot_os/lib/farmbot_os/configurator/router.ex
index 31c20a4e..06e754a3 100644
--- a/farmbot_os/lib/farmbot_os/configurator/router.ex
+++ b/farmbot_os/lib/farmbot_os/configurator/router.ex
@@ -23,7 +23,9 @@ defmodule FarmbotOS.Configurator.Router do
   plug(:match)
   plug(:dispatch)
 
-  @network_layer Application.get_env(:farmbot, FarmbotOS.Configurator)[:network_layer]
+  @network_layer Application.get_env(:farmbot, FarmbotOS.Configurator)[
+                   :network_layer
+                 ]
   @telemetry_layer FarmbotOS.Configurator.DetsTelemetryLayer
 
   # Trigger for captive portal for various operating systems