From 63d03599dd4d5f85745550a97d59d0ed94176662 Mon Sep 17 00:00:00 2001
From: Rick Carlino <rick.carlino@gmail.com>
Date: Thu, 2 Apr 2020 13:24:04 -0500
Subject: [PATCH] Remove unused variables. Add tests for FarmbotCore.Project

---
 ...20180702143518_add_ntp_and_dns_configs.exs | 26 +++++++------------
 farmbot_core/test/project_test.exs            |  9 +++++++
 2 files changed, 19 insertions(+), 16 deletions(-)
 create mode 100644 farmbot_core/test/project_test.exs

diff --git a/farmbot_core/priv/config/migrations/20180702143518_add_ntp_and_dns_configs.exs b/farmbot_core/priv/config/migrations/20180702143518_add_ntp_and_dns_configs.exs
index daaeb9d5..4f9c90aa 100644
--- a/farmbot_core/priv/config/migrations/20180702143518_add_ntp_and_dns_configs.exs
+++ b/farmbot_core/priv/config/migrations/20180702143518_add_ntp_and_dns_configs.exs
@@ -14,22 +14,16 @@ defmodule FarmbotCore.Config.Repo.Migrations.AddNtpAndDnsConfigs do
                       :default_dns_name
                     ]
 
-  @config_error """
-  config :farmbot_core, FarmbotCore.EctoMigrator, [
-    default_ntp_server_1: "0.pool.ntp.org",
-    default_ntp_server_2: "1.pool.ntp.org",
-    default_dns_name: "my.farm.bot"
-  ]
-  """
-
-  if is_nil(@default_ntp_server_1),
-    do: raise(@config_error)
-
-  if is_nil(@default_ntp_server_2),
-    do: raise(@config_error)
-
-  if is_nil(@default_dns_name),
-    do: raise(@config_error)
+  unless @default_ntp_server_1 && @default_ntp_server_2 && @default_dns_name do
+    @config_error """
+    config :farmbot_core, FarmbotCore.EctoMigrator, [
+      default_ntp_server_1: "0.pool.ntp.org",
+      default_ntp_server_2: "1.pool.ntp.org",
+      default_dns_name: "my.farm.bot"
+    ]
+    """
+    Mix.raise(@config_error)
+  end
 
   def change do
     create_settings_config(
diff --git a/farmbot_core/test/project_test.exs b/farmbot_core/test/project_test.exs
new file mode 100644
index 00000000..e5b9da30
--- /dev/null
+++ b/farmbot_core/test/project_test.exs
@@ -0,0 +1,9 @@
+defmodule FarmbotCore.ProjectTest do
+  use ExUnit.Case
+
+  test "arduino_commit" do
+    actual = FarmbotCore.Project.arduino_commit()
+    expected = "0c4b14eb1bec8d466fbb815bfd7ee13b0b2d8c91"
+    assert expected == actual
+  end
+end