diff --git a/.github/PULL_REQUEST_TEMPLATE/car_port.md b/.github/PULL_REQUEST_TEMPLATE/car_port.md index d27546839..4264363ba 100644 --- a/.github/PULL_REQUEST_TEMPLATE/car_port.md +++ b/.github/PULL_REQUEST_TEMPLATE/car_port.md @@ -9,7 +9,7 @@ assignees: '' **Checklist** - [ ] added to README -- [ ] test route added to [test_routes.py](https://github.com/commaai/openpilot/blob/master/selfdrive/test/test_models.py) +- [ ] test route added to [routes.py](https://github.com/commaai/openpilot/blob/master/selfdrive/car/tests/routes.py) - [ ] route with openpilot: - [ ] route with stock system: - [ ] car harness used (if comma doesn't sell it, put N/A): diff --git a/.github/workflows/selfdrive_tests.yaml b/.github/workflows/selfdrive_tests.yaml index 987063700..0083d39c3 100644 --- a/.github/workflows/selfdrive_tests.yaml +++ b/.github/workflows/selfdrive_tests.yaml @@ -245,7 +245,6 @@ jobs: - name: Run unit tests run: | ${{ env.RUN }} "scons -j$(nproc) --test && \ - coverage run selfdrive/test/test_fingerprints.py && \ $UNIT_TEST common && \ $UNIT_TEST opendbc/can && \ $UNIT_TEST selfdrive/boardd && \ @@ -384,7 +383,7 @@ jobs: uses: actions/cache@v2 with: path: /tmp/comma_download_cache - key: car_models-${{ hashFiles('selfdrive/test/test_models.py', 'selfdrive/test/test_routes.py') }}-${{ matrix.job }} + key: car_models-${{ hashFiles('selfdrive/car/tests/test_models.py', 'selfdrive/test/test_routes.py') }}-${{ matrix.job }} - name: Cache scons id: scons-cache # TODO: Change the version to the released version when https://github.com/actions/cache/pull/489 (or 571) is merged. @@ -402,7 +401,7 @@ jobs: - name: Test car models run: | ${{ env.RUN }} "scons -j$(nproc) --test && \ - FILEREADER_CACHE=1 coverage run -m pytest selfdrive/test/test_models.py && \ + FILEREADER_CACHE=1 coverage run -m pytest selfdrive/car/tests/test_models.py && \ coverage xml && \ chmod -R 777 /tmp/comma_download_cache" env: diff --git a/release/files_common b/release/files_common index 30029ba0d..d2d5f14ae 100644 --- a/release/files_common +++ b/release/files_common @@ -341,7 +341,6 @@ selfdrive/thermald/fan_controller.py selfdrive/test/__init__.py selfdrive/test/helpers.py selfdrive/test/setup_device_ci.sh -selfdrive/test/test_fingerprints.py selfdrive/test/test_onroad.py selfdrive/ui/.gitignore diff --git a/selfdrive/car/gm/interface.py b/selfdrive/car/gm/interface.py index 7125b4a91..0fa3ec841 100755 --- a/selfdrive/car/gm/interface.py +++ b/selfdrive/car/gm/interface.py @@ -47,7 +47,7 @@ class CarInterface(CarInterfaceBase): # These cars have been put into dashcam only due to both a lack of users and test coverage. # These cars likely still work fine. Once a user confirms each car works and a test route is - # added to selfdrive/test/test_routes, we can remove it from this list. + # added to selfdrive/car/tests/routes.py, we can remove it from this list. ret.dashcamOnly = candidate in {CAR.CADILLAC_ATS, CAR.HOLDEN_ASTRA, CAR.MALIBU, CAR.BUICK_REGAL} # Presence of a camera on the object bus is ok. diff --git a/selfdrive/car/hyundai/interface.py b/selfdrive/car/hyundai/interface.py index 89308c789..6bb7bc361 100644 --- a/selfdrive/car/hyundai/interface.py +++ b/selfdrive/car/hyundai/interface.py @@ -32,7 +32,7 @@ class CarInterface(CarInterfaceBase): # These cars have been put into dashcam only due to both a lack of users and test coverage. # These cars likely still work fine. Once a user confirms each car works and a test route is - # added to selfdrive/test/test_routes, we can remove it from this list. + # added to selfdrive/car/tests/routes.py, we can remove it from this list. ret.dashcamOnly = candidate in {CAR.KIA_OPTIMA_H, CAR.ELANTRA_GT_I30} ret.steerActuatorDelay = 0.1 # Default delay diff --git a/selfdrive/test/test_routes.py b/selfdrive/car/tests/routes.py similarity index 100% rename from selfdrive/test/test_routes.py rename to selfdrive/car/tests/routes.py diff --git a/selfdrive/test/test_fingerprints.py b/selfdrive/car/tests/test_fingerprints.py similarity index 100% rename from selfdrive/test/test_fingerprints.py rename to selfdrive/car/tests/test_fingerprints.py diff --git a/selfdrive/test/test_models.py b/selfdrive/car/tests/test_models.py similarity index 99% rename from selfdrive/test/test_models.py rename to selfdrive/car/tests/test_models.py index 5afe8b6c1..09d17462e 100755 --- a/selfdrive/test/test_models.py +++ b/selfdrive/car/tests/test_models.py @@ -17,7 +17,7 @@ from selfdrive.car.gm.values import CAR as GM from selfdrive.car.honda.values import CAR as HONDA, HONDA_BOSCH from selfdrive.car.hyundai.values import CAR as HYUNDAI from selfdrive.car.toyota.values import CAR as TOYOTA -from selfdrive.test.test_routes import routes, non_tested_cars +from selfdrive.car.tests.routes import routes, non_tested_cars from selfdrive.test.openpilotci import get_url from tools.lib.logreader import LogReader diff --git a/selfdrive/test/update_ci_routes.py b/selfdrive/test/update_ci_routes.py index 3a392b4b3..fe6d815eb 100755 --- a/selfdrive/test/update_ci_routes.py +++ b/selfdrive/test/update_ci_routes.py @@ -3,7 +3,7 @@ import sys import subprocess from azure.storage.blob import BlockBlobService # pylint: disable=import-error -from selfdrive.test.test_routes import routes as test_car_models_routes +from selfdrive.car.tests.routes import routes as test_car_models_routes from selfdrive.test.process_replay.test_processes import original_segments as replay_segments from xx.chffr.lib import azureutil # pylint: disable=import-error from xx.chffr.lib.storage import _DATA_ACCOUNT_PRODUCTION, _DATA_ACCOUNT_CI, _DATA_BUCKET_PRODUCTION # pylint: disable=import-error