From f719c9a6571f8ce47e305a7ba0fb6b8d05e6f90b Mon Sep 17 00:00:00 2001 From: Willem Melching Date: Fri, 14 Feb 2020 15:51:56 -0800 Subject: [PATCH] remove duplicate addresses from firmware query. Fixes #1088 (#1100) * remove duplicate addresses from firmware query * Update release notes --- RELEASES.md | 1 + selfdrive/car/fw_versions.py | 7 +++++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/RELEASES.md b/RELEASES.md index c21dd2968..6a8211ac5 100644 --- a/RELEASES.md +++ b/RELEASES.md @@ -2,6 +2,7 @@ Version 0.7.3 (2020-xx-xx) ======================== * Support for 2020 Highlander thanks to che220! * Support for 2018 Lexus NX 300h thanks to kengggg! + * Speed up ECU firmware query Version 0.7.2 (2020-02-07) ======================== diff --git a/selfdrive/car/fw_versions.py b/selfdrive/car/fw_versions.py index 5a3dacf32..96b7756c2 100755 --- a/selfdrive/car/fw_versions.py +++ b/selfdrive/car/fw_versions.py @@ -123,9 +123,12 @@ def get_fw_versions(logcan, sendcan, bus, extra=None, timeout=0.1, debug=False, ecu_types[a] = ecu_type if sub_addr is None: - parallel_addrs.append(a) + if a not in parallel_addrs: + parallel_addrs.append(a) else: - addrs.append([a]) + if [a] not in addrs: + addrs.append([a]) + addrs.insert(0, parallel_addrs) fw_versions = {}