From fee2c8683efa2e1cab52c329a2c060d8a0f57504 Mon Sep 17 00:00:00 2001 From: Alfredos-Panagiotis Damkalis Date: Wed, 22 Apr 2020 12:14:20 +0300 Subject: [PATCH] Revert "Remove eslint.failAfterError()" This reverts commit a088e5d03b627e78a37c779deca71fc0123e7833. The commit had been reverted as it was disabling failing the pipeline in CI on errors. Without the eslint.failAfterError(), the exit status of gulp was 0. For solving the issue that the reverted commit was trying to solve, continue running parallel tasks if one of them fails, gulp needs to be run with the flag --continue, however note that this flag allows tasks in series to continue run even if one of them fails. --- gulpfile.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gulpfile.js b/gulpfile.js index 45df7c8..4e5e4a2 100644 --- a/gulpfile.js +++ b/gulpfile.js @@ -16,7 +16,8 @@ gulp.task('js:lint', function() { return gulp.src(lintPathsJS) .pipe(eslint()) - .pipe(eslint.format()); + .pipe(eslint.format()) + .pipe(eslint.failAfterError()); }); gulp.task('css:lint', function() {