From 3731be7adf38bc58ec153c87eb5cc12663e947ae Mon Sep 17 00:00:00 2001 From: "Fabian P. Schmidt" Date: Sat, 30 Nov 2019 18:56:54 +0100 Subject: [PATCH] views: Ignore too-many-ancestors error for rest_framework classes (R0901) Ignoring cases of too many ancestors in API views.py as these are upstream, not much we can do about it. Similar commit in db: librespacefoundation/satnogs/satnogs-db@82713517 Signed-off-by: Fabian P. Schmidt --- .pylintrc | 1 - network/api/views.py | 13 ++++++++----- network/base/views.py | 4 ++-- network/users/views.py | 2 +- 4 files changed, 11 insertions(+), 9 deletions(-) diff --git a/.pylintrc b/.pylintrc index 0c748e4..17558f7 100644 --- a/.pylintrc +++ b/.pylintrc @@ -10,7 +10,6 @@ disable= E1121, R0401, R0801, # needs to remain disabled see https://github.com/PyCQA/pylint/issues/214 - R0901, R0903, R0912, R0913, diff --git a/network/api/views.py b/network/api/views.py index 1f9847d..e612487 100644 --- a/network/api/views.py +++ b/network/api/views.py @@ -13,8 +13,9 @@ from network.base.validators import NegativeElevationError, \ ObservationOverlapError, SinglePassError -class ObservationView(mixins.ListModelMixin, mixins.RetrieveModelMixin, mixins.UpdateModelMixin, - mixins.CreateModelMixin, viewsets.GenericViewSet): +class ObservationView( # pylint: disable=R0901 + mixins.ListModelMixin, mixins.RetrieveModelMixin, mixins.UpdateModelMixin, + mixins.CreateModelMixin, viewsets.GenericViewSet): """SatNOGS Network Observation API view class""" queryset = Observation.objects.prefetch_related('satellite', 'demoddata', 'ground_station') filter_class = filters.ObservationViewFilter @@ -87,7 +88,8 @@ class ObservationView(mixins.ListModelMixin, mixins.RetrieveModelMixin, mixins.U return Response(status=status.HTTP_200_OK) -class StationView(mixins.ListModelMixin, mixins.RetrieveModelMixin, viewsets.GenericViewSet): +class StationView( # pylint: disable=R0901 + mixins.ListModelMixin, mixins.RetrieveModelMixin, viewsets.GenericViewSet): """SatNOGS Network Station API view class""" queryset = Station.objects.prefetch_related('antenna', 'observations') serializer_class = serializers.StationSerializer @@ -95,7 +97,8 @@ class StationView(mixins.ListModelMixin, mixins.RetrieveModelMixin, viewsets.Gen pagination_class = pagination.LinkedHeaderPageNumberPagination -class TransmitterView(mixins.ListModelMixin, mixins.RetrieveModelMixin, viewsets.GenericViewSet): +class TransmitterView( # pylint: disable=R0901 + mixins.ListModelMixin, mixins.RetrieveModelMixin, viewsets.GenericViewSet): """SatNOGS Network Transmitter API view class""" queryset = Transmitter.objects.all().order_by('uuid') serializer_class = serializers.TransmitterSerializer @@ -103,7 +106,7 @@ class TransmitterView(mixins.ListModelMixin, mixins.RetrieveModelMixin, viewsets pagination_class = pagination.LinkedHeaderPageNumberPagination -class JobView(viewsets.ReadOnlyModelViewSet): +class JobView(viewsets.ReadOnlyModelViewSet): # pylint: disable=R0901 """SatNOGS Network Job API view class""" queryset = Observation.objects.filter(payload='') serializer_class = serializers.JobSerializer diff --git a/network/base/views.py b/network/base/views.py index cb7ff80..a6e3871 100644 --- a/network/base/views.py +++ b/network/base/views.py @@ -54,7 +54,7 @@ class StationSerializer(serializers.ModelSerializer): return None -class StationAllView(viewsets.ReadOnlyModelViewSet): +class StationAllView(viewsets.ReadOnlyModelViewSet): # pylint: disable=R0901 """Station View of all non offline stations""" queryset = Station.objects.exclude(status=0) serializer_class = StationSerializer @@ -88,7 +88,7 @@ def settings_site(request): return render(request, 'base/settings_site.html') -class ObservationListView(ListView): +class ObservationListView(ListView): # pylint: disable=R0901 """ Displays a list of observations with pagination """ diff --git a/network/users/views.py b/network/users/views.py index c2a1546..a5e1658 100644 --- a/network/users/views.py +++ b/network/users/views.py @@ -21,7 +21,7 @@ class UserRedirectView(LoginRequiredMixin, RedirectView): return reverse("users:view_user", kwargs={"username": self.request.user.username}) -class UserUpdateView(LoginRequiredMixin, UpdateView): +class UserUpdateView(LoginRequiredMixin, UpdateView): # pylint: disable=R0901 """View for user update""" form_class = UserForm