From 4c9cd6666154515b5d083f77f45840d3187e03a2 Mon Sep 17 00:00:00 2001 From: "Fabian P. Schmidt" Date: Thu, 2 Jan 2020 22:38:48 +0100 Subject: [PATCH] models/Observation: Improve requests exception handling (W0703) Fixes a broad-except (W0703) pylint error. Signed-off-by: Fabian P. Schmidt --- network/base/models.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/network/base/models.py b/network/base/models.py index 157965b..29ef1dd 100644 --- a/network/base/models.py +++ b/network/base/models.py @@ -515,9 +515,11 @@ class Observation(models.Model): if self.archive_url: try: request = requests.get(self.archive_url, allow_redirects=False) + request.raise_for_status() + url = request.headers['Location'] return url - except Exception as error: + except requests.exceptions.RequestException as error: logger = logging.getLogger(__name__) logger.warning("Error in request to '%s'. Error: %s", self.archive_url, error) return ''