From 8df2c360756b90d5160e96cf1d7ea2616fce9b5e Mon Sep 17 00:00:00 2001 From: "Fabian P. Schmidt" Date: Sun, 1 Dec 2019 20:40:17 +0100 Subject: [PATCH] views/prediction_windows: Initialize variables as late as possible This should improves the readability of the code. --- network/base/views.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/network/base/views.py b/network/base/views.py index 679f013..c6b6fda 100644 --- a/network/base/views.py +++ b/network/base/views.py @@ -383,8 +383,6 @@ def prediction_windows(request): data = [{'error': error.message}] return JsonResponse(data, safe=False) - data = [] - scheduled_obs_queryset = Observation.objects.filter(end__gt=now()) stations = Station.objects.filter(status__gt=0).prefetch_related( Prefetch('observations', queryset=scheduled_obs_queryset, to_attr='scheduled_obs'), @@ -399,8 +397,10 @@ def prediction_windows(request): data = [{'error': 'Stations are offline or they don\'t exist.'}] return JsonResponse(data, safe=False) - passes_found = defaultdict(list) available_stations = get_available_stations(stations, downlink, request.user) + + data = [] + passes_found = defaultdict(list) for station in available_stations: station_passes, station_windows = predict_available_observation_windows( station, min_horizon, overlapped, tle, start, end