From bda0580dbebecdf61eadba2f45fd2ce444124b71 Mon Sep 17 00:00:00 2001 From: "Fabian P. Schmidt" Date: Tue, 31 Dec 2019 03:11:29 +0100 Subject: [PATCH] utils/community_get_discussion_details: Add a sane request timeout Signed-off-by: Fabian P. Schmidt --- network/base/utils.py | 4 +++- network/settings.py | 4 ++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/network/base/utils.py b/network/base/utils.py index 959419b..255ea61 100644 --- a/network/base/utils.py +++ b/network/base/utils.py @@ -131,7 +131,9 @@ def community_get_discussion_details( norad_cat_id) try: - response = requests.get('{}.json'.format(discussion_slug)) + response = requests.get( + '{}.json'.format(discussion_slug), timeout=settings.COMMUNITY_TIMEOUT + ) response.raise_for_status() has_comments = (response.status_code == 200) except RequestException: diff --git a/network/settings.py b/network/settings.py index 663306d..3865893 100644 --- a/network/settings.py +++ b/network/settings.py @@ -349,6 +349,10 @@ OBS_NO_RESULTS_IGNORE_TIME = config('OBS_NO_RESULTS_IGNORE_TIME', default=1800, # DB API DB_API_ENDPOINT = config('DB_API_ENDPOINT', default='https://db.satnogs.org/api/') +# Timeout in seconds for the community forum +# (used e.g. when checking for the existance of certain threads) +COMMUNITY_TIMEOUT = config('COMMUNITY_TIMEOUT', default=2.0, cast=float) + # ListView pagination ITEMS_PER_PAGE = config('ITEMS_PER_PAGE', default=25, cast=int)