From f91e9adbb9443f12af31e678c32e7bb926f2486f Mon Sep 17 00:00:00 2001 From: "Fabian P. Schmidt" Date: Sat, 30 Nov 2019 06:56:57 +0100 Subject: [PATCH] views/observation_new_post: Improve code style (R0915) This commit should improve the code readability by removing variables which were only used once. Fixes a too-many-statements (R0915) pylint error. Signed-off-by: Fabian P. Schmidt --- network/base/views.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/network/base/views.py b/network/base/views.py index 1483aae..e8eb5d6 100644 --- a/network/base/views.py +++ b/network/base/views.py @@ -237,14 +237,15 @@ def observation_new_post(request): if formset.is_valid(): new_observations = [] for observation_data in formset.cleaned_data: - station = observation_data['ground_station'] - start = observation_data['start'] - end = observation_data['end'] transmitter_uuid = observation_data['transmitter_uuid'] transmitter = formset.transmitters[transmitter_uuid] - author = request.user + observation = create_new_observation( - station=station, transmitter=transmitter, start=start, end=end, author=author + station=observation_data['ground_station'], + transmitter=transmitter, + start=observation_data['start'], + end=observation_data['end'], + author=request.user ) new_observations.append(observation)