redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

iommu: Fix IOMMU debugfs fallout 

A change made in the final version of IOMMU debugfs support replaced the
public function iommu_debugfs_new_driver_dir() by the public dentry
iommu_debugfs_dir in <linux/iommu.h>, but forgot to update both the
implementation in iommu-debugfs.c, and the patch description.

Fix this by exporting iommu_debugfs_dir, and removing the reference to
and implementation of iommu_debugfs_new_driver_dir().

Fixes: bad614b242 ("iommu: Enable debugfs exposure of IOMMU driver internals")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Gary R Hook <gary.hook@amd.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
hifive-unleashed-5.1
Geert Uytterhoeven 2019-02-20 14:05:05 +01:00 committed by Joerg Roedel
parent a7055d572c
commit 18b3af4492
1 changed files with 4 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
drivers/iommu/iommu-debugfs.c
View File

@ -12,6 +12,7 @@
#include <linux/debugfs.h> #include <linux/debugfs.h>
struct dentry *iommu_debugfs_dir; struct dentry *iommu_debugfs_dir;
EXPORT_SYMBOL_GPL(iommu_debugfs_dir);
/** /**
* iommu_debugfs_setup - create the top-level iommu directory in debugfs * iommu_debugfs_setup - create the top-level iommu directory in debugfs
@ -23,9 +24,9 @@ struct dentry *iommu_debugfs_dir;
* Emit a strong warning at boot time to indicate that this feature is * Emit a strong warning at boot time to indicate that this feature is
* enabled. * enabled.
* *
* This function is called from iommu_init; drivers may then call * This function is called from iommu_init; drivers may then use
* iommu_debugfs_new_driver_dir() to instantiate a vendor-specific * iommu_debugfs_dir to instantiate a vendor-specific directory to be used
* directory to be used to expose internal data. * to expose internal data.
*/ */
void iommu_debugfs_setup(void) void iommu_debugfs_setup(void)
{ {
@ -48,19 +49,3 @@ void iommu_debugfs_setup(void)
pr_warn("*************************************************************\n"); pr_warn("*************************************************************\n");
} }
} }
/**
* iommu_debugfs_new_driver_dir - create a vendor directory under debugfs/iommu
* @vendor: name of the vendor-specific subdirectory to create
*
* This function is called by an IOMMU driver to create the top-level debugfs
* directory for that driver.
*
* Return: upon success, a pointer to the dentry for the new directory.
* NULL in case of failure.
*/
struct dentry *iommu_debugfs_new_driver_dir(const char *vendor)
{
return debugfs_create_dir(vendor, iommu_debugfs_dir);
}
EXPORT_SYMBOL_GPL(iommu_debugfs_new_driver_dir);