redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

staging: r8822be: fix memory leak of eeprom_map on error exit return 

A memory leak of eeprom_map occurs if the call to halmac_eeprom_parser_88xx
fails. Fix this by kfree'ing it before returning.

Detected by CoverityScan, CID#1454569 ("Resource leak")
Fixes: 938a0447f0 ("staging: r8822be: Add code for halmac sub-driver")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
hifive-unleashed-5.1
Colin Ian King 2017-08-23 15:34:33 +01:00 committed by Greg Kroah-Hartman
parent faff950c80
commit 2ffabf50bd
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/staging/rtlwifi/halmac/halmac_88xx/halmac_api_88xx.c
View File

@ -1950,8 +1950,10 @@ halmac_dump_logical_efuse_map_88xx(struct halmac_adapter *halmac_adapter,
if (halmac_eeprom_parser_88xx(halmac_adapter,
halmac_adapter->hal_efuse_map,
eeprom_map) != HALMAC_RET_SUCCESS)
eeprom_map) != HALMAC_RET_SUCCESS) {
kfree(eeprom_map);
return HALMAC_RET_EEPROM_PARSING_FAIL;
}
PLATFORM_EVENT_INDICATION(
driver_adapter, HALMAC_FEATURE_DUMP_LOGICAL_EFUSE,