redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

block: fix elevator_get_by_features() 

The lookup logic is broken - 'e' will never be NULL, even if the
list is empty. Maintain lookup hit in a separate variable instead.

Fixes: a0958ba7fc ("block: Improve default elevator selection")
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
alistair/sunxi64-5.4-dsi
Jens Axboe 2019-09-06 07:02:31 -06:00
parent ebddd2a153
commit a26142559c
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
block/elevator.c
View File

@ -668,22 +668,23 @@ static struct elevator_type *elevator_get_default(struct request_queue *q)
*/ */
static struct elevator_type *elevator_get_by_features(struct request_queue *q) static struct elevator_type *elevator_get_by_features(struct request_queue *q)
{ {
struct elevator_type *e; struct elevator_type *e, *found = NULL;
spin_lock(&elv_list_lock); spin_lock(&elv_list_lock);
list_for_each_entry(e, &elv_list, list) { list_for_each_entry(e, &elv_list, list) {
if (elv_support_features(e->elevator_features, if (elv_support_features(e->elevator_features,
q->required_elevator_features)) q->required_elevator_features)) {
found = e;
break; break;
}
} }
if (e && !try_module_get(e->elevator_owner)) if (found && !try_module_get(found->elevator_owner))
e = NULL; found = NULL;
spin_unlock(&elv_list_lock); spin_unlock(&elv_list_lock);
return found;
return e;
} }
/* /*