Smack: prevent underflow in smk_set_cipso()
[ Upstream commit5.4-rM2-2.2.x-imx-squashed42a2df3e82
] We have an upper bound on "maplevel" but forgot to check for negative values. Fixes:e114e47377
("Smack: Simplified Mandatory Access Control Kernel") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Casey Schaufler <casey@schaufler-ca.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
parent
674992659a
commit
b2b8438ed8
|
@ -884,7 +884,7 @@ static ssize_t smk_set_cipso(struct file *file, const char __user *buf,
|
||||||
}
|
}
|
||||||
|
|
||||||
ret = sscanf(rule, "%d", &maplevel);
|
ret = sscanf(rule, "%d", &maplevel);
|
||||||
if (ret != 1 || maplevel > SMACK_CIPSO_MAXLEVEL)
|
if (ret != 1 || maplevel < 0 || maplevel > SMACK_CIPSO_MAXLEVEL)
|
||||||
goto out;
|
goto out;
|
||||||
|
|
||||||
rule += SMK_DIGITLEN;
|
rule += SMK_DIGITLEN;
|
||||||
|
|
Loading…
Reference in New Issue