redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

staging: comedi: adv_pci1723: remove board reset during (*detach)

Browse source 
The pci1723_reset() function simply resets all the analog output channels
to 0V and a +/-10V range. This really isn't necessary when detaching the
driver.

Remove the board reset and just use comedi_pci_detach() directly for the
(*detach).

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
H Hartley Sweeten 2014-11-21 14:22:29 -07:00 committed by Greg Kroah-Hartman
parent 24001039a4
commit b5ed2b2843
1 changed files with 1 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
drivers/staging/comedi/drivers/adv_pci1723.c
View file

@ -259,18 +259,11 @@ static int pci1723_auto_attach(struct comedi_device *dev,
return 0;
}
static void pci1723_detach(struct comedi_device *dev)
{
if (dev->iobase)
pci1723_reset(dev);
comedi_pci_detach(dev);
}
static struct comedi_driver adv_pci1723_driver = {
.driver_name = "adv_pci1723",
.module = THIS_MODULE,
.auto_attach = pci1723_auto_attach,
.detach = pci1723_detach,
.detach = comedi_pci_detach,
};
static int adv_pci1723_pci_probe(struct pci_dev *dev,