usb: cdns3: ep0: add spinlock for cdns3_check_new_setup
commit5.4-rM2-2.2.x-imx-squashed2587a029fa
upstream. The other thread may access other endpoints when the cdns3_check_new_setup is handling, add spinlock to protect it. Cc: <stable@vger.kernel.org> Fixes:7733f6c32e
("usb: cdns3: Add Cadence USB3 DRD Driver") Reviewed-by: Pawel Laszczak <pawell@cadence.com> Signed-off-by: Peter Chen <peter.chen@nxp.com> Signed-off-by: Felipe Balbi <balbi@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
parent
a0668653be
commit
be8df02707
|
@ -712,15 +712,17 @@ static int cdns3_gadget_ep0_queue(struct usb_ep *ep,
|
||||||
int ret = 0;
|
int ret = 0;
|
||||||
u8 zlp = 0;
|
u8 zlp = 0;
|
||||||
|
|
||||||
|
spin_lock_irqsave(&priv_dev->lock, flags);
|
||||||
trace_cdns3_ep0_queue(priv_dev, request);
|
trace_cdns3_ep0_queue(priv_dev, request);
|
||||||
|
|
||||||
/* cancel the request if controller receive new SETUP packet. */
|
/* cancel the request if controller receive new SETUP packet. */
|
||||||
if (cdns3_check_new_setup(priv_dev))
|
if (cdns3_check_new_setup(priv_dev)) {
|
||||||
|
spin_unlock_irqrestore(&priv_dev->lock, flags);
|
||||||
return -ECONNRESET;
|
return -ECONNRESET;
|
||||||
|
}
|
||||||
|
|
||||||
/* send STATUS stage. Should be called only for SET_CONFIGURATION */
|
/* send STATUS stage. Should be called only for SET_CONFIGURATION */
|
||||||
if (priv_dev->ep0_stage == CDNS3_STATUS_STAGE) {
|
if (priv_dev->ep0_stage == CDNS3_STATUS_STAGE) {
|
||||||
spin_lock_irqsave(&priv_dev->lock, flags);
|
|
||||||
cdns3_select_ep(priv_dev, 0x00);
|
cdns3_select_ep(priv_dev, 0x00);
|
||||||
|
|
||||||
erdy_sent = !priv_dev->hw_configured_flag;
|
erdy_sent = !priv_dev->hw_configured_flag;
|
||||||
|
@ -745,7 +747,6 @@ static int cdns3_gadget_ep0_queue(struct usb_ep *ep,
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
spin_lock_irqsave(&priv_dev->lock, flags);
|
|
||||||
if (!list_empty(&priv_ep->pending_req_list)) {
|
if (!list_empty(&priv_ep->pending_req_list)) {
|
||||||
dev_err(priv_dev->dev,
|
dev_err(priv_dev->dev,
|
||||||
"can't handle multiple requests for ep0\n");
|
"can't handle multiple requests for ep0\n");
|
||||||
|
|
Loading…
Reference in New Issue