media: siano: fix memory leak of debugfs members in smsdvb_hotplug
[ Upstream commit5.4-rM2-2.2.x-imx-squashedabf287eeff
] When dvb_create_media_graph fails, the debugfs kept inside client should be released. However, the current implementation does not release them. Fix this by adding a new goto label to call smsdvb_debugfs_release. Fixes:0d3ab8410d
("[media] dvb core: must check dvb_create_media_graph()") Signed-off-by: Keita Suzuki <keitasuzuki.park@sslab.ics.keio.ac.jp> Signed-off-by: Sean Young <sean@mess.org> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
parent
6b93d6c5a8
commit
c14a740743
|
@ -1169,12 +1169,15 @@ static int smsdvb_hotplug(struct smscore_device_t *coredev,
|
||||||
rc = dvb_create_media_graph(&client->adapter, true);
|
rc = dvb_create_media_graph(&client->adapter, true);
|
||||||
if (rc < 0) {
|
if (rc < 0) {
|
||||||
pr_err("dvb_create_media_graph failed %d\n", rc);
|
pr_err("dvb_create_media_graph failed %d\n", rc);
|
||||||
goto client_error;
|
goto media_graph_error;
|
||||||
}
|
}
|
||||||
|
|
||||||
pr_info("DVB interface registered.\n");
|
pr_info("DVB interface registered.\n");
|
||||||
return 0;
|
return 0;
|
||||||
|
|
||||||
|
media_graph_error:
|
||||||
|
smsdvb_debugfs_release(client);
|
||||||
|
|
||||||
client_error:
|
client_error:
|
||||||
dvb_unregister_frontend(&client->frontend);
|
dvb_unregister_frontend(&client->frontend);
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue