redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

MLK-23618-10: ASoC: fsl_esai: Don't bind clock with regmap

Browse source 
The call flow:
devm_regmap_init_mmio_clk
   - clk_prepare()
      - clk_pm_runtime_get()

Cause the power domain of lpcg clock always be enabled.
which impact the power consumption.

So we can't bind clock with regmap, then explicitly enable
clock when using. As we already enable all clock in
pm_runtime_resume, so only need to enable clock in probe.

Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
This commit is contained in:
Shengjiu Wang 2020-03-17 18:27:16 +08:00
parent c2641e1974
commit d91068f322
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
sound/soc/fsl/fsl_esai.c
View file

@ -1016,7 +1016,7 @@ static int fsl_esai_probe(struct platform_device *pdev)
return PTR_ERR(regs); return PTR_ERR(regs);
esai_priv->regmap = devm_regmap_init_mmio_clk(&pdev->dev, esai_priv->regmap = devm_regmap_init_mmio_clk(&pdev->dev,
"core", regs, &fsl_esai_regmap_config); NULL, regs, &fsl_esai_regmap_config);
if (IS_ERR(esai_priv->regmap)) { if (IS_ERR(esai_priv->regmap)) {
dev_err(&pdev->dev, "failed to init regmap: %ld\n", dev_err(&pdev->dev, "failed to init regmap: %ld\n",
PTR_ERR(esai_priv->regmap)); PTR_ERR(esai_priv->regmap));
@ -1106,6 +1106,11 @@ static int fsl_esai_probe(struct platform_device *pdev)
dev_set_drvdata(&pdev->dev, esai_priv); dev_set_drvdata(&pdev->dev, esai_priv);
spin_lock_init(&esai_priv->lock); spin_lock_init(&esai_priv->lock);
ret = clk_prepare_enable(esai_priv->coreclk);
if (ret)
return ret;
ret = fsl_esai_hw_init(esai_priv); ret = fsl_esai_hw_init(esai_priv);
if (ret) if (ret)
return ret; return ret;
@ -1119,6 +1124,8 @@ static int fsl_esai_probe(struct platform_device *pdev)
regmap_write(esai_priv->regmap, REG_ESAI_RSMA, 0); regmap_write(esai_priv->regmap, REG_ESAI_RSMA, 0);
regmap_write(esai_priv->regmap, REG_ESAI_RSMB, 0); regmap_write(esai_priv->regmap, REG_ESAI_RSMB, 0);
clk_disable_unprepare(esai_priv->coreclk);
ret = devm_snd_soc_register_component(&pdev->dev, &fsl_esai_component, ret = devm_snd_soc_register_component(&pdev->dev, &fsl_esai_component,
&fsl_esai_dai, 1); &fsl_esai_dai, 1);
if (ret) { if (ret) {