Enke Chen f7020c437e tcp: fix TCP_USER_TIMEOUT with zero window ... commit 9d9b1ee0b2 upstream. The TCP session does not terminate with TCP_USER_TIMEOUT when data remain untransmitted due to zero window. The number of unanswered zero-window probes (tcp_probes_out) is reset to zero with incoming acks irrespective of the window size, as described in tcp_probe_timer(): RFC 1122 4.2.2.17 requires the sender to stay open indefinitely as long as the receiver continues to respond probes. We support this by default and reset icsk_probes_out with incoming ACKs. This counter, however, is the wrong one to be used in calculating the duration that the window remains closed and data remain untransmitted. Thanks to Jonathan Maxwell <jmaxwell37@gmail.com> for diagnosing the actual issue. In this patch a new timestamp is introduced for the socket in order to track the elapsed time for the zero-window probes that have not been answered with any non-zero window ack. Fixes: 9721e709fa ("tcp: simplify window probe aborting on USER_TIMEOUT") Reported-by: William McCall <william.mccall@gmail.com> Co-developed-by: Neal Cardwell <ncardwell@google.com> Signed-off-by: Neal Cardwell <ncardwell@google.com> Signed-off-by: Enke Chen <enchen@paloaltonetworks.com> Reviewed-by: Yuchung Cheng <ycheng@google.com> Reviewed-by: Eric Dumazet <edumazet@google.com> Link: https://lore.kernel.org/r/20210115223058.GA39267@localhost.localdomain Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2021-01-27 11:47:55 +01:00
..
6lowpan	6lowpan: no need to check return value of debugfs_create functions	2019-07-06 12:50:01 +02:00
9p	net: 9p: initialize sun_server.sun_path to have addr's value only when addr is valid	2020-11-05 11:43:20 +01:00
802	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
8021q	net: vlan: avoid leaks on register_vlan_dev() failures	2021-01-17 14:05:31 +01:00
appletalk	appletalk: Fix atalk_proc_init() return path	2020-08-11 15:33:40 +02:00
atm	atm: fix a memory leak of vcc->user_back	2020-10-01 13:17:58 +02:00
ax25	AX.25: Prevent integer overflows in connect and sendmsg	2020-07-31 18:39:31 +02:00
batman-adv	batman-adv: set .owner to THIS_MODULE	2020-12-02 08:49:50 +01:00
bluetooth	Bluetooth: Fix null pointer dereference in hci_event_packet()	2020-12-30 11:51:05 +01:00
bpf	bpf/flow_dissector: support flags in BPF_PROG_TEST_RUN	2019-07-25 18:00:41 -07:00
bpfilter	net/bpfilter: remove superfluous testing message	2020-04-21 09:04:53 +02:00
bridge	bridge: Fix a deadlock when enabling multicast snooping	2020-12-21 13:27:04 +01:00
caif	net: use skb_queue_empty_lockless() in poll() handlers	2019-10-28 13:33:41 -07:00
can	can: af_can: can_rx_unregister(): remove WARN() statement from list operation sanity check	2020-12-11 13:23:32 +01:00
ceph	libceph: clear con->out_msg on Policy::stateful_server faults	2020-11-05 11:43:34 +01:00
core	net: Disable NETIF_F_HW_TLS_RX when RXCSUM is disabled	2021-01-27 11:47:54 +01:00
dcb	net: dcb: Accept RTM_GETDCB messages carrying set-like DCB commands	2021-01-23 15:57:59 +01:00
dccp	dccp: Fix possible memleak in dccp_init and dccp_fini	2020-06-17 16:40:32 +02:00
decnet	net: add bool confirm_neigh parameter for dst_ops.update_pmtu	2020-01-04 19:18:58 +01:00
dns_resolver	KEYS: Don't write out to userspace while holding key semaphore	2020-04-23 10:36:45 +02:00
dsa	dsa: Allow forwarding of redirected IGMP traffic	2020-09-23 12:40:33 +02:00
ethernet	net: add annotations on hh->hh_len lockless accesses	2020-01-09 10:20:06 +01:00
hsr	hsr: check protocol version in hsr_newlink()	2020-04-21 09:04:44 +02:00
ieee802154	nl802154: add missing attribute validation for dev_type	2020-03-18 07:17:44 +01:00
ife	net: Fix Kconfig indentation	2019-09-26 08:56:17 +02:00
ipv4	tcp: fix TCP_USER_TIMEOUT with zero window	2021-01-27 11:47:55 +01:00
ipv6	ipv6: set multicast flag on the multicast route	2021-01-27 11:47:54 +01:00
iucv	net/af_iucv: set correct sk_protocol for child sockets	2020-12-08 10:40:23 +01:00
kcm	kcm: disable preemption in kcm_parse_func_strparser()	2019-09-27 10:27:14 +02:00
key	af_key: pfkey_dump needs parameter validation	2020-09-26 18:03:10 +02:00
l2tp	l2tp: remove skb_dst_set() from l2tp_xmit_skb()	2020-07-22 09:32:47 +02:00
l3mdev	ipv6: convert major tx path to use RT6_LOOKUP_F_DST_NOREF	2019-06-23 13:24:17 -07:00
lapb	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-06-17 20:20:36 -07:00
llc	net: silence data-races on sk_backlog.tail	2020-10-01 13:17:15 +02:00
mac80211	mac80211: check if atf has been disabled in __ieee80211_schedule_txq	2021-01-23 15:58:00 +01:00
mac802154	mac802154: tx: fix use-after-free	2020-10-01 13:18:17 +02:00
mpls	net: ipv6_stub: use ip6_dst_lookup_flow instead of ip6_dst_lookup	2019-12-18 16:08:42 +01:00
ncsi	net/ncsi: Use real net-device for response handler	2021-01-12 20:16:13 +01:00
netfilter	netfilter: nft_compat: remove flush counter optimization	2021-01-19 18:26:19 +01:00
netlabel	netlabel: fix an uninitialized warning in netlbl_unlabel_staticlist()	2020-11-24 13:28:57 +01:00
netlink	genetlink: remove genl_bind	2020-07-22 09:32:46 +02:00
netrom	net: netrom: Fix potential nr_neigh refcnt leak in nr_add_node	2020-04-29 16:33:08 +02:00
nfc	nfc: Ensure presence of NFC_ATTR_FIRMWARE_NAME attribute in nfc_genl_fw_download()	2020-10-29 09:57:26 +01:00
nsh	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
openvswitch	net: openvswitch: ensure LSE is pullable before reading it	2020-12-08 10:40:27 +01:00
packet	net/packet: fix overflow in tpacket_rcv	2020-09-09 19:12:29 +02:00
phonet	net: use skb_queue_empty_lockless() in poll() handlers	2019-10-28 13:33:41 -07:00
psample	net: psample: fix skb_over_panic	2019-12-04 22:30:54 +01:00
qrtr	net: qrtr: check skb_put_padto() return value	2020-09-26 18:03:15 +02:00
rds	rds: Prevent kernel-infoleak in rds_notify_queue_get()	2020-08-05 09:59:44 +02:00
rfkill	rfkill: Fix use-after-free in rfkill_resume()	2020-11-24 13:29:05 +01:00
rose	rose: Fix Null pointer dereference in rose_send_frame()	2020-12-08 10:40:23 +01:00
rxrpc	rxrpc: Fix handling of an unsupported token type in rxrpc_read()	2021-01-23 15:58:00 +01:00
sched	net_sched: reject silly cell_log in qdisc_get_rtab()	2021-01-27 11:47:54 +01:00
sctp	net, sctp, filter: remap copy_from_user failure error	2021-01-23 15:58:00 +01:00
smc	net/smc: fix direct access to ib_gid_addr->ndev in smc_ib_determine_gid()	2020-11-24 13:28:58 +01:00
strparser	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-06-22 08:59:24 -04:00
sunrpc	net: sunrpc: interpret the return value of kstrtou32 correctly	2021-01-19 18:26:18 +01:00
switchdev	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
tipc	tipc: fix NULL deref in tipc_link_xmit()	2021-01-23 15:58:00 +01:00
tls	net/tls: Protect from calling tls_dev_del for TLS RX twice	2020-12-08 10:40:23 +01:00
unix	skbuff: fix a data race in skb_queue_len()	2020-10-01 13:17:31 +02:00
vmw_vsock	vsock: use ns_capable_noaudit() on socket create	2020-11-10 12:37:30 +01:00
wimax	wimax: no need to check return value of debugfs_create functions	2019-08-10 15:25:47 -07:00
wireless	cfg80211: initialize rekey_data	2020-12-30 11:51:29 +01:00
x25	net/x25: prevent a couple of overflows	2020-12-08 10:40:26 +01:00
xdp	xsk: Replace datagram_poll by sock_poll_wait	2020-12-30 11:50:53 +01:00
xfrm	net: xfrm: fix a race condition during allocing spi	2020-11-18 19:20:17 +01:00
Kconfig	net: Fix CONFIG_NET_CLS_ACT=n and CONFIG_NFT_FWD_NETDEV={y, m} build	2020-04-01 11:02:18 +02:00
Makefile	net: split out functions related to registering inflight socket files	2019-02-28 08:24:23 -07:00
compat.c	net/compat: Add missing sock updates for SCM_RIGHTS	2020-08-21 13:05:25 +02:00
socket.c	net: Set fput_needed iff FDPUT_FPUT is set	2020-08-19 08:16:22 +02:00
sysctl_net.c	treewide: Add SPDX license identifier for missed files	2019-05-21 10:50:45 +02:00