![Gabor Juhos](/assets/img/avatar_default.png)
The current ar724x_pci_{read,write} functions are broken. Due to that, pci_read_config_byte returns with bogus values, and pci_write_config_{byte,word} unconditionally clears the accessed PCI configuration registers instead of changing the value of them. The patch fixes the broken functions, thus the PCI configuration space can be accessed correctly. Signed-off-by: Gabor Juhos <juhosg@openwrt.org> Cc: linux-mips@linux-mips.org Patchwork: https://patchwork.linux-mips.org/patch/3493/ Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
144 lines
3 KiB
C
144 lines
3 KiB
C
/*
|
|
* Atheros 724x PCI support
|
|
*
|
|
* Copyright (C) 2011 René Bolldorf <xsecute@googlemail.com>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify it
|
|
* under the terms of the GNU General Public License version 2 as published
|
|
* by the Free Software Foundation.
|
|
*/
|
|
|
|
#include <linux/pci.h>
|
|
#include <asm/mach-ath79/pci.h>
|
|
|
|
#define AR724X_PCI_CFG_BASE 0x14000000
|
|
#define AR724X_PCI_CFG_SIZE 0x1000
|
|
#define AR724X_PCI_MEM_BASE 0x10000000
|
|
#define AR724X_PCI_MEM_SIZE 0x08000000
|
|
|
|
static DEFINE_SPINLOCK(ar724x_pci_lock);
|
|
static void __iomem *ar724x_pci_devcfg_base;
|
|
|
|
static int ar724x_pci_read(struct pci_bus *bus, unsigned int devfn, int where,
|
|
int size, uint32_t *value)
|
|
{
|
|
unsigned long flags;
|
|
void __iomem *base;
|
|
u32 data;
|
|
|
|
if (devfn)
|
|
return PCIBIOS_DEVICE_NOT_FOUND;
|
|
|
|
base = ar724x_pci_devcfg_base;
|
|
|
|
spin_lock_irqsave(&ar724x_pci_lock, flags);
|
|
data = __raw_readl(base + (where & ~3));
|
|
|
|
switch (size) {
|
|
case 1:
|
|
if (where & 1)
|
|
data >>= 8;
|
|
if (where & 2)
|
|
data >>= 16;
|
|
data &= 0xff;
|
|
break;
|
|
case 2:
|
|
if (where & 2)
|
|
data >>= 16;
|
|
data &= 0xffff;
|
|
break;
|
|
case 4:
|
|
break;
|
|
default:
|
|
spin_unlock_irqrestore(&ar724x_pci_lock, flags);
|
|
|
|
return PCIBIOS_BAD_REGISTER_NUMBER;
|
|
}
|
|
|
|
spin_unlock_irqrestore(&ar724x_pci_lock, flags);
|
|
*value = data;
|
|
|
|
return PCIBIOS_SUCCESSFUL;
|
|
}
|
|
|
|
static int ar724x_pci_write(struct pci_bus *bus, unsigned int devfn, int where,
|
|
int size, uint32_t value)
|
|
{
|
|
unsigned long flags;
|
|
void __iomem *base;
|
|
u32 data;
|
|
int s;
|
|
|
|
if (devfn)
|
|
return PCIBIOS_DEVICE_NOT_FOUND;
|
|
|
|
base = ar724x_pci_devcfg_base;
|
|
|
|
spin_lock_irqsave(&ar724x_pci_lock, flags);
|
|
data = __raw_readl(base + (where & ~3));
|
|
|
|
switch (size) {
|
|
case 1:
|
|
s = ((where & 3) * 8);
|
|
data &= ~(0xff << s);
|
|
data |= ((value & 0xff) << s);
|
|
break;
|
|
case 2:
|
|
s = ((where & 2) * 8);
|
|
data &= ~(0xffff << s);
|
|
data |= ((value & 0xffff) << s);
|
|
break;
|
|
case 4:
|
|
data = value;
|
|
break;
|
|
default:
|
|
spin_unlock_irqrestore(&ar724x_pci_lock, flags);
|
|
|
|
return PCIBIOS_BAD_REGISTER_NUMBER;
|
|
}
|
|
|
|
__raw_writel(data, base + (where & ~3));
|
|
/* flush write */
|
|
__raw_readl(base + (where & ~3));
|
|
spin_unlock_irqrestore(&ar724x_pci_lock, flags);
|
|
|
|
return PCIBIOS_SUCCESSFUL;
|
|
}
|
|
|
|
static struct pci_ops ar724x_pci_ops = {
|
|
.read = ar724x_pci_read,
|
|
.write = ar724x_pci_write,
|
|
};
|
|
|
|
static struct resource ar724x_io_resource = {
|
|
.name = "PCI IO space",
|
|
.start = 0,
|
|
.end = 0,
|
|
.flags = IORESOURCE_IO,
|
|
};
|
|
|
|
static struct resource ar724x_mem_resource = {
|
|
.name = "PCI memory space",
|
|
.start = AR724X_PCI_MEM_BASE,
|
|
.end = AR724X_PCI_MEM_BASE + AR724X_PCI_MEM_SIZE - 1,
|
|
.flags = IORESOURCE_MEM,
|
|
};
|
|
|
|
static struct pci_controller ar724x_pci_controller = {
|
|
.pci_ops = &ar724x_pci_ops,
|
|
.io_resource = &ar724x_io_resource,
|
|
.mem_resource = &ar724x_mem_resource,
|
|
};
|
|
|
|
int __init ar724x_pcibios_init(void)
|
|
{
|
|
ar724x_pci_devcfg_base = ioremap(AR724X_PCI_CFG_BASE,
|
|
AR724X_PCI_CFG_SIZE);
|
|
if (ar724x_pci_devcfg_base == NULL)
|
|
return -ENOMEM;
|
|
|
|
register_pci_controller(&ar724x_pci_controller);
|
|
|
|
return PCIBIOS_SUCCESSFUL;
|
|
}
|