Leo Yan 6eadbc3b7a perf lock: Don't free "lock_seq_stat" if read_count isn't zero ... [ Upstream commit b0e5a05cc9 ] When execute command "perf lock report", it hits failure and outputs log as follows: perf: builtin-lock.c:623: report_lock_release_event: Assertion `!(seq->read_count < 0)' failed. Aborted This is an imbalance issue. The locking sequence structure "lock_seq_stat" contains the reader counter and it is used to check if the locking sequence is balance or not between acquiring and releasing. If the tool wrongly frees "lock_seq_stat" when "read_count" isn't zero, the "read_count" will be reset to zero when allocate a new structure at the next time; thus it causes the wrong counting for reader and finally results in imbalance issue. To fix this issue, if detects "read_count" is not zero (means still have read user in the locking sequence), goto the "end" tag to skip freeing structure "lock_seq_stat". Fixes: e4cef1f650 ("perf lock: Fix state machine to recognize lock sequence") Signed-off-by: Leo Yan <leo.yan@linaro.org> Acked-by: Jiri Olsa <jolsa@redhat.com> Link: https://lore.kernel.org/r/20201104094229.17509-2-leo.yan@linaro.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2020-11-24 13:29:05 +01:00
..
Documentation	perf record/stat: Explicitly call out event modifiers in the documentation	2020-09-05 11:22:49 +02:00
arch	perf tools: Fix record failure when mixed with ARM SPE event	2020-08-05 09:59:49 +02:00
bench	perf bench mem: Always memset source before memcpy	2020-08-21 13:05:38 +02:00
examples/bpf	perf augmented_raw_syscalls: Reduce perf_event_output() boilerplate	2019-08-26 11:58:29 -03:00
include/bpf	perf include bpf: Add bpf_tail_call() prototype	2019-07-29 18:34:40 -03:00
jvmti	perf jvmti: Link against tools/lib/ctype.h to have weak strlcpy()	2019-10-15 11:47:38 -03:00
lib	libperf: Add perf_evlist__poll() function	2019-09-25 09:51:49 -03:00
pmu-events	perf jevents: Fix leak of mapfile memory	2020-10-01 13:17:39 +02:00
python	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 407	2019-06-05 17:37:14 +02:00
scripts	perf scripts python: exported-sql-viewer.py: Fix unexpanded 'Find' result	2020-07-16 08:16:47 +02:00
tests	perf test session topology: Fix data path	2020-10-14 10:32:59 +02:00
trace	perf trace: Fix the selection for architectures to generate the errno name tables	2020-10-01 13:18:05 +02:00
ui	perf report TUI: Fix segmentation fault in perf_evsel__hists_browse()	2020-07-16 08:16:38 +02:00
util	perf scripting python: Avoid declaring function pointers with a visibility attribute	2020-11-18 19:20:33 +01:00
.gitignore	perf: Update .gitignore file	2019-08-31 22:27:52 -03:00
Build	perf tools: Rename build libperf to perf	2019-02-14 15:18:08 -03:00
CREDITS	…
MANIFEST	tools lib: Adopt zalloc()/zfree() from tools/perf	2019-07-09 10:13:26 -03:00
Makefile	tools: Let O= makes handle a relative path with -C option	2020-04-01 11:02:00 +02:00
Makefile.config	perf tools: Support Python 3.8+ in Makefile	2020-04-17 10:50:21 +02:00
Makefile.perf	libtraceevent: Move traceevent plugins in its own subdirectory	2019-09-25 09:51:43 -03:00
builtin-annotate.c	perf session: Return error code for perf_session__new() function on failure	2019-09-20 15:58:11 -03:00
builtin-bench.c	perf tools: Remove perf.h from source files not needing it	2019-08-29 17:38:32 -03:00
builtin-buildid-cache.c	perf session: Return error code for perf_session__new() function on failure	2019-09-20 15:58:11 -03:00
builtin-buildid-list.c	perf session: Return error code for perf_session__new() function on failure	2019-09-20 15:58:11 -03:00
builtin-c2c.c	perf c2c: Fix return type for histogram sorting comparision functions	2020-02-05 21:22:40 +00:00
builtin-config.c	perf tools: Remove util.h from where it is not needed	2019-09-20 09:19:20 -03:00
builtin-data.c	perf debug: Remove needless include directives from debug.h	2019-08-31 19:10:19 -03:00
builtin-diff.c	perf diff: Use llabs() with 64-bit values	2020-01-04 19:18:26 +01:00
builtin-evlist.c	perf evsel: Introduce evsel_fprintf.h	2019-09-25 16:26:34 -03:00
builtin-ftrace.c	perf auxtrace: Uninline functions that touch perf_session	2019-08-31 22:24:10 -03:00
builtin-help.c	perf debug: Remove needless include directives from debug.h	2019-08-31 19:10:19 -03:00
builtin-inject.c	perf session: Return error code for perf_session__new() function on failure	2019-09-20 15:58:11 -03:00
builtin-kallsyms.c	perf dsos: Move the dsos struct and its methods to separate source files	2019-08-31 22:24:10 -03:00
builtin-kmem.c	perf kmem: Fix memory leak in compact_gfp_flags()	2019-10-16 10:08:32 -03:00
builtin-kvm.c	perf tools: Propagate get_cpuid() error	2019-09-30 17:29:54 -03:00
builtin-list.c	perf list: Allow plurals for metric, metricgroup	2019-09-25 09:51:42 -03:00
builtin-lock.c	perf lock: Don't free "lock_seq_stat" if read_count isn't zero	2020-11-24 13:29:05 +01:00
builtin-mem.c	perf session: Return error code for perf_session__new() function on failure	2019-09-20 15:58:11 -03:00
builtin-probe.c	perf probe: Do not show the skipped events	2020-06-22 09:31:27 +02:00
builtin-record.c	perf record: Correct the help info of option "--no-bpf-event"	2020-09-09 19:12:36 +02:00
builtin-report.c	perf report: Fix NULL pointer dereference in hists__fprintf_nr_sample_events()	2020-06-24 17:50:45 +02:00
builtin-sched.c	perf evsel: Introduce evsel_fprintf.h	2019-09-25 16:26:34 -03:00
builtin-script.c	perf script: Fix --reltime with --time	2020-01-23 08:23:01 +01:00
builtin-stat.c	perf stat: Skip duration_time in setup_system_wide	2020-10-29 09:57:50 +01:00
builtin-timechart.c	perf session: Return error code for perf_session__new() function on failure	2019-09-20 15:58:11 -03:00
builtin-top.c	perf top: Fix stdio interface input handling with glibc 2.28+	2020-10-14 10:32:59 +02:00
builtin-trace.c	perf trace: Fix segfault when trying to trace events by cgroup	2020-11-18 19:20:18 +01:00
builtin-version.c	perf symbols: Move mem_info and branch_info out of symbol.h	2019-08-31 22:27:48 -03:00
builtin.h	perf tools: Remove needless util.h include from builtin.h	2019-08-28 17:19:34 -03:00
check-headers.sh	tools headers uapi: Sync linux/fs.h with the kernel sources	2019-09-30 17:29:22 -03:00
command-list.txt	…
design.txt	perf/doc: Update design.txt for exclude_{host|guest} flags	2019-01-21 11:01:18 +01:00
perf-archive.sh	…
perf-completion.sh	…
perf-read-vdso.c	perf tools: Make find_vdso_map() more modular	2019-01-08 13:28:13 -03:00
perf-sys.h	perf tools: Make usage of test_attr__* optional for perf-sys.h	2019-10-31 21:38:41 +01:00
perf-with-kcore.sh	Merge branch 'x86/cpu' into perf/core, to pick up dependent changes	2019-06-17 12:29:16 +02:00
perf.c	libperf: Merge libperf_set_print() into libperf_init()	2019-09-25 09:51:49 -03:00
perf.h	perf time-utils: Adopt rdclock() from perf.h	2019-08-29 17:38:32 -03:00