1
0
Fork 0
alistair23-linux/drivers/gpu/drm/mediatek
Colin Ian King 972db497be drm/mediatek: avoid dereferencing a null hdmi_phy on an error message
[ Upstream commit b097efba95 ]

Currently there is a null pointer check for hdmi_phy that implies it
may be null, however a dev_err messages dereferences this potential null
pointer.  Avoid a null pointer dereference by only emitting the dev_err
message if hdmi_phy is non-null.  It is a moot point if the error message
needs to be printed at all, but since this is a relatively new piece of
code it may be useful to keep the message in for the moment in case there
are unforseen errors that need to be reported.

Fixes: be28b6507c ("drm/mediatek: separate hdmi phy to different file")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Addresses-Coverity: ("Dereference after null check")
Link: https://lore.kernel.org/r/20201207150937.170435-1-colin.king@canonical.com
[vkoul: fix indent of return call]
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2020-12-30 11:51:21 +01:00
..
Kconfig treewide: Add SPDX license identifier - Makefile/Kconfig 2019-05-21 10:50:46 +02:00
Makefile drm/mediatek: add hdmi driver for MT2701 and MT7623 2018-10-03 11:56:33 +08:00
mtk_cec.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174 2019-05-30 11:26:41 -07:00
mtk_cec.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174 2019-05-30 11:26:41 -07:00
mtk_disp_color.c drm/mediatek: drop use of drmP.h 2019-07-17 12:52:55 +02:00
mtk_disp_ovl.c drm/mediatek: drop use of drmP.h 2019-07-17 12:52:55 +02:00
mtk_disp_rdma.c drm/mediatek: drop use of drmP.h 2019-07-17 12:52:55 +02:00
mtk_dpi.c drm/mediatek: set dpi pin mode to gpio low to avoid leakage current 2020-06-22 09:30:58 +02:00
mtk_dpi_regs.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174 2019-05-30 11:26:41 -07:00
mtk_drm_crtc.c drm/mediatek: Find the cursor plane instead of hard coding it 2020-03-25 08:25:42 +01:00
mtk_drm_crtc.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174 2019-05-30 11:26:41 -07:00
mtk_drm_ddp.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174 2019-05-30 11:26:41 -07:00
mtk_drm_ddp.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174 2019-05-30 11:26:41 -07:00
mtk_drm_ddp_comp.c drm/mediatek: drop use of drmP.h 2019-07-17 12:52:55 +02:00
mtk_drm_ddp_comp.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174 2019-05-30 11:26:41 -07:00
mtk_drm_drv.c drm/mediatek: Add exception handing in mtk_drm_probe() if component init fail 2020-09-23 12:40:42 +02:00
mtk_drm_drv.h drm/mediatek: set DMA max segment size 2019-08-15 07:43:46 +08:00
mtk_drm_fb.c dma-buf: rename reservation_object to dma_resv 2019-08-13 09:09:30 +02:00
mtk_drm_fb.h drm/mediatek: Use drm_atomic_helper_wait_for_fences 2019-06-25 18:12:57 +02:00
mtk_drm_gem.c drm/mediatek: direct include of drm.h in mtk_drm_gem.c 2019-07-19 23:24:17 +02:00
mtk_drm_gem.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174 2019-05-30 11:26:41 -07:00
mtk_drm_plane.c drm/mediatek: Check plane visibility in atomic_update 2020-07-16 08:16:37 +02:00
mtk_drm_plane.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174 2019-05-30 11:26:41 -07:00
mtk_dsi.c drm/mediatek: drop use of drmP.h 2019-07-17 12:52:55 +02:00
mtk_hdmi.c drm/mediatek: Add missing put_device() call in mtk_hdmi_dt_parse_pdata() 2020-09-23 12:40:42 +02:00
mtk_hdmi.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174 2019-05-30 11:26:41 -07:00
mtk_hdmi_ddc.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174 2019-05-30 11:26:41 -07:00
mtk_hdmi_phy.c drm/mediatek: avoid dereferencing a null hdmi_phy on an error message 2020-12-30 11:51:21 +01:00
mtk_hdmi_phy.h drm/mediatek: no change parent rate in round_rate() for MT2701 hdmi phy 2019-04-09 17:47:01 +08:00
mtk_hdmi_regs.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174 2019-05-30 11:26:41 -07:00
mtk_mipi_tx.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174 2019-05-30 11:26:41 -07:00
mtk_mt2701_hdmi_phy.c drm/mediatek: no change parent rate in round_rate() for MT2701 hdmi phy 2019-04-09 17:47:01 +08:00
mtk_mt8173_hdmi_phy.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174 2019-05-30 11:26:41 -07:00