1
0
Fork 0
alistair23-linux/sound
Arjan van de Ven 4b47c971dc es1968: fix sleep-while-holding-lock bug
snd_es1968_ac97_read() calls snd_es1968_ac97_wait() first outside a locked
area, and later, while holding a lock.

snd_es1968_ac97_wait() has a polling loop with a cond_resched() inside it..
which sleeps, so the second call is invalid.

This patch adds a version of the wait function that just pure polls.  While
this is not very elegant in principle, it's very likely the easiest thing to
do here, we already checked if the chip was ready (while yielding) just
before, so it is very unlikely to take a long time here.

[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Cc: Jaroslav Kysela <perex@suse.cz>
Cc: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-04-08 18:25:53 -07:00
..
aoa [ALSA] Remove sound/driver.h 2008-01-31 17:29:48 +01:00
arm [ALSA] Remove sound/driver.h 2008-01-31 17:29:48 +01:00
core Dont touch fs_struct in drivers 2008-02-14 21:13:32 -08:00
drivers [ALSA] opl3 - Fix compilation without sequencer support 2008-02-22 14:20:08 -08:00
i2c [ALSA] fm801 - Add mute support for FM-only card with FM801 PCI to tuner bridge 2008-01-31 17:30:14 +01:00
isa [ALSA] sb8: fix SB 1.0 capture DMA programming 2008-02-29 11:28:15 +01:00
mips [ALSA] Remove sound/driver.h 2008-01-31 17:29:48 +01:00
oss sound/oss/ac97_codec.c: restore MODULE_LICENSE 2008-03-30 14:46:11 -07:00
parisc [ALSA] Remove sound/driver.h 2008-01-31 17:29:48 +01:00
pci es1968: fix sleep-while-holding-lock bug 2008-04-08 18:25:53 -07:00
pcmcia [ALSA] Remove sound/driver.h 2008-01-31 17:29:48 +01:00
ppc Dont touch fs_struct in drivers 2008-02-14 21:13:32 -08:00
sh [ALSA] Remove sound/driver.h 2008-01-31 17:29:48 +01:00
soc ASoC/TLV320AIC3X: Stop I2C driver ID abuse 2008-03-23 20:28:20 +01:00
sparc [ALSA] Remove sound/driver.h 2008-01-31 17:29:48 +01:00
spi [ALSA] Remove sound/driver.h 2008-01-31 17:29:48 +01:00
synth [ALSA] Remove sound/driver.h 2008-01-31 17:29:48 +01:00
usb USB: usbaudio: handle kcalloc failure 2008-03-10 16:42:25 -07:00
Kconfig [ALSA] Add SPI devices to ALSA Kconfig and Makefile 2007-10-16 15:57:47 +02:00
Makefile [ALSA] Add SPI devices to ALSA Kconfig and Makefile 2007-10-16 15:57:47 +02:00
ac97_bus.c [ALSA] ac97_bus power management 2007-02-09 09:03:54 +01:00
last.c [ALSA] Remove sound/driver.h 2008-01-31 17:29:48 +01:00
sound_core.c [PATCH] mark struct file_operations const 9 2007-02-12 09:48:46 -08:00
sound_firmware.c Detach sched.h from mm.h 2007-05-21 09:18:19 -07:00